[PATCH v4 0/5] reply to sender

2012-01-12 Thread Jani Nikula
atches 3-5 remain unchanged. BR, Jani. Jani Nikula (4): cli: slightly refactor "notmuch reply" address scanning functions cli: add support for replying just to the sender in "notmuch reply" emacs: add support for replying just to the sender emacs: bind 'r' to

[PATCH v4 1/5] cli: slightly refactor "notmuch reply" address scanning functions

2012-01-12 Thread Jani Nikula
al changes. Signed-off-by: Jani Nikula --- notmuch-reply.c | 74 -- 1 files changed, 38 insertions(+), 36 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index 000f6da..4fae66f 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c

[PATCH v4 2/5] cli: add support for replying just to the sender in "notmuch reply"

2012-01-12 Thread Jani Nikula
-sender in add_recipients_from_message(). All bugs are mine, though. Signed-off-by: Jani Nikula --- Settled on --reply-to=(all|sender) per Carl's earlier suggestion (id:87pqn5cg4g@yoom.home.cworth.org) and David's approval on IRC. --- man/man1/notmuch-reply.1 | 28 -

[PATCH v4 3/5] emacs: add support for replying just to the sender

2012-01-12 Thread Jani Nikula
Provide reply to sender counterparts to the search and show reply functions. Add key binding 'R' to reply to sender, while keeping 'r' as reply to all, both in search and show views. Signed-off-by: Jani Nikula --- emacs/notmuch-mua.el |9 ++--- emacs/no

[PATCH v4 4/5] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all

2012-01-12 Thread Jani Nikula
Change the default reply key bindings, making 'r' reply-to-sender and 'R' reply-to-all. Signed-off-by: Jani Nikula --- There were mixed feelings about this. This as a separate patch so it's easy to drop if needed. --- emacs/notmuch-show.el |4 ++-- emacs/notmu

[PATCH v4 5/5] test: add tests for "notmuch reply" --reply-to=sender

2012-01-12 Thread Jani Nikula
From: Mark Walters --- test/notmuch-test|1 + test/reply-to-sender | 209 ++ 2 files changed, 210 insertions(+), 0 deletions(-) create mode 100755 test/reply-to-sender diff --git a/test/notmuch-test b/test/notmuch-test index e40ef86..6a9

Re: [PATCH v4 1/5] cli: slightly refactor "notmuch reply" address scanning functions

2012-01-14 Thread Jani Nikula
On Thu, 12 Jan 2012 16:59:05 -0500, Austin Clements wrote: > LGTM. One thing you could fix below (and a few comments), but not > enough alone to warrant a new version. > > Quoth Jani Nikula on Jan 12 at 11:40 pm: > > Slightly refactor "notmuch reply" recipient an

[PATCH v5 0/5] reply to sender

2012-01-14 Thread Jani Nikula
Hi all, hopefully the final round with only the comment and commit message fixes to issues in patches 1 and 2 spotted by Austin and Mark. Thanks again for a thorough review! BR, Jani. Jani Nikula (4): cli: slightly refactor "notmuch reply" address scanning functions cli: add s

[PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions

2012-01-14 Thread Jani Nikula
al changes. Signed-off-by: Jani Nikula --- notmuch-reply.c | 76 +-- 1 files changed, 40 insertions(+), 36 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index 000f6da..a8d6a94 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c

[PATCH v5 2/5] cli: add support for replying just to the sender in "notmuch reply"

2012-01-14 Thread Jani Nikula
-sender in add_recipients_from_message(). All bugs are mine, though. Signed-off-by: Jani Nikula --- Settled on --reply-to=(all|sender) per Carl's earlier suggestion (id:87pqn5cg4g@yoom.home.cworth.org) and David's approval on IRC. --- man/man1/notmuch-reply.1 | 28 ++-

[PATCH v5 3/5] emacs: add support for replying just to the sender

2012-01-14 Thread Jani Nikula
Provide reply to sender counterparts to the search and show reply functions. Add key binding 'R' to reply to sender, while keeping 'r' as reply to all, both in search and show views. Signed-off-by: Jani Nikula --- emacs/notmuch-mua.el |9 ++--- emacs/no

[PATCH v5 4/5] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all

2012-01-14 Thread Jani Nikula
Change the default reply key bindings, making 'r' reply-to-sender and 'R' reply-to-all. Signed-off-by: Jani Nikula --- There were mixed feelings about this. This as a separate patch so it's easy to drop if needed. --- emacs/notmuch-show.el |4 ++-- emacs/notmu

[PATCH v5 5/5] test: add tests for "notmuch reply" --reply-to=sender

2012-01-14 Thread Jani Nikula
From: Mark Walters --- test/notmuch-test|1 + test/reply-to-sender | 209 ++ 2 files changed, 210 insertions(+), 0 deletions(-) create mode 100755 test/reply-to-sender diff --git a/test/notmuch-test b/test/notmuch-test index e40ef86..6a9

[PATCH] NEWS: add news items for reply to sender

2012-01-14 Thread Jani Nikula
--- NEWS | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index bf21e64..1161c22 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,26 @@ +Notmuch 0.12 (2012-xx-xx) += + +Command-Line Interface +-- + +Reply

Re: [PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions

2012-01-14 Thread Jani Nikula
For those not on IRC: On Sat, 14 Jan 2012 11:31:16 -0400, David Bremner wrote: > This series definitely needs a NEWS item. id:"1326559168-29178-1-git-send-email-j...@nikula.org" > Perhaps some kind soul could add a wiki entry explaining to people how > to swap the bindings, just in case there

Re: [PATCH 2/4] reply: Add a JSON reply format.

2012-01-14 Thread Jani Nikula
On Sun, 8 Jan 2012 00:52:40 -0700, Adam Wolfe Gordon wrote: > From: Adam Wolfe Gordon > > This new JSON format for replies includes headers generated for a reply > message as well as the headers and all text parts of the original message. > Using this data, a client can intelligently create a

[PATCH 1/2] test: add known broken test for reply from address in named group list

2012-01-14 Thread Jani Nikula
If a message was received to the user's address that was in a named group list, notmuch reply does not use that address for picking the from address. Groups lists are of the form: foo:b...@example.com,b...@example.com; Signed-off-by: Jani Nikula --- test/reply | 19 +

[PATCH 2/2] cli: pick the user's address in a group list as from address

2012-01-14 Thread Jani Nikula
Messages received to a group list were not replied to using the from address in the list. Fix it. Signed-off-by: Jani Nikula --- notmuch-reply.c |2 +- test/reply |1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index da3acce

Re: [PATCH v3 09/10] random-dump.c: new test-binary to generate dump files

2012-01-15 Thread Jani Nikula
On Jan 15, 2012 3:41 AM, "David Bremner" wrote: > > From: David Bremner > > This binary creates a "torture test" dump file for the new dump > format. > --- > test/Makefile.local |4 ++ > test/basic |2 +- > test/random-dump.c | 144 +

Re: [PATCH 1/4] emacs: unify search mechanisms

2012-01-16 Thread Jani Nikula
On Mon, 16 Jan 2012 15:39:14 +0400, Dmitry Kurochkin wrote: > On Mon, 16 Jan 2012 11:35:37 +, David Edmondson wrote: > > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin > > wrote: > > > Before the change, there were two ways to do search in Emacs UI: > > > search widget in notmuch-hel

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-16 Thread Jani Nikula
On Mon, 16 Jan 2012 17:46:55 +0100, Pieter Praet wrote: > Make `notmuch-cycle-notmuch-buffers' more Lispy and merge into `notmuch', > eliminating the need to hog yet another keybind. What does "merge" mean here? Will it still be possible for me to hit one key to unconditionally get to notmuch-hel

Re: [PATCH v2] Document external dependencies in the test suite

2012-01-16 Thread Jani Nikula
On Mon, 16 Jan 2012 22:09:55 +0100, Xavier Maillard wrote: > Hi, > > On Mon, 16 Jan 2012 13:52:47 -0500, Ethan Glasser-Camp > wrote: > > [...] > > > +Prerequisites > > +- > > +Some tests require external dependencies to run. Without them, they > > +will be skipped, or (rarely) mar

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread Jani Nikula
On Mon, 16 Jan 2012 15:51:30 -0500, Aaron Ecay wrote: > On Mon, 16 Jan 2012 11:22:27 +, David Edmondson wrote: > > On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet wrote: > > > Alas, those text properties actually *were* effective (and I liked them :) > > > > Well, not in emacs 24. My readi

Re: Partial words on notmuch search?

2012-01-17 Thread Jani Nikula
On Mon, 16 Jan 2012 21:34:31 -0500, Austin Clements wrote: > Quoth Andrei Popescu on Jan 16 at 10:21 pm: > > This is also interesting: > > $ notmuch count 'debian' > > 65888 > > $ notmuch count 'dEbian' > > 65888 > > $ notmuch count 'Debian' > > 65887 > > The first two will match stemmed versions

[PATCH] fix .gitignore for gzipped man pages

2012-01-17 Thread Jani Nikula
--- .gitignore |1 - man/.gitignore |2 ++ 2 files changed, 2 insertions(+), 1 deletions(-) create mode 100644 man/.gitignore diff --git a/.gitignore b/.gitignore index d64ec9f..d428290 100644 --- a/.gitignore +++ b/.gitignore @@ -7,7 +7,6 @@ tags /notmuch notmuch.sym notmuch-shar

Re: on deleting messages

2012-01-17 Thread Jani Nikula
On Tue, 17 Jan 2012 11:01:45 -0800, Jameson Graef Rollins wrote: > Now that Austin's excellent tag exclusion patch set [0] has been pushed, > the question remains if we want to support any delete-handling key > bindings in emacs. > > Based on the show-mode improvements I recently sent [1], the f

Re: [PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer

2012-01-17 Thread Jani Nikula
On Tue, 17 Jan 2012 23:34:08 +0400, Dmitry Kurochkin wrote: > Before the change, "s" in notmuch-hello buffer would jump to the > search box. The patch changes the binding to `notmuch-search' which > is consistent with all other notmuch buffers. > --- > emacs/notmuch-hello.el | 19 ++--

Re: [PATCH 1/3] mime node: Record depth-first part numbers

2012-01-18 Thread Jani Nikula
On Wed, 18 Jan 2012 15:28:25 -0500, Austin Clements wrote: > This makes the part numbers readily accessible to formatters. > Hierarchical part numbering would be a more natural and efficient fit > for MIME and may be the way to go in the future, but depth-first > numbering maintains compatibility

Re: [PATCH 3/3] show: Introduce mime_node formatter callback

2012-01-18 Thread Jani Nikula
On Wed, 18 Jan 2012 15:28:27 -0500, Austin Clements wrote: > This callback is the gateway to the new mime_node_t-based formatters. > This maintains backwards compatibility so the formatters can be > transitioned one at a time. Once all formatters are converted, the > formatter structure can be re

Re: [PATCH v2 2/4] reply: Add a JSON reply format.

2012-01-18 Thread Jani Nikula
On Mon, 16 Jan 2012 11:13:21 -0700, Adam Wolfe Gordon wrote: > This new JSON format for replies includes headers generated for a reply > message as well as the headers and all text parts of the original message. > Using this data, a client can intelligently create a reply. For example, > the emac

Re: [PATCH 0/2] Fix or silence "unused result" warnings

2012-01-19 Thread Jani Nikula
On Wed, 18 Jan 2012 19:40:09 -0500, Austin Clements wrote: > I'm afraid I bikeshedded dme's original patch for this into oblivion > (id:"1324503532-5799-1-git-send-email-...@dme.org") and we still have > these warnings on the buildbot. Tomi convinced me that dme was right > and I was wrong, so I'

Re: [PATCH] lib: Save filenames for files detected as "not an email file" in the database.

2012-01-21 Thread Jani Nikula
On Fri, 20 Jan 2012 17:00:27 -0500, Austin Clements wrote: > Later runs of "notmuch new" won't scan these files again and won't > print warnings. > > Various programs (Dovecot, in my case) store indexes and caches and > such in the maildir. Without this, notmuch persistently complains > about su

Re: [PATCH] lib: Save filenames for files detected as "not an email file" in the database.

2012-01-22 Thread Jani Nikula
On Sat, 21 Jan 2012 18:49:19 -0500, Austin Clements wrote: > Quoth Jani Nikula on Jan 22 at 1:00 am: > > On Fri, 20 Jan 2012 17:00:27 -0500, Austin Clements > > wrote: > > > Later runs of "notmuch new" won't scan these files again and won't > &g

Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

2012-01-22 Thread Jani Nikula
On Mon, 23 Jan 2012 06:05:27 +0100, Pieter Praet wrote: > On Sun, 22 Jan 2012 14:53:41 -0800, Jameson Graef Rollins > wrote: > > On Sun, 22 Jan 2012 23:14:13 +0100, Xavier Maillard > > wrote: > > > > > > On Thu, 19 Jan 2012 20:19:03 +0100, Pieter Praet wrote: > > > > If the 'search.exclude_t

Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

2012-01-23 Thread Jani Nikula
On Sun, 22 Jan 2012 23:38:40 -0800, Jameson Graef Rollins wrote: > On Mon, 23 Jan 2012 07:22:25 +0000, Jani Nikula wrote: > > There really should be a definitive list of tags that are special to > > lib/cli/emacs (like "inbox", "unread", "deleted&quo

Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

2012-01-23 Thread Jani Nikula
On Mon, 23 Jan 2012 09:03:42 +0100, Pieter Praet wrote: > On Mon, 23 Jan 2012 07:22:25 +0000, Jani Nikula wrote: > > On Mon, 23 Jan 2012 06:05:27 +0100, Pieter Praet wrote: > > > On Sun, 22 Jan 2012 14:53:41 -0800, Jameson Graef Rollins > > > wrote: > > >

Re: [PATCH v2 1/3] mime node: Record depth-first part numbers

2012-01-24 Thread Jani Nikula
On Sun, 22 Jan 2012 21:31:11 -0500, Austin Clements wrote: > This makes the part numbers readily accessible to formatters. > Hierarchical part numbering would be a more natural and efficient fit > for MIME and may be the way to go in the future, but depth-first > numbering maintains compatibility

Re: [PATCH v5 2/2] show: Introduce mime_node formatter callback

2012-01-24 Thread Jani Nikula
On Mon, 23 Jan 2012 18:33:10 -0500, Austin Clements wrote: > This callback is the gateway to the new mime_node_t-based formatters. > This maintains backwards compatibility so the formatters can be > transitioned one at a time. Once all formatters are converted, the > formatter structure can be re

Re: [RFC PATCH] bikeshed uncrustify options

2012-01-25 Thread Jani Nikula
Coding style bikeshedding, wonderful. :) On Wed, 25 Jan 2012 17:21:26 +0200, Tomi Ollila wrote: > Is (generally) using *INDENT-(OFF|ON)* ok ? Obviously I wish we could do without. You should cook up a wrapper for uncrustify that takes a patch, applies it, and checks if it introduces new codi

Re: [PATCH 1/2] moved _notmuch_get_list () and _notmuch_set_list () up in file

2012-01-26 Thread Jani Nikula
On Thu, 26 Jan 2012 12:11:57 +0200, Tomi Ollila wrote: > Moved _notmuch_get_list () and _notmuch_set_list () to a location > in notmuch-config.c so that new functions that will be located > before the old location of those functions can also use these. Parse error. ;) You mean something along t

Re: [PATCH 2/2] added support for user-specified directories to exclude

2012-01-26 Thread Jani Nikula
On Thu, 26 Jan 2012 12:11:58 +0200, Tomi Ollila wrote: > A new configuration key 'database.exclude' is used to determine > which directories user wants not to be scanned for new mails. > > --- > > Notes (from 2011-09-13): > > 1) Currently the comments for newly created configuration file are no

Re: Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2012-01-26 Thread Jani Nikula
On Thu, 26 Jan 2012 13:44:50 +0100, Gregor Zattler wrote: > Hi Jamie, Austin, > * Jameson Graef Rollins [25. Jan. 2012]: > > On Wed, 25 Jan 2012 20:19:03 -0500, Austin Clements > > wrote: > >> One very common cause of this is someone using "reply" to get an > >> initial set of recipients, but t

Re: [PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer

2012-01-26 Thread Jani Nikula
On Thu, 26 Jan 2012 14:48:44 +0100, Pieter Praet wrote: > On Tue, 17 Jan 2012 23:22:30 +0200, Jani Nikula wrote: > > [...] > > > > After this, what would the user have to do to bind some key to put the > > point in the search box? If someone wants to restore old b

Re: [PATCH 0/2] re-enable line wrapping and add some header bling

2012-01-26 Thread Jani Nikula
On Thu, 26 Jan 2012 08:17:49 +, David Edmondson wrote: > By default, re-enable `visual-line-mode' in `notmuch-show-mode'. Do it > via a hook so that purists (ahem) can turn it off. > > Add some more processing of headers to make them look nice. Do it via > hooks so that unbelievers can turn i

[PATCH] emacs: add default value to notmuch-search-line-faces

2012-01-26 Thread Jani Nikula
specially both in the lib and emacs ui. "flagged" is synced to maildir F flag in the lib. If one syncs the maildir to IMAP, this also translates to corresponding IMAP flag. (This is "starred" in GMail and Android.) Signed-off-by: Jani Nikula --- emacs/notmuch.el |3

Re: [PATCH] emacs: add default value to notmuch-search-line-faces

2012-01-26 Thread Jani Nikula
On Thu, 26 Jan 2012 14:41:46 -0500, Austin Clements wrote: > Quoth Jani Nikula on Jan 26 at 9:21 pm: > > Add default value to notmuch-search-line-faces to show "unread" > > messages in bold, and "flagged" messages in red, to have some visual > > indicatio

Re: [PATCH 0/2] re-enable line wrapping and add some header bling

2012-01-27 Thread Jani Nikula
On Fri, 27 Jan 2012 06:52:46 +, David Edmondson wrote: > On Thu, 26 Jan 2012 20:17:49 +0400, Dmitry Kurochkin > wrote: > > I did not review the code, but here is a general comment for both > > patches (but especially for the first one). It would be nice to have a > > more detailed documenta

[PATCH] emacs: support limiting the number of results shown in search results

2012-01-27 Thread Jani Nikula
: Jani Nikula --- Rebased since id:"1321560458-32010-1-git-send-email-j...@nikula.org", and added option to limit results to window height. Limiting does not work through the 's' key binding in search view, and some of the issues reported by Austin in id:"2004205415.gj

Re: [PATCH 7/6] emacs: relax tag syntax check in `notmuch-tag' function

2012-01-28 Thread Jani Nikula
On Jan 28, 2012 7:06 AM, "Dmitry Kurochkin" wrote: > > The tag syntax check in `notmuch-tag' function was too strict and did > not allow nmbug tags with "::". Since the check is done for all > tagging operations in Emacs UI, this basically means that no nmbug > tags can be changed. The patch rel

Re: [PATCH 8/6] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

2012-01-28 Thread Jani Nikula
I guess this now includes the optimization of doing the tagging in a single call to notmuch tag. (As opposed to calling it once per msg like it used to be a while back.) There was some discussion about the cmdline length for large threads potentially growing too big when I sent such an optimization

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-28 Thread Jani Nikula
On Jan 28, 2012 2:41 PM, "David Bremner" wrote: > > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > > Less code, same results, without sacrificing readability. > > > > This looks OK, although the re-indenting makes these kind of changes > painful to review (not that I'm suggesting we sh

Re: [PATCH] lib: notmuch_tags_get example was not updated to reflect api change

2012-01-28 Thread Jani Nikula
The subject should be about what this patch does, like "lib: update notmuch_tags_get example to reflect api change" On Jan 29, 2012 12:46 AM, "Allan Wind" wrote: > And preferably you would describe here what the api change was. > --- > lib/notmuch.h | 21 +++-- > 1 files chan

Re: [PATCH] STYLE: Initial draft of coding style document

2012-01-30 Thread Jani Nikula
On Jan 30, 2012 4:38 PM, "Tomi Ollila" wrote: > > On Fri, 27 Jan 2012 19:46:58 -0400, David Bremner wrote: > > From: David Bremner > > [ ... ] > > > + > > +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8. > > + Tabs should be only at the beginning of the line. > > So, after ini

Re: [PATCH 4/5] emacs: Add a binding (>) to toggle the truncation of long lines.

2012-01-30 Thread Jani Nikula
On Jan 30, 2012 6:31 PM, "David Edmondson" wrote: > > --- > emacs/notmuch-show.el |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index a2c4daf..8b07adf 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el

Re: [PATCH] emacs: add default value to notmuch-search-line-faces

2012-01-31 Thread Jani Nikula
On Thu, 26 Jan 2012 23:58:51 +0200, Jani Nikula wrote: > On Thu, 26 Jan 2012 14:41:46 -0500, Austin Clements wrote: > > Quoth Jani Nikula on Jan 26 at 9:21 pm: > > > +("flagged" :foreground "red")) > > > > Red

[RFC PATCH] emacs: make show view a/A/x/X key bindings more consistent

2012-01-31 Thread Jani Nikula
Proposal for show view a/A/x/X key bindings, according to http://titanpad.com/SA39EbNezU and IRC discussion: 'a' = Archive current message, then move to next message, or show next thread from search if at the last message in thread. 'A' = Archive each message in thread, then show next thread from

[RFC PATCH v2] emacs: make show view a/A/x/X key bindings more consistent

2012-01-31 Thread Jani Nikula
Modify the show view key bindings as follows to make them more consistent: 'a' = Archive current message, then move to next message, or show next thread from search if at the last message in thread. 'A' = Archive each message in thread, then show next thread from search. 'x' = Archive current me

Re: [PATCH] added support for user-specified files & directories to ignore

2012-02-02 Thread Jani Nikula
On Tue, 31 Jan 2012 18:28:04 +0200, Tomi Ollila wrote: > A new configuration key 'new.ignore' is used to determine which > files and directories user wants not to be scanned as new mails. Hi, please find a few drive-by "while my code is compiling" nitpick review comments inline. ;) Mostly looks g

[PATCH v2] emacs: add default value to notmuch-search-line-faces

2012-02-02 Thread Jani Nikula
specially both in the lib and emacs ui. "flagged" is synced to maildir F flag in the lib. If one syncs the maildir to IMAP, this also translates to corresponding IMAP flag. (This is "starred" in GMail and Android.) Signed-off-by: Jani Nikula --- emacs/notmuch.el |3

Re: [PATCH] add support for user-specified files & directories to ignore

2012-02-02 Thread Jani Nikula
Hi Tomi, please find a few more comments and nitpicks inline. No need to roll another version for them, though. BR, Jani. On Thu, 2 Feb 2012 17:17:33 +0200, Tomi Ollila wrote: > A new configuration key 'new.ignore' is used to determine which > files and directories user wants not to be scanned

Re: Set "From" based on "To" when replying

2012-02-02 Thread Jani Nikula
On Sat, 21 Jan 2012 16:35:10 +0100, Simon Campese wrote: > Dear Community, > > I've got my own domain and when registering or shopping at some website, > I always use email addresses of the form "websiten...@mydomain.org", so > for example I use "ama...@mydomain.org" when shopping at amazon. The

Re: [PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages

2012-02-02 Thread Jani Nikula
Hi Mark - This is my first look at any version of the series; apologies if I'm clueless about some details... Please find some comments below. BR, Jani. On Thu, 2 Feb 2012 17:43:35 +, Mark Walters wrote: > The function is > notmuch_thread_get_flag_messages > (notmuch_thread_t *thread, u

Re: [PATCH v4 08/11] cli: Make notmuch-show respect excludes.

2012-02-02 Thread Jani Nikula
On Thu, 2 Feb 2012 17:43:36 +, Mark Walters wrote: > This adds the excludes to notmuch-show.c. We do not exclude when only > a single message (or part) is requested. notmuch-show will output the > exclude information when either text or json format is requested. As > this changes the output

Re: [PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages

2012-02-02 Thread Jani Nikula
On Thu, 02 Feb 2012 22:27:36 +, Mark Walters wrote: > On Thu, 02 Feb 2012 23:55:33 +0200, Jani Nikula wrote: > > > > Hi Mark - > > > > This is my first look at any version of the series; apologies if I'm > > clueless about some details... Please

Re: [PATCH v4 08/11] cli: Make notmuch-show respect excludes.

2012-02-02 Thread Jani Nikula
On Thu, 02 Feb 2012 22:35:10 +, Mark Walters wrote: > > On Fri, 03 Feb 2012 00:08:32 +0200, Jani Nikula wrote: > > On Thu, 2 Feb 2012 17:43:36 +, Mark Walters > > wrote: > > > This adds the excludes to notmuch-show.c. We do not exclude when only > >

Re: [PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages

2012-02-03 Thread Jani Nikula
On Thu, 02 Feb 2012 23:24:56 +, Mark Walters wrote: > On Fri, 03 Feb 2012 01:07:59 +0200, Jani Nikula wrote: > > On Thu, 02 Feb 2012 22:27:36 +, Mark Walters > > wrote: > > > On Thu, 02 Feb 2012 23:55:33 +0200, Jani Nikula wrote: > > > > > >

Re: [PATCH v4 07/11] lib: added interface notmuch_thread_get_flag_messages

2012-02-03 Thread Jani Nikula
On Fri, 03 Feb 2012 09:36:29 +, Mark Walters wrote: > On Fri, 03 Feb 2012 08:48:27 +0000, Jani Nikula wrote: > > On Thu, 02 Feb 2012 23:24:56 +, Mark Walters > > wrote: > > > On Fri, 03 Feb 2012 01:07:59 +0200, Jani Nikula wrote: > > > > On T

[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-03 Thread Jani Nikula
tion fails. Signed-off-by: Jani Nikula --- notmuch-show.c | 153 +--- 1 files changed, 79 insertions(+), 74 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index dec799c..f93e121 100644 --- a/notmuch-show.c +++ b/notmuch-show.c

[PATCH 2/2] cli: reach previously unreachable cleanup code in "notmuch show"

2012-02-03 Thread Jani Nikula
The last lines of notmuch_show_command() function were unreachable. Fix it by using a variable for return value. Signed-off-by: Jani Nikula --- notmuch-show.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index f93e121..b18e279

Re: [PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-04 Thread Jani Nikula
On Sat, 04 Feb 2012 00:00:00 +, Mark Walters wrote: > > On Sat, 4 Feb 2012 00:41:08 +0200, Jani Nikula wrote: > > Use the new notmuch argument parser to handle arguments in "notmuch > > show". There are two corner case functional changes: > > &

Re: For gmail how do you setup notmuch mail ?...

2012-02-04 Thread Jani Nikula
On Sat, 04 Feb 2012 09:15:16 +, David Edmondson wrote: > On Sat, 4 Feb 2012 03:39:23 -0500, don warner saklad > wrote: > > a) For gmail how do you setup notmuch mail ?... > > > > b) Any workarounds? > > > > c) Any kludges? I'll describe my own setup for using notmuch with gmail. I don't p

Re: [PATCH 1/2] cli: add --from option to reply to restrict guessing of the From: header.

2012-02-04 Thread Jani Nikula
On Sat, 4 Feb 2012 17:09:09 +, Mark Walters wrote: > Add an option --from= to notmuch-reply.c to restrict guessing of the > From: header. The existing logic looks as the main headers, then at > the delivery headers, and finally defaults to the config file address. > > This patch allows the

Re: [PATCH 2/2] emacs: Improve prompting for user address when replying.

2012-02-04 Thread Jani Nikula
On Sat, 4 Feb 2012 17:09:10 +, Mark Walters wrote: > This patch uses the new --from option to notmuch reply to allow it to > prompt the user for the From: address in cases when the cli does not > know the "correct" from address. If the cli does not it either uses > the users default address

Re: [PATCH v2 1/4] cli: add --from option to reply to restrict guessing of the From: header.

2012-02-04 Thread Jani Nikula
On Sat, 4 Feb 2012 20:45:14 +, Mark Walters wrote: > Add an option --from= to notmuch-reply.c to restrict guessing of the > From: header. The existing logic looks as the main headers, then at > the delivery headers, and finally defaults to the config file address. > > This patch allows the

Re: [Patch v2 0/4] Control selection of From: header when replying

2012-02-05 Thread Jani Nikula
On Sun, 05 Feb 2012 10:58:04 +0400, Dmitry Kurochkin wrote: > Hi Mark. > > I am not sure I like this solution. My concerns are: > > * New option looks too complex, too specific. *shrug* The --from parameter is simple to implement, simple to test, and simple to use. > * There are more aspects

Re: [PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-05 Thread Jani Nikula
On Sun, 5 Feb 2012 23:12:05 -0500, Austin Clements wrote: > Yikes. I don't envy you this patch. Two minor nits, otherwise this > and the next patch LGTM. Thanks for the review. I'll roll another version, I think it will be better with your suggestions incorporated. > Quoth

[PATCH 0/3] notmuch show argument parsing

2012-02-06 Thread Jani Nikula
tter. BR, Jani. Jani Nikula (3): cli: use notmuch_bool_t for boolean fields in notmuch_show_params_t cli: convert "notmuch show" to use the new argument parser cli: reach previously unreachable cleanup code in "notmuch show" notmuch-client.h |6 +- notmuch-reply.c

[PATCH v2 1/3] cli: use notmuch_bool_t for boolean fields in notmuch_show_params_t

2012-02-06 Thread Jani Nikula
Use notmuch_bool_t instead of int for entire_thread, raw, and decrypt boolean fields in notmuch_show_params_t. No functional changes. Signed-off-by: Jani Nikula --- notmuch-client.h |6 +++--- notmuch-reply.c |7 +++ notmuch-show.c | 14 +++--- 3 files changed, 13

[PATCH v2 2/3] cli: convert "notmuch show" to use the new argument parser

2012-02-06 Thread Jani Nikula
d not work previously. 2) Set params.decrypt = FALSE if crypto context creation fails. 3) Only use the parameters for the last --format if specified multiple times. Previously this could have resulted in a non-working mixture of parameters. Signed-off-by: Jani Nikula --- notmuch-sho

[PATCH v2 3/3] cli: reach previously unreachable cleanup code in "notmuch show"

2012-02-06 Thread Jani Nikula
The last lines of notmuch_show_command() function were unreachable. Fix it by using a variable for return value. Signed-off-by: Jani Nikula --- notmuch-show.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index b358278..c8fbd79

Re: [PATCH] Free the results of scandir()

2012-02-06 Thread Jani Nikula
On Mon, 6 Feb 2012 17:02:49 -0500, Ethan Glasser-Camp wrote: > From: Ethan Glasser-Camp > > scandir() returns "strings allocated via malloc(3)" which are then > "collected in array namelist which is allocated via > malloc(3)". Currently we just free the array namelist. Instead, free > all the

Re: [PATCH v2] Free the results of scandir()

2012-02-07 Thread Jani Nikula
On Tue, 7 Feb 2012 01:50:05 -0500, Ethan Glasser-Camp wrote: > From: Ethan Glasser-Camp > > scandir() returns "strings allocated via malloc(3)" which are then > "collected in array namelist which is allocated via > malloc(3)". Currently we just free the array namelist. Instead, free > all the

[PATCH v2] emacs: call "notmuch tag" only once when archiving a thread

2012-02-07 Thread Jani Nikula
the number of messages that can be archived at the same time (through ARG_MAX limiting the command line). While at least on Linux this seems more like a theoretical limitation than a real one, it could be avoided by archiving at most a few hundred messages at a time. Signed-off-by: Jani Nikula ---

Re: For gmail how do you setup notmuch mail ?...

2012-02-08 Thread Jani Nikula
On Wed, 08 Feb 2012 09:15:59 -, Patrick Totzke wrote: > Quoting Alex Botero-Lowry (2012-02-08 08:24:51) > >I'm using a similar setup.  An inconvenience with the setup is that I > > have > >various filters in gmail that filter, e.g., mailing list mails by > > skipping > >the gmai

[PATCH 0/2] multipart/alternative display and text/calendar

2012-02-08 Thread Jani Nikula
nt to always see (nil and t work as before): (setq notmuch-show-all-multipart/alternative-parts '("text/calendar")) Patch 2 parses text/calendar as text/x-vcalendar for me so I don't have to. BR, Jani. Jani Nikula (2): emacs: support defining a list of alternative parts to

[PATCH 1/2] emacs: support defining a list of alternative parts to show

2012-02-08 Thread Jani Nikula
Make notmuch-show-all-multipart/alternative-parts accept a list of multipart/alternative types to show in addition to the preferred types. This allows the user to force display some alternative part types while normally showing just the preferred ones. Signed-off-by: Jani Nikula --- emacs

[PATCH 2/2] emacs: regard text/calendar as text/x-vcalendar

2012-02-08 Thread Jani Nikula
Treat text/calendar as text/x-vcalendar. At least the following produce text/calendar that parse as text/x-vcalendar: PRODID:-//Google Inc//Google Calendar 70.9054//EN PRODID:Microsoft Exchange Server 2010 Code by David Edmondson --- I wish I had some references here, other than my own maildir

Re: A big thank you for the major tagging speedup

2012-02-09 Thread Jani Nikula
On Thu, 09 Feb 2012 09:57:30 +0200, Tomi Ollila wrote: > On Wed, 8 Feb 2012 22:20:54 -0600, Michael Roth wrote: > > Anyone know what commit fixed this? Curious whether I'm using or not > > already > > No, you're not. > id:"1328719731-13402-1-git-send-email-dmitry.kuroch...@gmail.com" > > Will

[PATCH v2 1/2] emacs: support defining a list of alternative parts to show

2012-02-09 Thread Jani Nikula
: Jani Nikula --- emacs/notmuch-show.el | 23 ++- 1 files changed, 18 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 24fde05..5f643f1 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -94,10 +94,20 @@ any given

[PATCH v2 2/2] emacs: support text/calendar mime type

2012-02-09 Thread Jani Nikula
Replace text/x-vcalendar with text/calendar, while maintaining support and backwards compatibility for text/x-vcalendar. Code by David Edmondson --- emacs/notmuch-show.el |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el i

Re: [PATCH v2 1/2] emacs: support defining a list of alternative parts to show

2012-02-10 Thread Jani Nikula
On Fri, 10 Feb 2012 10:05:46 +, David Edmondson wrote: > On Thu, 9 Feb 2012 14:46:02 +0000, Jani Nikula wrote: > > Make notmuch-show-all-multipart/alternative-parts accept a list of > > regexps to match the part types to determine which parts to show in > > addition t

Re: [PATCH v2 1/2] emacs: support defining a list of alternative parts to show

2012-02-12 Thread Jani Nikula
On Fri, 10 Feb 2012 10:05:46 +, David Edmondson wrote: > On Thu, 9 Feb 2012 14:46:02 +0000, Jani Nikula wrote: > > Make notmuch-show-all-multipart/alternative-parts accept a list of > > regexps to match the part types to determine which parts to show in > > addition t

Re: [PATCH] emacs: Fix display of highlighted line in notmuch-show

2012-02-14 Thread Jani Nikula
On Tue, 14 Feb 2012 11:24:16 +0100, Michal Sojka wrote: > When notmuch-search-line-faces is used to set background color in search > results, the highlight of the current line is not always displayed > correctly. This patch fixes that by increasing the priority property of > the highlight overlay

Re: [PATCH] emacs: Add the option of counting threads in notmuch-hello

2012-02-15 Thread Jani Nikula
On Wed, 15 Feb 2012 19:14:19 +0200, Tomi Ollila wrote: > On Wed, 15 Feb 2012 09:23:31 -0700, Adam Wolfe Gordon > wrote: > > On Wed, Feb 15, 2012 at 08:52, Dmitry Kurochkin > > wrote: > > > Can we delay this patch until user-defined sections are pushed?  I know > > > I promised to review it long

Re: search by date range

2012-02-16 Thread Jani Nikula
On Thu, 16 Feb 2012 12:58:00 -0500, Philippe LeCavalier wrote: > I really like searching my inde by date and I came across a post that I > can't seems to find for the life of me regarding the functionality of > doing such a thing. I'll I'm left with is this[1] and I can't figure out > what the he

Re: [PATCH] emacs: Mention race condition safety in user visible documentation

2012-02-18 Thread Jani Nikula
On Feb 19, 2012 12:44 AM, "Michal Sojka" wrote: > > After recent rework of a/A/x/X key bindings, the important paragraph in > documentation of `notmuch-show-archive-thread' stayed hidden from users, > because no key is bound to this function. > > This patch copies the important paragraph to the do

[RFC PATCH 0/2] natural language date range search

2012-02-19 Thread Jani Nikula
parser with a command line tool is at [1], and there's a README [2] with a bunch of details too. BR, Jani. [1] https://gitorious.org/parse-time-string/parse-time-string [2] https://gitorious.org/parse-time-string/parse-time-string/blobs/master/README Jani Nikula (2): lib: add date/time p

[RFC PATCH 1/2] lib: add date/time parser

2012-02-19 Thread Jani Nikula
Signed-off-by: Jani Nikula --- lib/Makefile.local |1 + lib/parse-time-string.c | 1304 +++ lib/parse-time-string.h | 95 3 files changed, 1400 insertions(+), 0 deletions(-) create mode 100644 lib/parse-time-string.c create mode

[RFC PATCH 2/2] lib: add date range search

2012-02-19 Thread Jani Nikula
(in most cases) '-' or (in some cases) leave the spaces out altogether. Entering date:expr without ".." (for example date:yesterday) won't work. You can achieve the expected result by duplicating the expr both sides of ".." (for example date:yesterday..yesterday)

Re: [PATCH v2 1/2] emacs: support defining a list of alternative parts to show

2012-02-20 Thread Jani Nikula
On Thu, 9 Feb 2012 14:46:02 +, Jani Nikula wrote: > Make notmuch-show-all-multipart/alternative-parts accept a list of > regexps to match the part types to determine which parts to show in > addition to the preferred types. This allows the user to force display > some alternativ

  1   2   3   4   5   6   7   8   9   10   >