[PATCH 3/4] emacs: Explicitly depend on Emacs 24

2020-04-15 Thread Jonas Bernoulli
We use various things that were not available in earlier versions. --- emacs/notmuch-pkg.el.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emacs/notmuch-pkg.el.tmpl b/emacs/notmuch-pkg.el.tmpl index de97baac..3eb0e04e 100644 --- a/emacs/notmuch-pkg.el.tmpl +++

[PATCH 4/4] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-15 Thread Jonas Bernoulli
Starting with Emacs 27 the old `cl' implementation is finally considered obsolete. Previously its use was strongly discouraged at run-time but one was still allowed to use it at compile-time. For the most part the transition is very simple and boils down to adding the "cl-" prefix to some

[PATCH 0/4] Use cl-lib instead of deprecated cl

2020-04-15 Thread Jonas Bernoulli
controversial, but am limiting this initial patch series to just the cl-lib commit and a few harmless fixes. Jonas Bernoulli (4): gitignore: Ignore generated python-cffi files emacs: Declare function notmuch-show-get-message-id emacs: Explicitly depend on Emacs 24 emacs: Use `cl-lib

[PATCH 1/4] gitignore: Ignore generated python-cffi files

2020-04-15 Thread Jonas Bernoulli
--- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 468b660a..1c8705ec 100644 --- a/.gitignore +++ b/.gitignore @@ -16,3 +16,4 @@ tags /releases /.stamps *.stamp +/bindings/python-cffi/build/ -- 2.26.0

[PATCH 2/4] emacs: Declare function notmuch-show-get-message-id

2020-04-15 Thread Jonas Bernoulli
--- emacs/notmuch-crypto.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index 4035ee37..30425fbc 100644 --- a/emacs/notmuch-crypto.el +++ b/emacs/notmuch-crypto.el @@ -24,6 +24,8 @@ (require 'epg) (require 'notmuch-lib)

Re: easy (?) elisp project for notmuch [it's mostly DONE]

2020-04-15 Thread Jonas Bernoulli
Nice to run into you. Do you contribute to *all* the killer apps? ;D Kyle Meyer writes: > [ in case it's useful in the future ] > I've recently set up a public-inbox archive of notmuch Absolutely! In fact I already had a bookmark about that somewhere. > From there, you can easily download an

[PATCH v2] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-17 Thread Jonas Bernoulli
Starting with Emacs 27 the old `cl' implementation is finally considered obsolete. Previously its use was strongly discouraged at run-time but one was still allowed to use it at compile-time. For the most part the transition is very simple and boils down to adding the "cl-" prefix to some

Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-17 Thread Jonas Bernoulli
David Bremner writes: > A quick git grep suggests there are still cl-isms in the test-harness. I've fixed that now, see v2. > I get 3 test failures I am having issues running the tests. Currently notmuch-mua-send-and-exit in emacs_deliver_message from test-lib.sh just hangs for me. I

[PATCH v3 1/3] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-25 Thread Jonas Bernoulli
Starting with Emacs 27 the old `cl' implementation is finally considered obsolete. Previously its use was strongly discouraged at run-time but one was still allowed to use it at compile-time. For the most part the transition is very simple and boils down to adding the "cl-" prefix to some

[PATCH v3 3/3] emacs: Use `dolist' instead of `mapcar' for side-effects

2020-04-25 Thread Jonas Bernoulli
As recommended by the byte-compiler. --- test/emacs-attachment-warnings.el | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/test/emacs-attachment-warnings.el b/test/emacs-attachment-warnings.el index a23692d7..8f4918ef 100644 ---

[PATCH v3 2/3] emacs: Add simple make target to compile emacs lisp tests

2020-04-25 Thread Jonas Bernoulli
--- test/Makefile.local | 4 1 file changed, 4 insertions(+) diff --git a/test/Makefile.local b/test/Makefile.local index 47244e8f..3c043717 100644 --- a/test/Makefile.local +++ b/test/Makefile.local @@ -78,6 +78,10 @@ endif check: test +compile-elisp-tests: + $(EMACS) --batch -L

Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-25 Thread Jonas Bernoulli
I have fixed the remaining issues and added two small commits. See v3. > Or of course you can/should get the tests running locally. The problem was that there are incompatible changes in Emacs 27. I am using Emacs 26 for the time being but will look into these breaking changes later. The

Re: easy (?) elisp project for notmuch [it's mostly DONE]

2020-04-14 Thread Jonas Bernoulli
> As of Emacs 27, Emacs will start issuing deprecation warnings for > packages that load cl.el. I _think_ it's just a matter of replacing > functions and macros from cl.el with cl- prefixed ones, but I > haven't really investigated. > If someone is looking for an easy way to contribute, this

Re: [PATCH v3 2/3] emacs: Add simple make target to compile emacs lisp tests

2020-05-26 Thread Jonas Bernoulli
David Bremner writes: > Jonas Bernoulli writes: > >> +compile-elisp-tests: >> +$(EMACS) --batch -L emacs -L test -l notmuch.el -l test-lib.el -f \ >> +batch-byte-compile test/*.el >> + > > Can you explain a bit (perhaps in an updated commit message) w