Re: [RFC][PATCH] tags_to_maildir_flags: Add option to not move messages from new/ to cur/

2011-06-24 Thread Louis Rilling
that this would be acceptable? Thanks, Louis [1] There's a bug open about the second problem (thanks to ccxCZ for finding this): http://dev.mutt.org/trac/ticket/2476 Of course, fixing that implies addressing the first problem, too. On Thu, Jun 23, 2011 at 11:36 AM, Louis Rilling l.rill

[PATCH 0/2] lib: Don't always move from maildir new/ to maildir cur/

2011-07-11 Thread Louis Rilling
messages will be kept in new/, even with [new] tags=inbox;unread; [maildir] synchronize_flags=true as long as no maildir flags have to be changed. The first patch can be applied independently. Thanks, Louis Louis Rilling (2): tags_to_maildir_flags

[PATCH 1/2] tags_to_maildir_flags: Cleanup double assignement

2011-07-11 Thread Louis Rilling
The for loop right after already does the job. Signed-off-by: Louis Rilling l.rill...@av7.net --- lib/message.cc |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index d993cde..64b6cf8 100644 --- a/lib/message.cc +++ b/lib/message.cc

[PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags change

2011-07-11 Thread Louis Rilling
(and maybe other MUAs showing the new status) users checking the new status. Signed-off-by: Louis Rilling l.rill...@av7.net --- lib/message.cc | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index 64b6cf8..131d99b 100644 --- a/lib

[PATCH v2] tags_to_maildir_flags: Don't rename if no flags change

2011-07-11 Thread Louis Rilling
(and maybe other MUAs showing the new status) users checking the new status. Changelog: * v2: Fix bool type as well as NULL returned despite having no errors (Austin Clements) Signed-off-by: Louis Rilling l.rill...@av7.net --- lib/message.cc | 12 +++- 1 files changed, 11 insertions

Re: [PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags change

2011-07-12 Thread Louis Rilling
On 11/07/11 20:03 -0400, Austin Clements wrote: The convention in notmuch is to use notmuch_bool_t, TRUE, and FALSE (though, admittedly, I don't know why; avoiding C99-isms?) And bool is already used at another place in message.cc: struct maildir_flag_tag { char flag;

[PATCH 0/3 v3] lib: Maildir flags synchronization fixes

2011-07-12 Thread Louis Rilling
as notmuch can respect the maildir specification. Changelog: * v3: Added patch to kill the last usage of C++ type bool * v2: Fix bool type as well as NULL returned despite having no errors (Austin Clements) Thanks, Louis Louis Rilling (3): lib: Kill last usage of C++ type bool

[PATCH 1/3] lib: Kill last usage of C++ type bool

2011-07-12 Thread Louis Rilling
Signed-off-by: Louis Rilling l.rill...@av7.net --- lib/message.cc | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index d993cde..cf651e5 100644 --- a/lib/message.cc +++ b/lib/message.cc @@ -49,16 +49,16 @@ struct visible

[PATCH 2/3] tags_to_maildir_flags: Cleanup double assignement

2011-07-12 Thread Louis Rilling
The for loop right after already does the job. Signed-off-by: Louis Rilling l.rill...@av7.net --- lib/message.cc |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index cf651e5..b1b2942 100644 --- a/lib/message.cc +++ b/lib/message.cc

Re: [PATCH] test: Adding non-maildir tags does not move message from new to cur

2011-07-14 Thread Louis Rilling
On 14/07/11 2:06 +0200, Michal Sojka wrote: From: Michal Sojka so...@os.inf.tu-dresden.de This adds a test for patch submitted by Louis Rilling. Without his patch applied this test fails. Thanks a lot Michal! I was indeed wondering how to do this. This test perfectly matches the intended

Re: [PATCH] notmuch restore --accumulate

2011-09-09 Thread Louis Rilling
On 05/09/11 12:31 -0700, Jameson Graef Rollins wrote: Also, we generally prefer to have modifications to the test suite in separate patches that precede the patches that add the features/fix the bugs. For new features, this does not look like 'git bisect'-safe. I would say that the testsuite

[PATCH 2/4] tags_to_maildir_flags: Cleanup double assignement

2011-09-14 Thread Louis Rilling
The for loop right after already does the job. Signed-off-by: Louis Rilling l.rill...@av7.net --- lib/message.cc |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index cf651e5..b1b2942 100644 --- a/lib/message.cc +++ b/lib/message.cc

[PATCH 3/4] test: Adding non-maildir tags does not move message from new to cur

2011-09-14 Thread Louis Rilling
changes, and tag the test as broken until the actual changes are implemented -- Louis Rilling ] Signed-off-by: Louis Rilling l.rill...@av7.net --- test/maildir-sync |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/test/maildir-sync b/test/maildir-sync index a60854f

[PATCH 4/4] tags_to_maildir_flags: Don't rename if no flags change

2011-09-14 Thread Louis Rilling
(and maybe other MUAs showing the new status) users checking the new status. Changelog: * v2: Fix bool type as well as NULL returned despite having no errors (Austin Clements) * v4: Tag the related test (contributed by Michal Sojka) as working Signed-off-by: Louis Rilling l.rill...@av7.net

[RFC][PATCH] tags_to_maildir_flags: Add option to not move messages from "new/" to "cur/"

2011-06-23 Thread Louis Rilling
ildir]" section of .notmuch-config, so that users can configure whether commands "notmuch tag" and "notmuch restore" preserve the "new" status or not. Signed-off-by: Louis Rilling --- Hi, I'm in the process of using notmuch, but the issue "addressed&

[RFC][PATCH] tags_to_maildir_flags: Add option to not move messages from "new/" to "cur/"

2011-06-24 Thread Louis Rilling
> > [1] There's a bug open about the second problem (thanks to ccxCZ for > finding this): > http://dev.mutt.org/trac/ticket/2476 > Of course, fixing that implies addressing the first problem, too. > > On Thu, Jun 23, 2011 at 11:36 AM, Louis Rilling wrote: > > no

[PATCH 0/2] lib: Don't always move from maildir new/ to maildir cur/

2011-07-11 Thread Louis Rilling
flags=true messages will be kept in "new/", even with [new] tags=inbox;unread; [maildir] synchronize_flags=true as long as no maildir flags have to be changed. The first patch can be applied independently. Thanks, Louis Louis Rilling (2): tags_to_ma

[PATCH 1/2] tags_to_maildir_flags: Cleanup double assignement

2011-07-11 Thread Louis Rilling
The for loop right after already does the job. Signed-off-by: Louis Rilling --- lib/message.cc |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index d993cde..64b6cf8 100644 --- a/lib/message.cc +++ b/lib/message.cc @@ -1172,8 +1172,6

[PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags change

2011-07-11 Thread Louis Rilling
cur/", only if no flags have to be changed. It's hopefully enough to satisfy mutt (and maybe other MUAs showing the "new" status) users checking the "new" status. Signed-off-by: Louis Rilling --- lib/message.cc | 12 +++- 1 files changed, 11 insertions(+), 1 deletion

[PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags change

2011-07-12 Thread Louis Rilling
elow. They should be addressed by the follow-up patch. Just a comment below. > > Quoth Louis Rilling on Jul 11 at 4:36 pm: > > notmuch_message_tags_to_maildir_flags() unconditionally moves messages from > > maildir directory "new/" to maildir directory "cur/"

[PATCH v2] tags_to_maildir_flags: Don't rename if no flags change

2011-07-12 Thread Louis Rilling
cur/", only if no flags have to be changed. It's hopefully enough to satisfy mutt (and maybe other MUAs showing the "new" status) users checking the "new" status. Changelog: * v2: Fix bool type as well as NULL returned despite having no errors (Austin Clements) Signed-off-

[PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags change

2011-07-12 Thread Louis Rilling
On 11/07/11 20:03 -0400, Austin Clements wrote: > > > The convention in notmuch is to use notmuch_bool_t, TRUE, and FALSE > > > (though, admittedly, I don't know why; avoiding C99-isms?) > > > > And bool is already used at another place in message.cc: > > > > struct maildir_flag_tag { > >

[PATCH 2/3] tags_to_maildir_flags: Cleanup double assignement

2011-07-12 Thread Louis Rilling
The for loop right after already does the job. Signed-off-by: Louis Rilling --- lib/message.cc |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index cf651e5..b1b2942 100644 --- a/lib/message.cc +++ b/lib/message.cc @@ -1172,8 +1172,6

[PATCH] test: Adding non-maildir tags does not move message from new to cur

2011-07-14 Thread Louis Rilling
On 14/07/11 2:06 +0200, Michal Sojka wrote: > From: Michal Sojka > > This adds a test for patch submitted by Louis Rilling. Without his patch > applied this test fails. Thanks a lot Michal! I was indeed wondering how to do this. This test perfectly matches the intended u

[PATCH] notmuch restore --accumulate

2011-09-09 Thread Louis Rilling
On 05/09/11 12:31 -0700, Jameson Graef Rollins wrote: > Also, we generally prefer to have modifications to the test suite in > separate patches that precede the patches that add the features/fix the > bugs. > For new features, this does not look like 'git bisect'-safe. I would say that the

[PATCH 0/4 v4] lib: Maildir flags synchronization fixes

2011-09-15 Thread Louis Rilling
- included the test contributed by Michal Sojka * v3: Added patch to kill the last usage of C++ type bool * v2: Fix bool type as well as NULL returned despite having no errors (Austin Clements) Thanks, Louis Louis Rilling (3): lib: Kill last usage of C++ type bool tags_to_mai

[PATCH 1/4] lib: Kill last usage of C++ type bool

2011-09-15 Thread Louis Rilling
Signed-off-by: Louis Rilling --- lib/message.cc | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index d993cde..cf651e5 100644 --- a/lib/message.cc +++ b/lib/message.cc @@ -49,16 +49,16 @@ struct visible _notmuch_message

[PATCH 2/4] tags_to_maildir_flags: Cleanup double assignement

2011-09-15 Thread Louis Rilling
The for loop right after already does the job. Signed-off-by: Louis Rilling --- lib/message.cc |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index cf651e5..b1b2942 100644 --- a/lib/message.cc +++ b/lib/message.cc @@ -1172,8 +1172,6

[PATCH 3/4] test: Adding non-maildir tags does not move message from new to cur

2011-09-15 Thread Louis Rilling
mit log to better describe the intended changes, and tag the test as broken until the actual changes are implemented -- Louis Rilling ] Signed-off-by: Louis Rilling --- test/maildir-sync |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/test/maildir-sync b/test/maildir-sync ind

[PATCH 4/4] tags_to_maildir_flags: Don't rename if no flags change

2011-09-15 Thread Louis Rilling
cur/", only if no flags have to be changed. It's hopefully enough to satisfy mutt (and maybe other MUAs showing the "new" status) users checking the "new" status. Changelog: * v2: Fix bool type as well as NULL returned despite having no errors (Austin Clements) * v4: T