patch: notmuch-mua.el -- message-hidden-headers

2011-07-30 Thread Tomi Ollila
notmuch-mua.el fails to byte-compile on emacs 22.2.1 The reason is bug in function notmuch-mua-add-more-hidden-headers; on emacs 23.x it compiles ok, but works incorrectly: The check which check whether the header is there already always returns nil. Examples: (setq foo (list x foo bar))

Added messages / total files count difference.

2011-08-09 Thread Tomi Ollila
Hi I get this output: $ notmuch new --verbose Found 15559 total files (that's not much mail). Processed 15559 total files in 5m 53s (43 files/sec.). Added 15546 new messages to the database. $ find * -type f | wc 15559 15559 529027 How can I determine which 13 files were dropped. All of

Re: Added messages / total files count difference.

2011-08-10 Thread Tomi Ollila
On Tue 09 Aug 2011 14:02, Tomi Ollila tomi.oll...@nixu.com writes: Hi I get this output: $ notmuch new --verbose Found 15559 total files (that's not much mail). Processed 15559 total files in 5m 53s (43 files/sec.). Added 15546 new messages to the database. $ find * -type f | wc

PATCH: (more) compability with emacs 22

2011-08-16 Thread Tomi Ollila
Hi Currently, notmuch-lib.el does not have enough emacs 23 compability functions. This patch makes notmuch better compatible with emacs 22: --8888888888-- diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index f93c957..d6b4108 100644 ---

Re: [PATCH] Do not query on notmuch-search exit

2011-08-22 Thread Tomi Ollila
On Mon 22 Aug 2011 17:28, Tomi Ollila tomi.oll...@nixu.com writes: On Mon 22 Aug 2011 16:49, Michal Sojka sojk...@fel.cvut.cz writes: id:871uwhz228@servo.factory.finestructure.net. Can anyone check whether this works with emacs earlier than 23.2 or whether we need to check for version

Re: [RFC PATCH 0/3] add user friendly date range search

2011-08-23 Thread Tomi Ollila
On Tue 23 Aug 2011 19:39, Jason Woofenden ja...@jasonwoof.com writes: Here's my thoughts on date/range syntax: I think: date:monday should show only e-mails that arrived on monday (not also emails that arrived since then.) Because that's what it looks like it does. I think a very common

patch: notmuch-mua.el -- message-hidden-headers

2011-08-24 Thread Tomi Ollila
Hi As of 2011-07-27 ,the function notmuch-mua-add-more-hidden-headers will fail to work (or the file to byte-compile) on emacs 22.2.1. On emacs 23.2.1 the evaluation of (member header 'message-hidden-headers) will always return 'nil'. examples (on emacs 22.2.1 scratch buffer): (setq foo (list

[PATCH] Separated and added functions for emacses prior to 23.

2011-08-29 Thread Tomi Ollila
A new file, emacs/notmuch-lib22.el was created and it is required in emacs/notmuch-lib.el in case emacs-major-version is less than 23. This file contains functions that were copied from emacs 23.3 (verbatim). The support for emacs versions less than 23 is far from complete; many runtime errors

Patch formatting: (was: remove GNU specific nm option from version script)

2011-08-30 Thread Tomi Ollila
On Tue 30 Aug 2011 12:20, Matthias Guedemann matthias.guedem...@googlemail.com writes: hi all, I compiled notmuch on OpenBSD and stumbled onto the usage of the GNU specific option --defined to nm. I replaced this with calling nm without options and then filtering the output with grep

Re: Patch formatting:

2011-08-30 Thread Tomi Ollila
On Tue 30 Aug 2011 14:24, David Bremner da...@tethera.net writes: On Tue, 30 Aug 2011 14:04:03 +0300, Tomi Ollila tomi.oll...@nixu.com wrote: PS: Maybe we should have just one page anyone can refer in reply emails like this? Sure, feel free to add such a page to the notmuch wiki

Re: Patch formatting:

2011-08-30 Thread Tomi Ollila
On Tue 30 Aug 2011 16:04, Tomi Ollila tomi.oll...@nixu.com writes: On Tue 30 Aug 2011 14:24, David Bremner da...@tethera.net writes: On Tue, 30 Aug 2011 14:04:03 +0300, Tomi Ollila tomi.oll...@nixu.com wrote: PS: Maybe we should have just one page anyone can refer in reply emails like

Re: Patch formatting:

2011-08-30 Thread Tomi Ollila
On Wed 31 Aug 2011 04:33, Jameson Graef Rollins jroll...@finestructure.net writes: On Tue, 30 Aug 2011 21:22:15 -0400, Austin Clements amdra...@mit.edu wrote: I would say start right off with git send-email, since it takes care of every single formatting guideline and also makes it easy to

Re: Patch formatting:

2011-08-30 Thread Tomi Ollila
On Wed 31 Aug 2011 08:22, Tomi Ollila tomi.oll...@iki.fi writes: On Wed 31 Aug 2011 04:33, Jameson Graef Rollins jroll...@finestructure.net writes: Yeah, I'm not sure why/how that keeps getting lost. Just use git send-email! It takes care of everything. Ok I change the order to prefer

Patch formatting

2011-09-01 Thread Tomi Ollila
Hi Please check (now updated) http://notmuchmail.org/patchformatting/ page. Anything that can me used to improve the content (even furtner!) are greatly appreciated. Tomi ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH] Skip dot files in `notmuch new`

2011-09-01 Thread Tomi Ollila
On Fri 02 Sep 2011 03:52, Tom Prince tom.pri...@ualberta.net writes: On Tue, 23 Aug 2011 20:11:53 -0400, James Vasile ja...@hackervisions.org wrote: No known mail client or fetch tool stores mail in dot files, because files that start with '.' are usually used to store metadata (i.e. state

Re: [PATCH] emacs: Sort saved searches

2011-09-03 Thread Tomi Ollila
On Fri 02 Sep 2011 15:28, Jani Nikula j...@nikula.org writes: Display saved searches sorted, like tags are displayed. This only affects the display of the saved searches, not the order in which they are stored in .emacs. Signed-off-by: Jani Nikula j...@nikula.org --- Fun! I reveresed the

[PATCH 0/3] Configuration file option to exclude files/directories

2011-09-13 Thread tomi . ollila
This patch set adds a configuration option 'database.exclude'; a list of files/directories to be excluded when doing 'notmuch new' operation. Notes: 1) Currently the comments for newly created configuration file are not updated, so for not this is 'undocumented feature'. Should there be an empty

[PATCH 1/3] added function notmuch_talloc_g_key_file_get_string_list()

2011-09-13 Thread tomi . ollila
From: Tomi Ollila tomi.oll...@iki.fi The function notmuch_talloc_g_key_file_get_string_list() wraps call to g_key_file_get_string_list() in a way that the returned string array is copied to talloc'd memory area. The returned pointer is itself also a talloc context, child of the context given

[PATCH 2/3] Made notmuch_config_get_new_tags() use notmuch_talloc_g_key_file_get_string_list().

2011-09-13 Thread tomi . ollila
From: Tomi Ollila tomi.oll...@iki.fi --- notmuch-config.c | 26 +- 1 files changed, 5 insertions(+), 21 deletions(-) diff --git a/notmuch-config.c b/notmuch-config.c index 706f481..648639b 100644 --- a/notmuch-config.c +++ b/notmuch-config.c @@ -606,29 +606,13 @@ const

[PATCH 3/3] added support for user-specified directories to exclude

2011-09-13 Thread tomi . ollila
From: Tomi Ollila tomi.oll...@iki.fi A new configuration key 'database.exclude' is used to determine which directories user wants not to be scanned for new mails. --- notmuch-client.h |3 +++ notmuch-config.c | 19 +++ notmuch-new.c| 22 -- 3 files

Re: Concerns regarding some library functions

2011-10-04 Thread Tomi Ollila
On Tue 04 Oct 2011 14:18, David Bremner da...@tethera.net writes: So I've pushed the ABI changes, making it more urgent to do something about this. At this point I'm inclined to bump the soname in order to unbreak things, unless someone wants to come up with a convincing set of patches to

Re: [RFC/PATCH] notmuch link

2011-10-06 Thread Tomi Ollila
On Tue 04 Oct 2011 00:15, Ali Polatel pola...@gmail.com writes: Ali Polatel yazmış: This mail is merely a request for comments and testing. Sigh... I have just noticed notmuch show learned --format=mbox which makes this patch rather pointless for me. This changeset will keep living under

Re: output file argument to notmuch dump.

2011-10-07 Thread Tomi Ollila
On Fri 07 Oct 2011 13:23, Jesse Rosenthal jrosent...@jhu.edu writes: On Thu, 06 Oct 2011 21:20:40 -0300, David Bremner brem...@unb.ca wrote: 1) just delete the output file option from notmuch-dump, and use shell redirection. So far I don't see a non-contrived example when writing an

Re: output file argument to notmuch dump.

2011-10-10 Thread Tomi Ollila
On Fri 07 Oct 2011 20:22, Jameson Graef Rollins jroll...@finestructure.net writes: On Fri, 07 Oct 2011 14:15:39 +0300, Tomi Ollila tomi.oll...@iki.fi wrote: The option 2, i.e. optional --write (or -o|--output) should be available; someone may run notmuch without using environment

Re: [python] set rpath in setup.cfg

2011-10-13 Thread Tomi Ollila
On Thu 13 Oct 2011 09:34, Jameson Graef Rollins jroll...@finestructure.net writes: On Thu, 13 Oct 2011 08:12:03 +0200, dtk d...@gmx.de wrote: in my experience, it tends to cause awkward side effects that are hard to debug, the main problem being that it overrides all default paths and is

Re: [PATCH] Separate Emacs miscellaneous files directory from Emacs code directory.

2011-10-25 Thread Tomi Ollila
On Tue 25 Oct 2011 10:12, Thomas Jost schno...@schnouki.net writes: On Mon, 24 Oct 2011 22:13:11 -0300, David Bremner da...@tethera.net wrote: On Mon, 24 Oct 2011 20:34:58 +0200, Amadeusz Żołnowski aide...@aidecoe.name wrote: --emacsetcdir was added, but it's set default to the same value

Re: [PATCH] Separate Emacs miscellaneous files directory from Emacs code directory.

2011-10-25 Thread Tomi Ollila
On Tue 25 Oct 2011 11:11, Amadeusz Żołnowski aide...@aidecoe.name writes: Excerpts from Thomas Jost's message of 2011-10-25 09:12:44 +0200: However there is something annoying in the commit: +# The directory to which emacs lisp files should be installed +emacsetcdir=${EMACSETCDIR}

Re: [PATCH] Separate Emacs miscellaneous files directory from Emacs code directory.

2011-10-25 Thread Tomi Ollila
On Tue 25 Oct 2011 11:31, Amadeusz Żołnowski aide...@aidecoe.name writes: Excerpts from Tomi Ollila's message of 2011-10-25 10:17:20 +0200: On Tue 25 Oct 2011 11:11, Amadeusz Żołnowski aide...@aidecoe.name writes: Excerpts from Thomas Jost's message of 2011-10-25 09:12:44 +0200: However

Re: Emacs: notmuch-show-mode failing to actually update tags

2011-10-26 Thread Tomi Ollila
On Wed 26 Oct 2011 10:00, Erlend Simonsen m...@fudgie.org writes: On Tue, 25 Oct 2011 10:32:41 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: On Tue, 25 Oct 2011 15:25:09 +0200, Erlend Simonsen m...@fudgie.org wrote: I've been toying around with notmuch the last few days, and

remote-notmuch.sh

2011-10-26 Thread Tomi Ollila
Hi The remote-notmuch.sh script on page http://notmuchmail.org/remoteusage/ starts to show it's age. As the notmuch command line interface has evolved (and emacs ui followed) it is not working in many cases anymore. I took the script and modified it to work in my cases so far. If you have

Re: remote-notmuch.sh

2011-10-27 Thread Tomi Ollila
On Wed 26 Oct 2011 20:48, Jani Nikula j...@nikula.org writes: On Wed, 26 Oct 2011 13:04:55 +0300, Tomi Ollila tomi.oll...@iki.fi wrote: The remote-notmuch.sh script on page http://notmuchmail.org/remoteusage/ starts to show it's age. As the notmuch command line interface has evolved

Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with id:.

2011-10-27 Thread Tomi Ollila
On Thu 27 Oct 2011 05:52, Jameson Graef Rollins jroll...@finestructure.net writes: On Tue, 11 Oct 2011 01:46:43 +0200, Thomas Schwinge tho...@schwinge.name wrote: On Sun, 9 Oct 2011 15:35:48 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: (defun notmuch-show-get-message-id

Re: Emacs: notmuch-show-mode failing to actually update tags

2011-10-27 Thread Tomi Ollila
On Wed 26 Oct 2011 12:19, Erlend Simonsen m...@fudgie.org writes: On Wed, 26 Oct 2011 11:17:15 +0300, Tomi Ollila tomi.oll...@iki.fi wrote: Try these from command line: notmuch search id:messageid ~ $ notmuch search id:yf6lis8np4k@taco2.nixu.fi thread:00030b25 26 mins. ago [1

Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with id:.

2011-10-28 Thread Tomi Ollila
On Fri 28 Oct 2011 14:06, Daniel Schoepe dan...@schoepe.org writes: On Wed, 26 Oct 2011 19:52:59 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: In point of fact, do we need these quotes around message IDs at all? Can message IDs have characters that would need to be escaped

[PATCH] remove GCC visibility pragmas

2011-10-31 Thread Tomi Ollila
libnotmuch.so.* linking fail on some environments. According to David Bremner on irc: We jump through hoops with the linker script (notmuch.sym) so the pragmas are not needed. And they are a little bizarre in a library anyway... --- util/xutil.h |4 1 files changed, 0 insertions(+), 4

Re: [PATCH] remove GCC visibility pragmas

2011-10-31 Thread Tomi Ollila
On Mon 31 Oct 2011 14:07, David Bremner da...@tethera.net writes: On Mon, 31 Oct 2011 14:01:28 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: libnotmuch.so.* linking fail on some environments. According to David Bremner on irc: We jump through hoops with the linker script (notmuch.sym) so

Re: [PATCH] contrib/nmbug: new script for sharing tags with a given prefix.

2011-11-07 Thread Tomi Ollila
On Sun, 6 Nov 2011 20:59:46 -0400, David Bremner da...@tethera.net wrote: From: David Bremner brem...@debian.org The main idea is consider the notmuch database as analogous to the work-tree. A bare git repo is maintained in the users home directory, with a tree of the form

[PATCH] test: make all tests terminable with Ctrl-c

2011-11-08 Thread Tomi Ollila
Some tests don't break when HUP signal is sent tho those (by pressing ctrl-c on the terminal). Therefore, the top-level test script catches the HUP and sends TERM signal to the started test script. --- test/notmuch-test |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git

[PATCH] test: use dtach(1) instead of screen(1) in emacs tests.

2011-11-10 Thread Tomi Ollila
dtach is lighter than screen and is not setuid/setgid program so TMPDIR does not get reset by dynamic loader when executed. --- test/test-lib.sh |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index c81c709..af723ad 100755 ---

[PATCH] smtp-dummy: clear sockaddr_in structures before use.

2011-11-10 Thread Tomi Ollila
Any junk bytes in sockaddr_in structures before passing those to bind() or accept() functions may cause problems. --- test/smtp-dummy.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/test/smtp-dummy.c b/test/smtp-dummy.c index 9da8202..38d1d62 100644 ---

[PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-10 Thread Tomi Ollila
If mail sending from emacs fails before it has chance to connect to the smtp-dummy mail server, the opportunistic QUIT message sending makes smtp-dummy to exit. --- test/test-lib.sh |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh

[PATCH] exec emacs at the end of run_emacs script

2011-11-10 Thread Tomi Ollila
In the last line of run_emacs, exec the emacs process. With one fork less the process list is (also) neater. --- test/test-lib.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 57cb088..3ad325a 100755 --- a/test/test-lib.sh +++

Re: [PATCH] test: use dtach(1) instead of screen(1) in emacs tests.

2011-11-11 Thread Tomi Ollila
On Fri, 11 Nov 2011 12:41:11 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Tomi. On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: From: Tomi Ollila tomi.oll...@iki.fi dtach is lighter than screen and is not setuid/setgid

[PATCH] test: use dtach(1) instead of screen(1) in emacs tests

2011-11-11 Thread Tomi Ollila
dtach is simpler than screen and is not setuid/setgid program so TMPDIR does not get cleared by dynamic loader when executed. --- Updated version after discussion with DmitryKurochkin and amdragon on IRC. Thank you. test/test-lib.sh | 25 + 1 files changed, 13

[PATCH] test: use dtach(1) instead of screen(1) in emacs tests

2011-11-11 Thread Tomi Ollila
dtach is simpler than screen and is not setuid/setgid program so TMPDIR does not get cleared by dynamic loader when executed. --- Updated version after discussion with DmitryKurochkin and amdragon on IRC. Thank you. test/test-lib.sh | 25 + 1 files changed, 13

[PATCH] smtp-dummy: clear sockaddr_in structure before use in bind()

2011-11-12 Thread Tomi Ollila
Any junk bytes in sockaddr_in structure before passing that to bind() system call may cause problems. --- Thanks Austin. Consistent style matters... And dropped the peer_addr setting after reading accept(2) namual page. test/smtp-dummy.c |1 + 1 files changed, 1 insertions(+), 0

Re: [PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-12 Thread Tomi Ollila
and timing might cause smtp dummy to be killed before it has read all content... But... i recall bash has a way to do tcp stuff .../dev/tcp/host/port is mentioned in manual page. I'll investigate this later (or, anyone of you, provide a patch :) Tomi Quoth Tomi Ollila on Nov 11 at 1:38 am

Re: [PATCH] test: do not hide test_emacs errors

2011-11-12 Thread Tomi Ollila
On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner da...@tethera.net wrote: On Fri, 1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Do not redirect test_emacs stderr to /dev/null. Test_emacs uses emacsclient(1) now and it does not print unwanted messages (like

Re: [PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-12 Thread Tomi Ollila
On Sat, 12 Nov 2011 10:41:28 -0500, Austin Clements amdra...@mit.edu wrote: Actually, since sending mail is synchronous, there shouldn't be any issues with buffering or timing. If Emacs successfully sends the message, it will wait for the OK response (`smtpmail-via-smtp'), which should

Re: [PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-13 Thread Tomi Ollila
On Sun, 13 Nov 2011 11:01:24 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Sat, 12 Nov 2011 23:07:38 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: SO, in our cases there are 2 options: 1) add line { echo QUIT /dev/tcp/127.0.0.1/25025; } 2/dev/null before

[RFC PATCH] nmbug help w/o perldoc

2011-11-16 Thread Tomi Ollila
--- notmuch help runs pod2usage with -verbose = 2, which by default tries to run perldoc. Adding -noperldoc = 1 disables this use but there is no pre-verifying interface (or so) available. In one of my systems there was no 'perldoc' script, which basically contains: use Pod::PerlDoc; exit(

Re: Winter is coming [upcoming release 0.10]

2011-11-16 Thread Tomi Ollila
On Tue, 15 Nov 2011 23:11:49 -0400, David Bremner da...@tethera.net wrote: On Sun, 13 Nov 2011 10:19:14 -0400, David Bremner da...@tethera.net wrote: According to our sortof-schedule, we should release 0.10 soonish. I'd like to freeze for a few days first, so that means we have time for

Re: [PATCH v2] tag: Automatically limit to messages whose tags will actually change.

2011-11-16 Thread Tomi Ollila
On Wed, 9 Nov 2011 08:44:35 -0500, Austin Clements amdra...@mit.edu wrote: This optimizes the user's tagging query to exclude messages that won't be affected by the tagging operation, saving computation and IO for redundant tagging operations. For example, notmuch tag +notmuch

Re: [RFC PATCH] nmbug help w/o perldoc

2011-11-16 Thread Tomi Ollila
On Wed, 16 Nov 2011 09:44:03 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Tue, 15 Nov 2011 18:11:16 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: --- Hey, Tomi. Your '---' separator is in the wrong place! You wrote this nice long log message, but it won't

Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace

2011-11-16 Thread Tomi Ollila
On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet pie...@praet.org wrote: No further explanation needed. --- NEWS | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) The 'No further explanation needed.' should be *BELOW* the waistline (---) ;); now it goes to the commit

[PATCH v2] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-16 Thread Tomi Ollila
If mail sending from emacs fails before it has chance to connect to the smtp-dummy mail server, the opportunistic QUIT message sending makes smtp-dummy to exit. --- Version 2 of the same feature. Now uses BASH's /dev/tcp/host/port feature instead of external 'nc' command. test/test-lib.sh |

Re: [PATCH 0/9] test: (hopefully) better test prerequisites

2011-11-17 Thread Tomi Ollila
On Thu, 17 Nov 2011 01:14:07 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: However, when I tried to test the tests with the patch applied I ran into one problem. If I try to run the test suite with dtach uninstalled, it looks like I'm experiencing a hang on

Re: [PATCH 0/9] test: (hopefully) better test prerequisites

2011-11-17 Thread Tomi Ollila
On Thu, 17 Nov 2011 17:22:41 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Tomi. On Thu, 17 Nov 2011 14:20:19 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: I.e. dynamically, at run-time, re-create test_emacs function... Could you please add some human-friendly

Re: [PATCH 0/9] test: (hopefully) better test prerequisites

2011-11-18 Thread Tomi Ollila
On Thu, 17 Nov 2011 19:17:16 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: If we follow this pattern than all code like: f() { if (!done_once) do_once do_more } Should be rewritten using dynamic functions. I do not think I agree with this :)

Re: [PATCH] dump: Don't sort.

2011-11-21 Thread Tomi Ollila
On Mon, 14 Nov 2011 21:10:44 -0400, David Bremner da...@tethera.net wrote: On Sat, 29 Oct 2011 12:37:37 +0200, Thomas Schwinge tho...@schwinge.name wrote: From: Thomas Schwinge tho...@schwinge.name This improves usage experience considerably in the given scenario. I'm not sure if I

[PATCH] debian/control: require dtach version = 0.8 in Build-Depends

2011-11-22 Thread Tomi Ollila
Since version 0.8 of dtach -n does no longer require controlling tty to be present when executed. Currently controlling tty is not always (if ever) present when tests are executed. --- debian/control |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/debian/control

[PATCH] make release: verify-version-*: change comparison logic

2011-11-22 Thread Tomi Ollila
verfy-version-debian, verify-version-python and verify-version-components checked noneqality of the comparison strings and if got positive answer then made that goal fail. But in case of the test ([ ]) execution failed it never got to the 'then' part of the line (and the 'if [ ... ] then ... fi '

[PATCH] make release: added goal verify-version-manpage

2011-11-22 Thread Tomi Ollila
Check that the version mentioned in notmuch manual page is consistent with the version file. --- Makefile.local | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index b6e216a..02afdd0 100644 --- a/Makefile.local +++ b/Makefile.local

Re: [PATCH] CLI: update call to notmuch_help_command for new calling conventions.

2011-11-24 Thread Tomi Ollila
On Thu, 24 Nov 2011 16:02:41 -0400, David Bremner da...@tethera.net wrote: From: David Bremner brem...@debian.org When I changed the calling convention to pass in all but the zero-th argument to subcommands, I missed this one call, resulting in a segmentation fault. LGTM, is analogous to

Re: [PATCH 1/3] test: add functions to count how much times notmuch was called

2011-11-29 Thread Tomi Ollila
On Mon, 28 Nov 2011 07:28:13 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: [...] + +These allow to count how many times notmuch binary is called. +notmuch_counter_reset() function generates a script that counts +how many times it is called and resets the counter to

Re: [PATCH 4/9] test: add support for external executable dependencies

2011-11-29 Thread Tomi Ollila
On Thu, 17 Nov 2011 05:56:21 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: There is existing support for general prerequisites in the test suite. But it is not very convenient to use: every test case has to keep track for it's dependencies and they have to be explicitly listed.

Re: [PATCH 1/3] test: add functions to count how much times notmuch was called

2011-11-29 Thread Tomi Ollila
Hi Dmitry. On Tue, 29 Nov 2011 01:26:39 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Tomi. On Mon, 28 Nov 2011 22:42:50 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Mon, 28 Nov 2011 07:28:13 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote

Re: [PATCH 4/4] test: fix error messages for missing binary dependencies

2011-11-29 Thread Tomi Ollila
\ || test_subtest_missing_external_prereqs_=\\$test_subtest_missing_external_prereqs_ $name\ false } -- 1.7.7.3 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch -- Tomi Ollila !! tomi.oll...@nixu.fi !! +358 400 888

Re: [PATCH] emacs: Use notmuch-command variable in process-lines.

2011-11-30 Thread Tomi Ollila
On Tue, 29 Nov 2011 10:58:31 -0700, Chris Gray chrismg...@gmail.com wrote: The process-lines function calls the notmuch binary. The location of the binary may have been customized by the user, so it is better to use the customized location rather than allowing the process-lines function to

Re: [PATCH 1/3] test: add functions to count how much times notmuch was called

2011-11-30 Thread Tomi Ollila
On Wed, 30 Nov 2011 01:03:27 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Tomi. On Tue, 29 Nov 2011 14:58:00 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: Hi Dmitry. [ ... ] The (posix) shell command language defines 'Arithmetic Expansion' in http

Re: [PATCH v4 1/3] test: add functions to count how much times notmuch was called

2011-11-30 Thread Tomi Ollila
On Wed, 30 Nov 2011 01:19:52 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: The patch adds two auxiliary functions and a variable: notmuch_counter_reset $notmuch_counter_command notmuch_counter_value They allow to count how many times notmuch binary is called.

ANNOUNCE: nottoomuch-addresses.pl

2011-12-01 Thread Tomi Ollila
In addition to http://notmuchmail.org/emacstips/#index11h2 and Jani's 'goobook' in id:87zkfuh3i0@nikula.org you can now also use http://www.iki.fi/too/nottoomuch/nottoomuch-addresses.pl for your address completion needs when composing mail/reply. This program is 1) easy to install and 2)

Re: ANNOUNCE: nottoomuch-addresses.pl

2011-12-01 Thread Tomi Ollila
', since 1322159560. Added 0 addresses in 1 seconds. Total number of addresses: 993. bart@bit:~/.config/nottoomuch$ On Thu, 01 Dec 2011 17:36:24 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: ___ notmuch mailing list notmuch@notmuchmail.org http

[PATCH] make release: remove LATEST-$(PACKAGE)-*

2011-12-05 Thread Tomi Ollila
-version.tar.gz on releases web page On Sat, 03 Dec 2011 10:32:43 -0800, David Bremner da...@tethera.net wrote: On Thu, 24 Nov 2011 22:41:01 +0200, Tomi Ollila tomi.oll...@nixu.com wrote: The notmuchmail/releases page used to have LATEST-notmuch-version to link to the latest notmuch source

Re: ANNOUNCE: nottoomuch-addresses.pl

2011-12-05 Thread Tomi Ollila
Hi Thanks to Bart's findings those things are now fixed in version 1.1 of nottoomuch-addresses.pl Get it: (wget) http://www.iki.fi/too/nottoomuch/nottoomuch-addresses.pl Sha1 digest is now 4ed74ef9eaabb73804e55caa2c29682e643d2b78 Installation instructions some other info now available at:

Re: ANNOUNCE: nottoomuch-addresses.pl

2011-12-05 Thread Tomi Ollila
:51:16 +0200, Tomi Ollila tomi.oll...@nixu.com wrote: Hi Thanks to Bart's findings those things are now fixed in version 1.1 of nottoomuch-addresses.pl Get it: (wget) http://www.iki.fi/too/nottoomuch/nottoomuch-addresses.pl Sha1 digest is now

Re: ANNOUNCE: nottoomuch-addresses.pl

2011-12-06 Thread Tomi Ollila
On Tue, 06 Dec 2011 08:45:49 +1100, Bart Bunting b...@ursys.com.au wrote: Hi, I agree with Jamie on this one. The case sensitivity appears to get in the way of searching. I also think that enabling the regular expressionsearching is a good idea. All in all though this is great. I

Re: RFC: don't ask users to do 'sudo make install'

2011-12-07 Thread Tomi Ollila
On Wed, 07 Dec 2011 13:25:45 +0100, Justus Winter 4win...@informatik.uni-hamburg.de wrote: Hey everyone, I just noticed that running configure says: All required packages were found. You may now run the following commands to compile and install notmuch: make sudo

[PATCH] Release memory allocated by internet_address_list_parse_string()

2011-12-07 Thread Tomi Ollila
g_object_unref() releases the memory of the InternetAddressList object returned by internet_address_list_parse_string() -- when last (only) reference is released, internet_address_list_finalize() will do cleanup. --- When reviewing, see also gmime-2.4.25/gmime/internet-address.c (or older) I

Re: [PATCH] Release memory allocated by internet_address_list_parse_string()

2011-12-07 Thread Tomi Ollila
On Wed, 07 Dec 2011 22:13:19 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: g_object_unref() releases the memory of the InternetAddressList object returned by internet_address_list_parse_string() -- when last (only) reference is released, internet_address_list_finalize() will do cleanup

Re: [PATCH v3 0/2] notmuch hooks

2011-12-08 Thread Tomi Ollila
On Wed, 07 Dec 2011 14:13:13 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Wed, 07 Dec 2011 21:42:33 +0200, Jani Nikula j...@nikula.org wrote: I wonder, though, whether the samples should be created only when creating the database, or whenever the hooks directory does not

Re: [PATCH 0/3] Configuration file option to exclude files/directories

2011-12-08 Thread Tomi Ollila
On Wed, 07 Dec 2011 19:51:32 -0400, David Bremner da...@tethera.net wrote: On Wed, 14 Sep 2011 00:32:01 +0300, tomi.oll...@iki.fi wrote: This patch set adds a configuration option 'database.exclude'; a list of files/directories to be excluded when doing 'notmuch new' operation. Hi All;

[Patch 1/2] separate handling when addresses == NULL

2011-12-09 Thread Tomi Ollila
When addresses is NULL, (future) addresses object cleanup is not needed. --- notmuch-show.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 603992a..c27ef6a 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -239,7 +239,11 @@

[PATCH 2/2] Release memory allocated by internet_address_list_parse_string()

2011-12-09 Thread Tomi Ollila
g_object_unref() releases the memory of the InternetAddressList object returned by internet_address_list_parse_string() -- when last (only) reference is released, internet_address_list_finalize() will do cleanup. --- When reviewing, see also gmime-2.4.25/gmime/internet-address.c (or older) I

[PATCH v3] Release memory allocated by internet_address_list_parse_string()

2011-12-10 Thread Tomi Ollila
g_object_unref() releases the memory of the InternetAddressList object returned by internet_address_list_parse_string() -- when last (only) reference is released, internet_address_list_finalize() will do cleanup. --- hmm, have to agree amdragon's suggested alternative is more robust (in

Re: [PATCH] emacs: support notmuch new as a notmuch-poll-script

2011-12-12 Thread Tomi Ollila
On Sun, 11 Dec 2011 19:31:03 -0500, Austin Clements amdra...@mit.edu wrote: So here's another idea, prefaced with a rant. It's bothered me for a long time that notmuch-emacs didn't just know by default how to check for new mail. What MUA doesn't know how to check for new mail? Why does a

Re: [PATCH] util/hex-escape.[ch]: encoding/decoding strings into restricted character set

2011-12-12 Thread Tomi Ollila
On Sun, 11 Dec 2011 12:19:44 -0400, David Bremner da...@tethera.net wrote: From: David Bremner brem...@debian.org The character set is chosen to be suitable for pathnames, and the same as that used by contrib/nmbug. The new encoded/decoded strings are allocated using talloc. --- This isn't

Re: [PATCH] emacs: support notmuch new as a notmuch-poll-script

2011-12-12 Thread Tomi Ollila
On Mon, 12 Dec 2011 14:21:53 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Mon, 12 Dec 2011 12:15:44 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Sun, 11 Dec 2011 19:31:03 -0500, Austin Clements amdra...@mit.edu wrote: So here's another idea, prefaced with a rant

ANNOUNCE: nottoomuch-addresses.pl version 1.3

2011-12-12 Thread Tomi Ollila
On Wed, 07 Dec 2011 00:03:19 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Tue, 06 Dec 2011 08:45:49 +1100, Bart Bunting b...@ursys.com.au wrote: Hi, ... The only other idea I have, which is only half formed, is that it would be nice to prioritize emails that are more important than

[PATCH 2/2] test/test-lib.sh: launch smtp-dummy with --background and finally kill(1) it.

2011-12-12 Thread Tomi Ollila
Take the new --background option of smtp-dummy to use so that it is known there is smtpd listener ready when it is needed. As the smtp-dummy instance is no longer child process of the script sending SIGKILL to it is the only way to make sure the instance exits when required. --- test/test-lib.sh

[PATCH 2/2] test/test-lib.sh: launch smtp-dummy with --background and finally kill(1) it.

2011-12-13 Thread Tomi Ollila
Take the new --background option of smtp-dummy to use so that it is known there is smtpd listener ready when it is needed. As the smtp-dummy instance is no longer child process of the script sending SIGKILL to it is the only way to make sure the instance exits when required. --- Resent after

[PATCH 1/2] test/smtp-dummy: add --background option for going background after listen(2)

2011-12-13 Thread Tomi Ollila
To avoid the possibility that smtp-dummy doesn't have chance to bind its listening socket until something tries to send message to it this option makes caller wait until socket is already listening for connections. In case this --background option is used, the pid of running smtp-dummy is printed

[PATCH] notmuch: unref charset_filter to fix one memory leak

2011-12-13 Thread Tomi Ollila
In my use case g_object_unref(charset_filter) reduces memory consumption over 90% when 'notmuch show --format=text *' is executed (~11000 messages, RES ~330M - ~25M). --- notmuch-show.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c

[PATCH] notmuch: unref charset_filter (once more) to fix one memory leak

2011-12-13 Thread tomi . ollila
From: Tomi Ollila tomi.oll...@iki.fi In my test case added g_object_unref(charset_filter) reduces memory consumption over 90% when 'notmuch show --format=text *' is executed (~11000 messages, RES ~330M - ~25M). --- Thanks Dmitry. I did not realize unref unreferences, does not deallocate memory

Re: [PATCH] test: optionally print subtest number

2011-12-13 Thread Tomi Ollila
On Wed, 14 Dec 2011 00:15:43 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Tue, 13 Dec 2011 15:56:47 -0400, David Bremner da...@tethera.net wrote: From: David Bremner brem...@debian.org The idea is that $test_count could be used in tests to label intermediate files. The

Re: [PATCH] test: optionally print subtest number

2011-12-13 Thread Tomi Ollila
On Wed, 14 Dec 2011 00:58:35 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Tue, 13 Dec 2011 22:55:18 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Wed, 14 Dec 2011 00:15:43 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Looks good to me. Except for tabs

Re: [PATCH 3/7] py3k: All strings are unicode strings in py3k

2011-12-14 Thread Tomi Ollila
On Wed, 14 Dec 2011 11:58:21 +0100, Justus Winter 4win...@informatik.uni-hamburg.de wrote: --- bindings/python/notmuch/globals.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bindings/python/notmuch/globals.py b/bindings/python/notmuch/globals.py index

Re: [PATCH 6/7] py3k: Add and use a mixin class that implements __str__

2011-12-14 Thread Tomi Ollila
On Wed, 14 Dec 2011 11:58:24 +0100, Justus Winter 4win...@informatik.uni-hamburg.de wrote: --- [ ... snip ... ] -class Filenames(object): +class Filenames(Python3StringMixIn): Represents a list of filenames as returned by notmuch This object contains the Filenames iterator.

ANNOUNCE: nottoomuch-addresses.pl version 1.4

2011-12-14 Thread Tomi Ollila
notmuch-addresses.sh -- email address substring matcher -- completion helper version 1.4 is available. This version uses 'notmuch search --sort=newest-first --output=files ...' (instead of notmuch show ...) to retrieve message information from notmuch ... and now scans headers from mail files

Re: [PATCH] Fix build with binutils-2.22

2011-12-15 Thread Tomi Ollila
On Thu, 15 Dec 2011 20:41:58 +0100, Thomas Jost schno...@schnouki.net wrote: binutils-2.22 changes the behaviour of ld by defaulting to --no-copy-dt-needed-entries, which means that required objects/libs are not indirectly linked through intermediate objects/libs anymore. As a consequence,

  1   2   3   4   5   6   7   8   9   10   >