Re: Custom notmuch-show for html?

2017-07-24 Thread William Casarin
Tomi Ollila writes: > Writing one's own renderer function and pointing mm-text-html-renderer > to that (or something...) This is what I was looking for, thanks. > If you try to work something on this (or anything), please report your > progress :D Will do! Cheers, William

Custom notmuch-show for html?

2017-07-23 Thread William Casarin
Hey there, I would like to never use emacs' slow html renderer when viewing html-only email. What I want to do is pipe the html through: pandoc -f html -t plain and then show the output of that. Right now I can do this with `. |` but I can only do this after I open the email, which is not

Re: Custom notmuch-show for html?

2017-07-26 Thread William Casarin
Tomi Ollila writes: > So, you set mm-text-html-renderer as 'w3m > > ? Yeah, but I had to install w3m and install the w3m package before it worked. The w3m-standalone one worked but was a bit slower and didn't seem to work as well. Cheers, William

Re: Custom notmuch-show for html?

2017-07-25 Thread William Casarin
Tomi Ollila writes: > If you try to work something on this (or anything), please report your > progress :D I didn't really get far after I discovered how awesome emacs-w3m was. pandoc plaintext output is pretty bad in comparison. Thanks again!

RFC on default notmuch-show mime part buttons

2017-05-13 Thread William Casarin
I recently had to do this in my notmuch config to remove a lot of button noise in the notmuch-show buffer: (defun jb55/notmuch-show-insert-header-p (part hide) ;; Show all part buttons except for text/plain and multipart (let ((mime-type (notmuch-show-mime-type part))) (not

Re: Washing GitHub emails to include inline patch?

2017-09-22 Thread William Casarin
Kyle Meyer writes: > I have a command in my Emacs configuration that I think gets close to > what you want. This is great! Now if there was only a way to make it work for private repositories... hmm... -- https://jb55.com ___

Washing GitHub emails to include inline patch?

2017-09-21 Thread William Casarin
Hey team, Most of the patches I review these days comes in as GitHub emails that look like this: --- Begin Message --- You can view, comment on, or merge this pull request online at: MIME-Version: 1.0 Content-Type: text/plain https://github.com/monstercat/iris/pull/52 -- Commit Summary --

Re: Washing GitHub emails to include inline patch?

2017-10-10 Thread William Casarin
Hey Kyle, Kyle Meyer writes: >> I wonder if it would be be possible to wash this email by downloading >> the patch and present it inline like git-send-email. This would allow me >> to review patches without having to click around the GitHub interface. >> Has anyone done this? >

[bug] [emacs] notmuch-show: names not shown on some mailing lists

2017-10-10 Thread William Casarin
Hey there, Here's something I've noticed in some mailing list threads in notmuch-show: https://jb55.com/s/81d7c740ef60984d.png It doesn't look like it is showing the correct name. Looking at the raw message, the From line looks like this: From: Some Person via Some-mailinglist

Re: [bug] [emacs] notmuch-show: names not shown on some mailing lists

2017-10-14 Thread William Casarin
Jani Nikula writes: > The information comes from the cli. Can you reproduce this using some > notmuch show --format=sexp --body=false query, perhaps on just one of > the messages? I get this: :From "Person via Mailing list\011" --

Re: [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments

2017-10-14 Thread William Casarin
Hey Jani, Patches look good so far, concept ack for sure. Jani Nikula writes: > For example, you can use --no-exclude instead of --exclude=false in > notmuch show. If we had keyword flag arguments with some flags > defaulting to on, say --include=tags in notmuch

Re: [bug] [emacs] notmuch-show: names not shown on some mailing lists

2017-10-14 Thread William Casarin
William Casarin <j...@jb55.com> writes: > Jani Nikula <j...@nikula.org> writes: > >> The information comes from the cli. Can you reproduce this using some >> notmuch show --format=sexp --body=false query, perhaps on just one of >> the messages? > > I get

Re: [bug] [emacs] notmuch-show: names not shown on some mailing lists

2017-10-14 Thread William Casarin
Nevermind, the issue seems to go away on master Sorry for the noise... ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments

2017-10-14 Thread William Casarin
Tested ACK 1-3 + id:20171014201836.4486-1-j...@nikula.org ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments

2017-10-14 Thread William Casarin
Jani Nikula writes: > *blush* I screwed those enums up. Here's a patch that takes care of both > issues id:20171014201836.4486-1-j...@nikula.org. It's independent of > this series. Works, thanks. -- https://jb55.com ___ notmuch

GitHub + notmuch scripts/hacks

2017-10-13 Thread William Casarin
Hey there, I've started collecting[1] a bunch of notmuch+GitHub hacks from some of the discussions @ id:87d16jtsdj@kyleam.com I've added the ability to comment on/approve/reject pull requests from a GitHub pull-request email[2]. It can also open a magit-log view of the PR from an email, as

Re: Washing GitHub emails to include inline patch?

2017-10-13 Thread William Casarin
Kyle Meyer writes: > Looking at what I wrote again, I'd change DONT-FETCH to FORCE-FETCH and > then do something like > > (when (or force-fetch > (not (magit-ref-exists-p local-ref))) > (magit-call-git "fetch" "origin")) > > where local-ref is bound to

Colorized git-format-patches in notmuch-show?

2017-08-29 Thread William Casarin
I'm not sure if this is an option somewhere, but is there a way to colorize git-format-patch emails in the notmuch-show buffer? I noticed it works fine if it's an attachment, but not if it's a git-submitted patch. Thanks, William ___ notmuch mailing

[PATCH] emacs: replace oldest-first with sort-order

2017-09-09 Thread William Casarin
This generalizes notmuch-search-oldest-first to notmuch-search-sort-order. notmuch-search-sort-order can now be one of: * oldest-first * newest-first * subject-ascending * subject-descending * from-ascending * from-descending Order toggling now simply inverts the corresponding

Re: [PATCH v2] emacs: replace oldest-first with sort-order

2017-09-09 Thread William Casarin
Here's the before and after with from-ascending sorting on my rss tag: before: https://jb55.com/s/e51db7073ccfc36d.png after: https://jb55.com/s/6a01cd3a0227ddfa.png Last thing I need to add is a completing-read menu for selecting the sort-order, since you can only set it in saved searches or

Re: [PATCH 1/3] sorting: add the ability to sort by from and subject

2017-09-07 Thread William Casarin
David Bremner writes: > It seems worth mentioning that it's possible to preprocess values into > keys (see Xapian::Enquire::set_sort_by_key). So things like Re: > etc... could be stripped. Hmm looks like I need to create a KeyMaker class which appears to be a glorified

[PATCH v2] emacs: replace oldest-first with sort-order

2017-09-09 Thread William Casarin
This generalizes notmuch-search-oldest-first to notmuch-search-sort-order. notmuch-search-sort-order can now be one of: * oldest-first * newest-first * subject-ascending * subject-descending * from-ascending * from-descending Order toggling now simply inverts the corresponding

[PATCH 0/6] Sort by from and subject

2017-09-25 Thread William Casarin
your subscribed github repos is now easier than ever! before: https://jb55.com/s/7889d50bc848b089.png after: https://jb55.com/s/c8b5055939d0482f.png * from sorting: rss feeds https://jb55.com/s/68a5aa6ecdebbbfe.png Cheers, William [1] id:20170904160040.23642-1-j...@jb55.com William Casarin

[PATCH 4/6] emacs: replace oldest-first with sort-order

2017-09-25 Thread William Casarin
This generalizes notmuch-search-oldest-first to notmuch-search-sort-order. notmuch-search-sort-order can now be one of: * oldest-first * newest-first * subject-ascending * subject-descending * from-ascending * from-descending Order toggling now simply inverts the corresponding

[PATCH 6/6] emacs: add notmuch-search-change-order

2017-09-25 Thread William Casarin
notmuch-search-change-order pops up a completing-read minibuffer completion window for choosing sort-orders. --- emacs/notmuch.el | 14 ++ 1 file changed, 14 insertions(+) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 334458b7..93b4e582 100644 --- a/emacs/notmuch.el +++

[PATCH 5/6] emacs: notmuch-search-orders

2017-09-25 Thread William Casarin
Create a notmuch-sort-orders alist to be shared between notmuch-search-sort-orders and notmuch-change-search-order --- emacs/notmuch-lib.el | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index ee7b67d3..16725863

[PATCH 3/6] sorting: update man page

2017-09-25 Thread William Casarin
--- doc/man1/notmuch-address.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/man1/notmuch-address.rst b/doc/man1/notmuch-address.rst index cc31cc5a..38ae9a25 100644 --- a/doc/man1/notmuch-address.rst +++ b/doc/man1/notmuch-address.rst @@ -77,7 +77,11 @@ Supported

[PATCH 1/6] sorting: add the ability to sort by from and subject

2017-09-25 Thread William Casarin
* add {from,subject}-{ascending,descending} sort options --- lib/notmuch.h| 16 lib/query.cc | 12 notmuch-search.c | 4 3 files changed, 32 insertions(+) diff --git a/lib/notmuch.h b/lib/notmuch.h index f26565f3..071bfe4d 100644 --- a/lib/notmuch.h

[PATCH 2/6] sorting: update ruby bindings for from and subject

2017-09-25 Thread William Casarin
--- bindings/ruby/init.c | 24 1 file changed, 24 insertions(+) diff --git a/bindings/ruby/init.c b/bindings/ruby/init.c index 5556b43e..ace8f666 100644 --- a/bindings/ruby/init.c +++ b/bindings/ruby/init.c @@ -104,6 +104,30 @@ Init_notmuch (void) */

Re: [PATCH 0/6] Sort by from and subject

2017-09-30 Thread William Casarin
Hey Jani, Jani Nikula writes: > I think there are two considerations here: > > First, is this something we want to have? Is this generally useful? Sorting by from and subject are in most mail clients (mutt, gnus, outlook...) > There's still the issue of From: and Subject:

Re: [PATCH v2 13/15] cli: add support for --no- prefixed boolean and keyword flag arguments

2017-10-01 Thread William Casarin
Jani Nikula writes: > @@ -171,11 +186,22 @@ parse_option (int argc, char **argv, const > notmuch_opt_desc_t *options, int opt_ > if (! try->name) > continue; > > - if (strncmp (arg, try->name, strlen (try->name)) != 0) > + char next; > + const char

notmuch-search: sort by subject or author?

2017-09-04 Thread William Casarin
Hey there, Is there a way to sort by subject or author in emacs/notmuch-search? I find myself wanting to do this a lot. My particular use case is rss feeds, where I have many different feeds in my rss tag that I would like to group together. If not, I am interested in adding this feature.

[PATCH 2/3] sorting: update ruby bindings for from and subject

2017-09-04 Thread William Casarin
--- bindings/ruby/init.c | 24 1 file changed, 24 insertions(+) diff --git a/bindings/ruby/init.c b/bindings/ruby/init.c index 5556b43e..ace8f666 100644 --- a/bindings/ruby/init.c +++ b/bindings/ruby/init.c @@ -104,6 +104,30 @@ Init_notmuch (void) */

[PATCH 1/3] sorting: add the ability to sort by from and subject

2017-09-04 Thread William Casarin
* add {from,subject}-{ascending,descending} sort options --- I'm not sure if we want to eventually refactor ascending and descending into a separate option, but I decided to keep it this way for now. lib/notmuch.h| 16 lib/query.cc | 12 notmuch-search.c |

Re: notmuch-search: sort by subject or author?

2017-09-04 Thread William Casarin
David Bremner writes: > I think it's not really possible at the moment. If you want this to work > with large searches then it probably needs to be done at the CLI level > (see [1] for work in progress adding sorting by file size). > > Luckily 'From' and 'Subject' are already

[PATCH 3/3] sorting: update man page

2017-09-04 Thread William Casarin
--- doc/man1/notmuch-address.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/man1/notmuch-address.rst b/doc/man1/notmuch-address.rst index cc31cc5a..38ae9a25 100644 --- a/doc/man1/notmuch-address.rst +++ b/doc/man1/notmuch-address.rst @@ -77,7 +77,11 @@ Supported

Re: [PATCH 1/3] sorting: add the ability to sort by from and subject

2017-09-04 Thread William Casarin
William Casarin <j...@jb55.com> writes: > Jani Nikula <j...@nikula.org> writes: > >> The implementation seems simple enough, but what's the use case, really? > > I get all of my rss feeds sent to my inbox, I wanted to be able to group > similar feeds (

Re: Washing GitHub emails to include inline patch?

2017-10-10 Thread William Casarin
Kyle Meyer writes: > Call M-x km/notmuch-visit-pr-in-magit in a notmuch-show buffer for a > GitHub PR, modifying km/notmuch-repo-from-message so that it returns > the full path to the local repository. Are you a wizard? That worked like magit. I changed

Re: Washing GitHub emails to include inline patch?

2017-10-10 Thread William Casarin
Kyle Meyer writes: > However, I personally haven't felt the need for such a command. I > pretty frequently use the command I posted earlier in this thread to > take a quick look at PRs, but, for anything aside from the simplest > changes, I want to apply the commits locally to

Re: Washing GitHub emails to include inline patch?

2017-10-12 Thread William Casarin
Kyle Meyer writes: > --8<---cut here---start->8--- > > (defun km/notmuch-github-pr-number () > "Return the PR number for this message." > (let (pr) > (with-current-notmuch-show-message > (goto-char (point-min)) > (if

Re: Proposed New sort API

2017-12-10 Thread William Casarin
David Bremner writes: > I started looking at William's sorting patches [1], but the > proliferation of sorting options bugged me a bit. I decided to sketch > out a new more flexible API. > > In the new API, there is is a sort "key", currently mapped one-to-one > to value

Re: Sorting & grouping

2018-07-23 Thread William Casarin
Leonard Lausen writes: > What do you think about adding a 'group' option that will group mails > with the same set of tags (possibly minus a list of tags to be ignored > when grouping) and apply the normal search. Hmm. I think could be simplified by sorting by a specific tag, and then by date,

Re: GitHub + notmuch scripts/hacks

2018-06-24 Thread William Casarin
William Casarin writes: > I've started collecting[1] a bunch of notmuch+GitHub hacks from some of > the discussions @ id:87d16jtsdj@kyleam.com > [..] > > [1] https://github.com/jb55/notmuch-github > [2] > https://github.com/jb55/notmuch-github/commit/fb2d80cf9ee9a5967c7

[PATCH] emacs: filter tag completions by current query

2018-10-08 Thread William Casarin
When filtering by tags in notmuch-search-filter-by-tag, only return tags related to the current query. Before, it was returning all tags. There's no reason to refine the current query with tags that don't exist in the current result set. Signed-off-by: William Casarin --- emacs/notmuch.el | 2

Re: How do you sync your mail constantly?

2018-11-03 Thread William Casarin
Vika Shleina writes: > And to maybe think of alternative solution, I ask you - what do you use > to seamlessly sync your mail? I use a script[1] that connects to my imap server. New mail comes into my sieve-filtered inbox[2] which then triggers the imap-notify[1] script on my local machine.

Re: Proposed New sort API

2018-10-20 Thread William Casarin
David Bremner writes: > William Casarin writes: > >> Another thought I had that I wanted to throw out there for >> consideration. It would be nice to be able to sort by "popular" threads, >> aka sort by the number of messages in each thread. Not sure

[PATCH RFC] index: add body: search query term

2018-10-09 Thread William Casarin
This adds the ability to search specifically on the body eg. notmuch search tag:notmuch and body:PATCH Signed-off-by: William Casarin --- Hey there, I'm looking to add the ability to search specifically on the body. I was poking around in the indexer, added these lines and reindexed

Re: [PATCH 1/2] WIP: groundwork for new sorting API

2018-10-08 Thread William Casarin
David Bremner writes: > --- a/lib/notmuch.h > +++ b/lib/notmuch.h > @@ -773,6 +773,10 @@ notmuch_query_create (notmuch_database_t *database, > * Sort values for notmuch_query_set_sort. > */ > typedef enum { > +/** > + * Value was not set > + */ > +NOTMUCH_SORT_UNSET = -1, >

Re: Proposed New sort API

2018-10-08 Thread William Casarin
David Bremner writes: > I started looking at William's sorting patches [1], but the > proliferation of sorting options bugged me a bit. I decided to sketch > out a new more flexible API. > > In the new API, there is is a sort "key", currently mapped one-to-one > to value slots, but potentially

Re: unused/total message counts in hello screen?

2018-09-30 Thread William Casarin
Jeff Templon writes: > An alternative would be if I could toggle the entire page to show just > the unread tags (so any tags for which all messages were read would > just not show up). Maybe even preferable, that last one. This can be done setting "notmuch-hello-tag-list-make-query" to

Re: [PATCH RFC] index: add body: search query term

2018-10-10 Thread William Casarin
David Bremner writes: > William Casarin writes: > I think you'll find you broke non-prefixed queries. Does the test suite > still pass? If so, we need more tests. yeah they seem to pass. but you're right, something seems a bit off: ./notmuch count subject:github or bo

Re: [PATCH RFC] index: add body: search query term

2018-10-10 Thread William Casarin
William Casarin writes: > I wonder if it's all worth the effort though, since a workaround could > be: > > notmuch search and not subject: > > If it's too annoying to have a body prefix, due to index bloat or > performance issues, would doing something hacky such a

Re: [PATCH] emacs: filter tag completions by current query

2018-11-24 Thread William Casarin
William Casarin writes: > When filtering by tags in notmuch-search-filter-by-tag, only return tags > related to the current query. > > Before, it was returning all tags. There's no reason to refine the > current query with tags that don't exist in the current result set.

Re: [PATCH] Fix notmuch-describe-key

2019-03-03 Thread William Casarin
Yang Sheng writes: > Fix notmuch-describe-key crashing for the following two cases > 1. format-kbd-macro cannot deal with keys like [(32 . 126)], switch to > use key-description instead. > 2. if a function in the current keymap is not bounded, it will crash > the whole process. We check if it is

[PATCH] perf-tests: #!/bin/bash -> #!/usr/bin/env bash

2019-05-31 Thread William Casarin
I couldn't run the performance tests on my machines due to a hardcoded bash path. Use env for finding bash in weird systems like NixOS. Signed-off-by: William Casarin --- performance-test/M00-new.sh | 2 +- performance-test/M01-dump-restore.sh| 2 +- performance-test/M02-show.sh

Re: v3 of legacy-display cleanup

2019-06-24 Thread William Casarin
Daniel Kahn Gillmor writes: > This is the third revision of the series that cleans up legacy-display > protected headers parts so that notmuch users only have to look at one > subject line. > > version 2 can be found at id:20190531075907.17035-1-...@fifthhorseman.net > version 1 can be found at

Re: [PATCH 1/7] mime-node: split out _mime_node_set_up_part

2019-06-24 Thread William Casarin
Daniel Kahn Gillmor writes: > This is a code reorganization that should have no functional effect, > but will make future changes simpler, because a future commit will > reuse the _mime_node_set_up_part functionality without touching > _mime_node_create. > > In the course of splitting out this

Re: [PATCH] emacs: add keywords to notmuch-emacs-mua.desktop

2019-06-24 Thread William Casarin
Daniel Kahn Gillmor writes: > Ping! If there is a reason that this trivial patch has languished, i'd > be happy to receive critical feedback. Or maybe we can just merge it? > >--dkg Looks good to me! -- https://jb55.com ___ notmuch mailing list

Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display

2019-06-24 Thread William Casarin
Daniel Kahn Gillmor writes: > This is a utility function designed to make it easier to > "fast-forward" past a legacy-display part associated with a > cryptographic envelope, and show the user the intended message body. > > The bulk of the ugliness in here is in the test function >

Re: [PATCH] emacs: bind C-u Z to notmuch-tree-from-search-thread

2019-11-13 Thread William Casarin
David Edmondson writes: > On Wednesday, 2019-11-13 at 00:00:04 -08, William Casarin wrote: > >> This is an unbound function that is quite useful. It opens a selected >> thread in notmuch-tree from the current search query. > > Seems fine to me. Not crazy about the bind

Re: [PATCH] emacs: bind C-u Z to notmuch-tree-from-search-thread

2019-11-13 Thread William Casarin
Teemu Likonen writes: > William Casarin [2019-11-13T00:00:04-08] wrote: > >> This is an unbound function that is quite useful. It opens a selected >> thread in notmuch-tree from the current search query. > > I agree that it is good idea to bind notmuch-tree-from-search-t

[PATCH] emacs: bind M-RET to notmuch-tree-from-search-thread

2019-11-13 Thread William Casarin
This is an unbound function that is quite useful. It opens a selected thread in notmuch-tree from the current search query. Signed-off-by: William Casarin --- This is a simpler alternative to id:20191113080004.32214-1-j...@jb55.com emacs/notmuch.el | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 3/7] emacs/tree: add notmuch-tree-matching-message

2019-11-17 Thread William Casarin
This functions removes some duplicate logic between notmuch-tree-{next,prev}-matching-message We do this because we will be adding some additional logic similar to the notmuch-show-next-open-message function, and it will help if this logic is all in one place. Signed-off-by: William Casarin

[PATCH 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-11-17 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-message-than-next-or-exit. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index

[PATCH 0/7] Port notmuch-show's x/X bindings to notmuch-tree

2019-11-17 Thread William Casarin
These patches bring notmuch-tree more in line with the user experience of notmuch-show by adding the x/X bindings. id:20191113225752.26502-1-j...@jb55.com is also recommended, it adds a bind for opening a thread in notmuch-tree mode. William Casarin (7): emacs/tree: return true if a thread

[PATCH 7/7] emacs/tree: add x/X bindings

2019-11-17 Thread William Casarin
Add x and X binds to notmuch-tree for functionally that we have in notmuch-show. The notmuch-tree-quit binding is somewhat redundant, since it is handled by notmuch-bury-or-kill-this-buffer which is bound to q. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 3 ++- 1 file changed, 2

[PATCH 2/7] emacs/tree: add notmuch-tree-goto-matching-message

2019-11-17 Thread William Casarin
This function captures some common logic when jumping to matching messages in notmuch-tree mode. We also add a new return value (t or nil), that indicates if there was a next matching message in the thread to show. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 17

[PATCH 1/7] emacs/tree: return true if a thread was found in next-thread

2019-11-17 Thread William Casarin
This will allow us to pop back to parent buffers when there are no more threads to jump to. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index c00315e8..4bc05160

[PATCH 4/7] emacs/tree: add kill-both prefix argument to notmuch-tree-quit

2019-11-17 Thread William Casarin
This allows us to close both windows at the same time. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index b9173790..367b10c4 100644 --- a/emacs/notmuch-tree.el

[PATCH 6/7] emacs/tree: add notmuch-tree-archive-thread-then-exit

2019-11-17 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-thread-then-exit Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 ++ 1 file changed, 6 insertions(+) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index fd6f9f83..b8844b64 100644 --- a/emacs/notmuch-tree.el

Re: [PATCH 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-11-17 Thread William Casarin
William Casarin writes: > This is the notmuch-tree version of > notmuch-show-archive-message-than-next-or-exit. > > Signed-off-by: William Casarin > --- > emacs/notmuch-tree.el | 30 -- > 1 file changed, 20 insertions(+), 10 deletions(-) &

Re: [PATCH 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-11-18 Thread William Casarin
David Edmondson writes: > On Sunday, 2019-11-17 at 15:17:58 -08, William Casarin wrote: > >> I'll push out a v2 later if this gets enough Concept ACKs. > > The changes make sense to me in principle, but I don't use > notmuch-tree. It would be good if someone who does could t

Re: Unread handling

2019-11-12 Thread William Casarin
David Edmondson writes: > On Monday, 2019-11-11 at 00:16:17 +01, Johan Parin wrote: >> I'm trying instead to use the tree view, this seems to me the >> more natural way to view threads. So I immediately do `Z' >> whenever I enter a thread. I would like to have the option to >> enter tree view

Re: Unread handling

2019-11-12 Thread William Casarin
Teemu Likonen writes: > Teemu Likonen [2019-11-12T16:54:35+02] wrote: > >> But indeed, a command like "notmuch-search-show-thread-tree" (M-RET, >> C-u RET, C-RET...) would be useful: open current thread directly in >> tree view and with current search terms. > > But that is already there

Re: Unread handling

2019-11-12 Thread William Casarin
Teemu Likonen writes: > William Casarin [2019-11-12T05:17:46-08] wrote: > >> I find myself doing `c i z Ctrl-v` to open the tree view for a >> specific thread, but perhaps it would make sense if there was a >> default keybind for this. > > Seems like the same as pre

Re: Unread handling

2019-11-12 Thread William Casarin
David Edmondson writes: > On Tuesday, 2019-11-12 at 05:17:46 -08, William Casarin wrote: > >> David Edmondson writes: >>> On Monday, 2019-11-11 at 00:16:17 +01, Johan Parin wrote: >>>> I'm trying instead to use the tree view, this seems to me the >>&g

Re: [PATCH v2 1/8] emacs/tree: return true if a thread was found in next-thread

2019-12-04 Thread William Casarin
David Edmondson writes: > On Thursday, 2019-11-28 at 08:13:54 -08, William Casarin wrote: > >> This will allow us to pop back to parent buffers when there are no >> more threads to jump to. >> >> Signed-off-by: William Casarin >> --- >> emacs/notmuch-

Re: [PATCH v2 2/8] emacs/tree: add notmuch-tree-goto-matching-message

2019-12-04 Thread William Casarin
David Edmondson writes: > On Thursday, 2019-11-28 at 08:13:55 -08, William Casarin wrote: > >> This function captures some common logic when jumping to matching >> messages in notmuch-tree mode. >> >> We also add a new return value (t or nil), that indicates i

Re: [PATCH v2 0/8] Port notmuch-show's x/X bindings to notmuch-tree

2019-12-04 Thread William Casarin
Teemu Likonen writes: > William Casarin [2019-11-28T08:13:53-08] wrote: > >> These patches bring notmuch-tree more in line with the user experience >> of notmuch-show by adding the x/X bindings. >> >> v2: >> - fix a bug when moving between open messages &

Re: Handle PKCS#7 signedData (S/MIME single-part clearsigned)

2019-12-09 Thread William Casarin
Hey Daniel, Daniel Kahn Gillmor writes: > Several of the patches should be simple to read and uncontroversial (I > hope!), and I welcome/encourage merging of those patches to reduce the > length of the remaining series. I did a quick skim and it looks ok, although I'm not super familiar with

[PATCH v2 0/8] Port notmuch-show's x/X bindings to notmuch-tree

2019-11-28 Thread William Casarin
William Casarin (8): emacs/tree: return true if a thread was found in next-thread emacs/tree: add notmuch-tree-goto-matching-message emacs/tree: add notmuch-tree-matching-message emacs/tree: add kill-both prefix argument to notmuch-tree-quit emacs/tree: add notmuch-tree-archive-message-than

[PATCH v2 2/8] emacs/tree: add notmuch-tree-goto-matching-message

2019-11-28 Thread William Casarin
This function captures some common logic when jumping to matching messages in notmuch-tree mode. We also add a new return value (t or nil), that indicates if there was a next matching message in the thread to show. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 17

[PATCH v2 6/8] emacs/tree: add notmuch-tree-archive-thread-then-exit

2019-11-28 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-thread-then-exit Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 ++ 1 file changed, 6 insertions(+) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index 8e596459..40838487 100644 --- a/emacs/notmuch-tree.el

[PATCH v2 8/8] emacs: bind M-RET to notmuch-tree-from-search-thread

2019-11-28 Thread William Casarin
This is an unbound function that is quite useful. It opens a selected thread in notmuch-tree from the current search query. Signed-off-by: William Casarin --- emacs/notmuch.el | 1 + 1 file changed, 1 insertion(+) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 773d1206..0d68d123 100644

[PATCH v2 7/8] emacs/tree: add x/X bindings

2019-11-28 Thread William Casarin
Add x and X binds to notmuch-tree for functionally that we have in notmuch-show. The notmuch-tree-quit binding is somewhat redundant, since it is handled by notmuch-bury-or-kill-this-buffer which is bound to q. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 3 ++- 1 file changed, 2

[PATCH v2 5/8] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-11-28 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-message-than-next-or-exit. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index

[PATCH v2 4/8] emacs/tree: add kill-both prefix argument to notmuch-tree-quit

2019-11-28 Thread William Casarin
This allows us to close both windows at the same time. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index b9173790..367b10c4 100644 --- a/emacs/notmuch-tree.el

[PATCH v2 1/8] emacs/tree: return true if a thread was found in next-thread

2019-11-28 Thread William Casarin
This will allow us to pop back to parent buffers when there are no more threads to jump to. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index c00315e8..4bc05160

[PATCH v2 3/8] emacs/tree: add notmuch-tree-matching-message

2019-11-28 Thread William Casarin
This functions removes some duplicate logic between notmuch-tree-{next,prev}-matching-message We do this because we will be adding some additional logic similar to the notmuch-show-next-open-message function, and it will help if this logic is all in one place. Signed-off-by: William Casarin

Re: [PATCH v3 0/7] Port notmuch-show's x/X bindings to notmuch-tree

2020-02-21 Thread William Casarin
Daniel Kahn Gillmor writes: > On Sat 2019-12-28 10:01:17 -0500, William Casarin wrote: >> These patches bring notmuch-tree more in line with the user experience >> of notmuch-show by adding the x/X bindings. > > It looks like this series has been reviewed by dme, and is

[PATCH v3 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-12-28 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-message-than-next-or-exit. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index

[PATCH v3 0/7] Port notmuch-show's x/X bindings to notmuch-tree

2019-12-28 Thread William Casarin
.@jb55.com since it has already been upstreamed v2: id:20191128161401.28844-1-j...@jb55.com - fix a bug when moving between open messages - include M-RET keybinding patch from id:20191113225752.26502-1-j...@jb55.com v1: id:20191117222929.1064-1-j...@jb55.com William Casarin (7): emacs/tr

[PATCH v3 3/7] emacs/tree: add notmuch-tree-matching-message

2019-12-28 Thread William Casarin
This functions removes some duplicate logic between notmuch-tree-{next,prev}-matching-message We do this because we will be adding some additional logic similar to the notmuch-show-next-open-message function, and it will help if this logic is all in one place. Signed-off-by: William Casarin

[PATCH v3 2/7] emacs/tree: add notmuch-tree-goto-matching-message

2019-12-28 Thread William Casarin
This function captures some common logic when jumping to matching messages in notmuch-tree mode. We also add a new return value (t or nil), that indicates if there was a next matching message in the thread to show. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 18

[PATCH v3 4/7] emacs/tree: add kill-both prefix argument to notmuch-tree-quit

2019-12-28 Thread William Casarin
This allows us to close both windows at the same time. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index 25d84f45..f66219c5 100644 --- a/emacs/notmuch-tree.el

[PATCH v3 1/7] emacs/tree: return true if a thread was found in next-thread

2019-12-28 Thread William Casarin
This will allow us to pop back to parent buffers when there are no more threads to jump to. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index c00315e8..d262ba26

[PATCH v3 6/7] emacs/tree: add notmuch-tree-archive-thread-then-exit

2019-12-28 Thread William Casarin
This is the notmuch-tree version of notmuch-show-archive-thread-then-exit Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 6 ++ 1 file changed, 6 insertions(+) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index cdf68ed4..e9c0433c 100644 --- a/emacs/notmuch-tree.el

[PATCH v3 7/7] emacs/tree: add x/X bindings

2019-12-28 Thread William Casarin
Add x and X binds to notmuch-tree for functionally that we have in notmuch-show. The notmuch-tree-quit binding is somewhat redundant, since it is handled by notmuch-bury-or-kill-this-buffer which is bound to q. Signed-off-by: William Casarin --- emacs/notmuch-tree.el | 3 ++- 1 file changed, 2

[PATCH] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-16 Thread William Casarin
From: Jonas Bernoulli Starting with Emacs 27 the old `cl' implementation is finally considered obsolete. Previously its use was strongly discouraged at run-time but one was still allowed to use it at compile-time. For the most part the transition is very simple and boils down to adding the

Re: [PATCH 1/7] emacs/tree: return true if a thread was found in next-thread

2020-04-04 Thread William Casarin
William Casarin writes: > This will allow us to pop back to parent buffers when there are no > more threads to jump to. > > Signed-off-by: William Casarin > --- > > This is as rebased version of id:20191228150124.20630-1-j...@jb55.com > as requested in id:87v9mg3gut

  1   2   >