[notmuch] hack to retag a directory

2009-12-03 Thread david
I think this will be obsolete pretty soon when the equivalent is built-in to notmuch, but in the mean time, here is a script that somebody might find useful: retag a whole directory (recursively). I don't claim it is nice in any way, but it seems usable for me, taking about 5 seconds to retag a

[notmuch] [PATCH 1/2] notmuch-search-process-filter: add text properties for authors and subject to each line

2009-12-04 Thread david
From: David Bremner brem...@unb.ca Add functions notmuch-search-find-authors and notmuch-find-subject to match notmuch-find-thread-id. These functions are just a wrapper around get-text-property, but in principle that could change. --- notmuch.el | 12 +++- 1 files changed, 11

[notmuch] [PATCH 2/2] notmuch-show: add optional argument for query context instead of using global binding notmuch-search-query-string

2009-12-04 Thread david
From: David Bremner brem...@unb.ca Also modify the one call to notmuch-show in notmuch.el. This makes the call (notmuch-show thread-id) will work when there is no binding for notmuch-search-query-string; e.g. when called from user code outside notmuch. --- notmuch.el | 16 ++-- 1

[notmuch] [PATCH] notmuch-restore.c: only update tags for messages that differ from dump file.

2009-12-07 Thread david
From: David Bremner brem...@unb.ca The main feature of this patch is that it compares the list of current tags on a message with those read by restore. Only if the two lists differ is the tag list in the message replaced. In my experiments this leads to a large performance improvement. Since I

[notmuch] [PATCH] notmuch-restore.c: only update tags for messages that differ from dump file.

2009-12-08 Thread david
From: David Bremner brem...@unb.ca The main feature of this patch is that it compares the list of current tags on a message with those read by restore. Only if the two lists differ is the tag list in the message replaced. In my experiments this leads to a large performance improvement. Since I

[notmuch] [PATCH] initial proof of concept patch to output a message in json

2009-12-13 Thread david
From: David Bremner brem...@unb.ca --- Like I said in the apology/introduction, I don't claim this patch is ready for the master branch; hence the complete lack of sensible commit message. But it does give some idea about what would be required. In particular definitely more things will have

[notmuch] Prototype of --show option to control what is shown.

2009-12-19 Thread david
Here is a set of 3 patches to implement (some) output control. [PATCH 1/3] rename option to select output format to --format from --output. [PATCH 2/3] notmuch-show.c: make calls to format functions conditional The first two are essentially suggestions for Scott. In particular the first is

[notmuch] [PATCH 2/3] notmuch-show.c: make calls to format functions conditional

2009-12-19 Thread david
From: David Bremner brem...@unb.ca This makes it easier to define minimal formats without defining several dummy functions that do nothing. --- notmuch-show.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index b6e3f44

[notmuch] [PATCH 3/3] notmuch-show.c: prototype tabular output format, with output control

2009-12-19 Thread david
From: David Bremner brem...@unb.ca Currently this only outputs the information from the message header; i.e. the part before the rfc2822 header or body. Adding this required adding an extra parameter, currently unused, to format_message_text and format_message_json. Also the struct definition

[notmuch] [PATCH] notmuch.el: add a submap (on z for ztash) to stash things.

2009-12-25 Thread david
From: David Bremner brem...@unb.ca Provide key bindings for stuffing everything with a notmuch-show-get-foo function into the emacs kill-ring as text. Currently this is just message-id, filename, and tags. --- One thing I find myself doing often is going into raw message mode in order to grab

[notmuch] Update Patch Series. Only collapse part of citations.

2009-12-25 Thread david
be really irritating, but I got used to it pretty quickly. So give it a chance ;). Hiding buttons or replacing them looks a bit messy to me. David ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[notmuch] [PATCH 2/2] notmuch.el: show some of citation even when hiding.

2009-12-25 Thread david
From: David Bremner brem...@unb.ca - rename notmuch-show-citation-lines-min to n-s-c-l-prefix - call forward-line with the appropriate parameter to adjust region to be hidden. - change citation button text so that it makes (some) sense when citation is shown --- notmuch.el | 18

[notmuch] [PATCH 2/2] notmuch.el: convert sparse keymap to a list in notmuch-substitute-one-command-key-with-prefix

2009-12-26 Thread david
From: David Bremner brem...@unb.ca The previous version would crash when a key was bound to a sparse keymap, since apparently these are not straightforward lists. The usage of map-keymap is a bit obscure: it only has side-effects, no return value. --- notmuch.el |8 ++-- 1 files changed

[notmuch] [PATCH v3] notmuch.el: Refactor citation markup. Variables for minimum size, button text.

2010-01-16 Thread david
From: David Bremner brem...@unb.ca This is a fairly intrusive rewrite. - I pulled the common code for the signature and citation case out into a separate function. This is not so much shorter, but I think it will be easier to maintain. - I treated top posted copies essentially like

[notmuch] [PATCH] emacs: Move emacs UI (currently just one file) to subdirectory.

2010-02-09 Thread david
From: David Bremner brem...@unb.ca Add emacs/Makefile.local and emacs/Makefile. Move emacs targets into emacs/Makefile.local, but leave the byte compilation rule in the top level Makefile. --- I decided to put the actual targets for byte compilation and installation in emacs/Makefile.local

[notmuch] [PATCH 1/2] notmuch-show-get-header: new function; return alist of parsed header fields.

2010-02-11 Thread david
From: David Bremner brem...@unb.ca This function parses the displayed message to recover header fields. It uses mailheader.el to do the actual header parsing, after preprocessing to remove indentation. It relies on the variables notmuch-show-message-begin-regexp, notmuch-show-header-begin-regexp

[notmuch] [PATCH 2/2] Add functions notmuch-show-get-(bcc, cc, date, from, subject, to) to return the corresponding header field for the current message as a string. These are thin wrappers around not

2010-02-11 Thread david
From: David Bremner brem...@unb.ca --- notmuch.el | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/notmuch.el b/notmuch.el index c96fd94..d2a3b1b 100644 --- a/notmuch.el +++ b/notmuch.el @@ -225,6 +225,38 @@ Unlike builtin `previous-line

[notmuch] [PATCH v2] Add functions notmuch-show-get-(bcc, cc, date, from, subject, to).

2010-02-11 Thread david
From: David Bremner brem...@unb.ca Return the corresponding header field for the current message as a string. These are thin wrappers around notmuch-show-get-header, which means they each cause a full parse of the RFC822 header. The main idea is to fix an api. --- Sorry, resending with fixed

[notmuch] Rebased and updated stash patches.

2010-02-11 Thread david
These patches let you header fields and similar into the emacs kill-ring (and the X11 clipboard/selection, if things are setup right). Patch 1/2 is actually a bug fix to master, unchanged since last time. The bug didn't manifest because no submaps were used. Patch 2/2 is rebased against current

[notmuch] [PATCH 1/2] notmuch.el: convert sparse keymap to a list in notmuch-substitute-one-command-key-with-prefix

2010-02-11 Thread david
From: David Bremner brem...@unb.ca The previous version would crash when a key was bound to a sparse keymap, since apparently these are not straightforward lists. The usage of map-keymap is a bit obscure: it only has side-effects, no return value. --- notmuch.el |8 ++-- 1 files changed

[notmuch] [PATCH v2] notmuch-query.el: new file to support access to the notmuch database.

2010-02-24 Thread david
From: David Bremner brem...@unb.ca Initially this file provides one main function notmuch-query-get-threads, which takes a set of search terms, and returns a parsed set of matching threads as a lisp data structure. A set of notmuch-query-map-* functions are provided to help map functions over

[notmuch] [PATCH] notmuch.el: hide original message in top posted replies.

2010-02-24 Thread david
From: David Bremner brem...@unb.ca This code treats top posted copies essentially like signatures, except that it doesn't sanity check their length, since neither do their senders. In an unrelated cleanup, remove the let definition of sig-end, since it was unused. New user-visible variable

[notmuch] [PATCH] notmuch.el: add a hook to notmuch-reply

2010-02-26 Thread david
From: David Bremner brem...@unb.ca This patch introduces a variable notmuch-reply-hook and calls it using run-hooks. This allows people to easily override the header setup and so forth done by notmuch. --- This is my solution to trying to rationalize the headers of 'm' versus 'r'; now I just

[notmuch] [PATCH v3] notmuch-query.el: new file to support access to the notmuch database.

2010-04-05 Thread david
From: David Bremner brem...@unb.ca Initially this file provides one main function notmuch-query-get-threads, which takes a set of search terms, and returns a parsed set of matching threads as a lisp data structure. A set of notmuch-query-map-* functions are provided to help map functions over

[PATCH 1/3] remove stale unused from around argv and argc in notmuch_show_command.

2010-04-24 Thread david
From: David Bremner brem...@unb.ca In fact argc and argv are used in this function. --- notmuch-show.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 26449fa..6aa9072 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -403,7

[PATCH 2/3] notmuch-output.[ch]: initial implementation of output selection argument handling.

2010-04-24 Thread david
From: David Bremner brem...@unb.ca These two files provide a more or less object oriented approach to parsing output selection arguments. The use of a struct to track which output pieces are selected is intended to hide the implementation, which currently uses bitmasks. --- Makefile.local

[PATCH 3/3] notmuch-show.c: control which headers are show for json output.

2010-04-24 Thread david
From: David Bremner brem...@unb.ca This commit adds argument handling from and callbacks to notmuch-output.c to determine what headers to show in json output. This requires passing a pointer to a struct containing the output parameters into several functions, and in particular changes the type

[PATCH] notmuch.pod: pod version of documentation, converted by rman, massaged by hand.

2010-06-13 Thread david
From: David Bremner brem...@unb.ca Some places I deleted a bit of the continuity text introducing a command because I didn't see how to make it work with the slightly more structured layout. I also moved show in front of search, because it explains the output formats. Probably it would make

First draft of logging functionality.

2010-10-11 Thread david
and use the same for all potential logging, but perhaps this is too much design by convenient implementation. Canadian-Thanksgiving-Greetings, David ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/3] Initial implementation of low level logging routines.

2010-10-11 Thread david
From: David Bremner brem...@unb.ca notmuch_log_open: open a log file; just a wrapper around open(2) notmuch_log_append: atomically append a buffer (character array) to a log file Based on per-write file locking, performance will have to be tested. --- Makefile.local |1 + notmuch-client.h

[PATCH 2/3] notmuch-log.c: Add a function to log a pair of strings with a timestamp.

2010-10-11 Thread david
From: David Bremner brem...@unb.ca Since the function is supposed to work for any pair of strings, this means some form of quoting seems necessary. I decided to re-use the json quoting routines for convenience. --- notmuch-client.h |4 notmuch-log.c| 18 ++ 2 files

[PATCH 4/4] Enable logging in notmuch-tag.c

2010-10-24 Thread david
From: David Bremner brem...@unb.ca Currently a separate function must be called to enable logging; this API is subject to change. --- notmuch-tag.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/notmuch-tag.c b/notmuch-tag.c index fd54bc7..bd7bfbc 100644

[PATCH 3/4] Add logging to low level message handling routines.

2010-10-24 Thread david
From: David Bremner brem...@unb.ca This might not be ideal from the point of view of atomic transactions, but it is transparent to the caller of the library. --- lib/message.cc | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/lib/message.cc b

Second draft of logging patches

2010-10-24 Thread david
Here is my second try at logging, taking into account the feedback I got from Rob and Michal. There is definitely some tidying to do; in particular I know the protoypes in public headers need documentation. Also, I should add a configuration option to enable configuration by command or something

[PATCH 2/4] Add log component to database struct.

2010-10-24 Thread david
From: David Bremner brem...@unb.ca - add accessor required because the notmuch database struct is opaque - add a function notmuch_database_open_log to open a log file and associate it with an open database. The reasoning is that this is preferable to breaking the notmuch_database_open API

[PATCH 1/4] Initial implementation of low level logging routines.

2010-10-24 Thread david
From: David Bremner brem...@unb.ca notmuch_log_open: open a log file; return an opaque log descriptor notmuch_log_words: log words, escaping spaces and newlines, and appending a newline. Log format is space delimited, and line oriented. Escaping log text is currently based on a slightly

generate help from pod.

2010-11-03 Thread david
Hi Carl; Here is the generation. I hope you don't hate perl too much. I also hope the syntax in notmuch.pod is self-explanatory. For me, with perl 5.10.1, this only uses modules included with Perl. ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH 2/4] Perl script to generate online help.

2010-11-03 Thread david
From: David Bremner brem...@unb.ca This is a bit more complicated than expected, mainly because it needs to split a chunk of the docs into 3 pieces corresponding to the strings currently filled into a struct command_t. To disable the ANSI escape codes, replace Pod::Text:Color with Pod::Text

[PATCH 1/4] notmuch.pod: pod version of documentation, converted by rman, massaged by hand.

2010-11-03 Thread david
From: David Bremner brem...@unb.ca Some places I deleted a bit of the continuity text introducing a command because I didn't see how to make it work with the slightly more structured layout. I also moved show in front of search, because it explains the output formats. Probably it would make

[PATCH 4/4] notmuch.c: use help strings generated from notmuch.pod.

2010-11-03 Thread david
From: David Bremner brem...@unb.ca It is quite possible this could be more automagically generated; there is a certain amount of boilerplate in typing HELP_command_args, HELP_command_desc, HELP_command_text. But, this way is less error prone. --- notmuch.c | 388

[PATCH] Build debian package for python-bindings.

2011-06-19 Thread david
From: David Bremner brem...@debian.org This uses dh_python2 (included with sufficiently recent versions of the python/python-all packages). python-all brings in all of the supported versions of python. The double calls to dh_auto_install are to avoid looping over python versions ourselves

[no subject]

2011-06-19 Thread david
Bah, my previous attempt didn't build cleanly in a chroot, so I had to patch setup.py. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] Build debian package for python-bindings.

2011-06-19 Thread david
From: David Bremner brem...@debian.org This uses dh_python2 (included with sufficiently recent versions of the python/python-all packages). python-all brings in all of the supported versions of python. The double calls to dh_auto_install are to avoid looping over python versions ourselves

[PATCH 2/2] Do not import notmuch in setup.py.

2011-06-19 Thread david
From: David Bremner brem...@debian.org Importing notmuch loads the notmuch shared library. When building without a system install of notmuch, this requires e.g. setting LD_LIBRARY_PATH for building and fails completely for cleaning. --- bindings/python/setup.py | 17 - 1 files

[no subject]

2011-06-21 Thread david
Here is my proposal, based on Clint's suggestion on IRC, and on the sed hack from librhash, to hide all symbols that are not explicitly part of the notmuch API. In particular it hides the various symbols related to Xapian exceptions. ___ notmuch mailing

[PATCH 1/2] libnotmuch: add linker script to declare only notmuch_* symbols as global.

2011-06-21 Thread david
From: David Bremner brem...@debian.org This is closely tied to gcc and particularly gnu ld, but I guess the shared library linking code would need to be adjusted to work on a non-gnu linker anyay. I had to make a few not-obviously related changes to the lib/Makefile.local to make this work

[PATCH 2/2] remove Xapian exceptions symbols from libnotmuch1.symbols

2011-06-21 Thread david
From: David Bremner brem...@debian.org These were never intended to be public, since the library exports only a C API. --- debian/libnotmuch1.symbols | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/debian/libnotmuch1.symbols b/debian/libnotmuch1.symbols

[PATCH] tests: add a test for symbol hiding side effects

2011-06-22 Thread david
From: David Bremner brem...@debian.org The worry here is that a binary linking with libnotmuch might lose access to Xapian::Error symbols because libnotmuch hides them. --- test/basic |2 +- test/notmuch-test |1 + test/symbol-hiding | 21 + test/symbol

[PATCH] libnotmuch: fix typos in CLEAN setting, add file

2011-06-25 Thread david
From: David Bremner brem...@debian.org - c0961e6 introduced a missing slash between $(dir)$(LIBNAME) and missing $(dir) in front of libnotmuch.a - cdf1c70a created a file $(dir)/notmuch.h.gch and neglected to add it to CLEAN --- Here is an updated version. I'm not sure the best way to do

[PATCH] libnotmuch: build symbols list without relying on gcc -aux-info.

2011-06-26 Thread david
From: David Bremner brem...@debian.org Carl reports gcc -aux-info notmuch.aux lib/notmuch.h does not generate notmuch.aux for him with Debian gcc 4.6.0-8. A small modification of the original sed regular expression allows us to work directly from lib/notmuch.h, rather than preprocessing with gcc

[PATCH] libnotmuch: build symbols list without relying on gcc -aux-info.

2011-06-26 Thread david
From: David Bremner brem...@debian.org Carl reports gcc -aux-info notmuch.aux lib/notmuch.h does not generate notmuch.aux for him with Debian gcc 4.6.0-8. Based on a suggestion by Austin Clements, this version uses objdump to get the symbols from the object files. Any symbol

[PATCH] lib/Makefile.local: remove leftover debugging output.

2011-06-29 Thread david
From: David Bremner brem...@debian.org The removed echo $(libnotmuch_modules) was strictly for debugging. Thanks to Austin Clements for the hint. --- lib/Makefile.local |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/lib/Makefile.local b/lib/Makefile.local index 6dd095c

[PATCH 1/2] test/symbol-hiding: rename to test/libnotmuch-abi, prepare to add more subtests

2011-06-29 Thread david
From: David Bremner brem...@debian.org Test descriptions changed to accomodate more subtests. The generic 'run_test' is renamed 'run_exception_test', symbol-test(.cc) is renamed exception-test(.cc). --- I'm not sure if it would be better to start a new test script rather than this fuss about

[PATCH 2/2] test/libnotmuch-abi: compare exported symbols, available symbols, and linker script.

2011-06-29 Thread david
From: David Bremner brem...@debian.org This uses objdump and awk to grab the available notmuch_ symbols from the object files and all exported symbols from libnotmuch.so. The symbols from the linker script are grabbed using sed. All three of these sets of symbols should be equal. --- test

Proposed changes to release target

2011-07-04 Thread david
When pushing 0.6 out the door, I found the release target in Makefile daunting. This was partly lack of confidence/understanding on my part: I didn't really like the idea of starting a chain of events that I didn't fully understand that ended up copying files to the web site. Also, it didn't

[PATCH 1/6] build-system: replace use of ssh with wget for checking the website

2011-07-04 Thread david
From: David Bremner brem...@debian.org The idea is to see if the version we are already releasing exists on the notmuch website. Using wget allows more people to run this target, and also allows people with ssh access to run it without access to their keys. --- Makefile.local | 15

[PATCH 3/6] build-system: tag earlier in the release process.

2011-07-04 Thread david
From: David Bremner brem...@debian.org If tagging fails, we really don't want to upload tarballs. --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index dea813c..b6445e5 100644 --- a/Makefile.local +++ b/Makefile.local

[PATCH 6/6] build-system: guard parts irrevokable parts of release target with REALLY_UPLOAD

2011-07-04 Thread david
From: David Bremner brem...@debian.org This supports both testing and use by non-upload privileged users. Along with previous commits in the series, this lets one do a dry run of the release process and created a tarball, signature file, and release announcement to inspect before uploading

[PATCH 4/6] build-system: use signed tag to make tar file, if available.

2011-07-04 Thread david
From: David Bremner brem...@debian.org This as the advantage that make VERSION=n.m dist will work correctly even if the wrong branch happens to be checked out. --- Makefile.local |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index

[PATCH 2/6] build-system: remove calls to git-buildpackage and dput in release target.

2011-07-04 Thread david
From: David Bremner brem...@debian.org The removed code had the following issues: - It depends on the users git-buildpackage configuration to put the results in the correct place, so is fragile. - The tar file is overwritten in the next step, so copying it is not useful. - We should build

[no subject]

2011-07-16 Thread david
So, my conclusion is that we need to export these typeinfo symbols, and it seems to be sufficient to do so to fix the failing tests and crashes discussed above. I think I managed to add them to the debian symbols file in a better way, so every toolchain change and different architecture doesn't

[PATCH 1/2] libnotmuch: export Xapian typeinfo symbols

2011-07-16 Thread david
From: David Bremner brem...@debian.org The lack of such exporting seems to cause problems catching exceptions, as suggested by http://gcc.gnu.org/wiki/Visibility This manifested in the symbol-hiding test failing when notmuch was compile with gcc 4.4.5. On i386, this further manifested

[PATCH 2/2] debian: add (demangled) Xapian exception typeinfo symbols to libnotmuch1.symbols

2011-07-16 Thread david
From: David Bremner brem...@debian.org These are exported (again) by the library to prevent problems with catching exceptions. --- debian/libnotmuch1.symbols | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/debian/libnotmuch1.symbols b/debian/libnotmuch1.symbols

[PATCH] libnotmuch: export Xapian typeinfo symbols

2011-07-16 Thread david
From: David Bremner brem...@debian.org The lack of such exporting seems to cause problems catching exceptions, as suggested by http://gcc.gnu.org/wiki/Visibility This manifested in the symbol-hiding test failing when notmuch was compile with gcc 4.4.5. On i386, this further manifested

[PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

2011-09-11 Thread david
From: David Bremner brem...@debian.org Commit 4cc6727 introduced the library function test_subtest_known_broken which sets a variable test_subtest_known_broken_ . Unfortunately this variable is not reset if test_begin_subtest is not called before the next test_expect_success

[PATCH] test: reset test_subtest_known_broken_ after each success/failure.

2011-09-12 Thread david
From: David Bremner brem...@debian.org This means that test_subtest_known_broken needs to be called before every known broken subtest, which is no different than what is documented for the test_begin_subtest case. The assumption is that every test ends up calling either skipping, calling

[no subject]

2011-10-10 Thread david
OK, here is my proposal to add search terms to notmuch dump. Most of the work is in argument processing. It would be nice if we could factor some of that out. 02be821 notmuch-dump: deprecate use of output file argument. 2b7781d test: all dump-restore tests should be working now 7a203d6

[PATCH 2/6] test: add tests for command line arguments to notmuch-dump

2011-10-10 Thread david
From: David Bremner brem...@debian.org The plan is to add the possibility of search terms after the file name, and the use of -- to stop looking for an output file name. --- test/dump-restore | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git

[PATCH 1/6] test: update dump-restore to use redirection instead of filename args

2011-10-10 Thread david
From: David Bremner brem...@debian.org The idea here is that we want to deprecate the use of arguments to dump and restore to specify paths, since in particular we want to use the non-option arguments to dump to form a query. --- test/dump-restore | 10 +- 1 files changed, 5 insertions

[PATCH 5/6] test: all dump-restore tests should be working now

2011-10-10 Thread david
From: David Bremner brem...@debian.org 3 x test_subtest_known_broken removed to tidy up the output. --- test/dump-restore |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/test/dump-restore b/test/dump-restore index 699337c..d8db259 100755 --- a/test/dump-restore +++ b

[PATCH 6/6] notmuch-dump: deprecate use of output file argument.

2011-10-10 Thread david
From: David Bremner brem...@debian.org We print an intentionally non-specific message on stderr, since it isn't clear if there will be some global output file argument to replace. We update the test suite atomically, since it relies on having the same text in two files. --- notmuch-dump.c

[PATCH 4/6] notmuch-dump: treat any remaining arguments after the filename as search terms

2011-10-10 Thread david
From: David Bremner brem...@debian.org The main motivation here is allow the fast dumping of tag data for messages having certain tags. In practice it seems too slow to pipe dump to grep. --- notmuch-dump.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git

[PATCH 3/6] notmuch-dump: update handling of file name argument

2011-10-10 Thread david
From: David Bremner brem...@debian.org We permit -- as an option processing terminator. Currently this does not do anything useful, but we plan to add search terms after the --. --- notmuch-dump.c | 27 --- 1 files changed, 16 insertions(+), 11 deletions(-) diff --git

make debian-snapshot

2011-10-12 Thread david
Here is a simple way to make debian packages for testing without fussing about with pristine-tar and so on. The first patch changes the git snapshot versioning scheme from 0.9-2-g1234 to 0.9+2~g1234 to reduce confusion with released versions like 0.9-2 In principle this should work outside a

[PATCH 1/2] build system: remove dashes from git-describe generated version.

2011-10-12 Thread david
From: David Bremner brem...@debian.org This makes it less confusing with released Debian versions, now that we have non-native Debian versions. --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index 38f6c17..2c07bd7

[PATCH 2/2] build system: target to make a Debian snapshot package.

2011-10-12 Thread david
From: David Bremner brem...@debian.org Currently this builds a native package, but since the source package is throw away, it should not matter too much, except for the extra warnings from lintian. The extra +1 is so that if $(VERSION) is the same as the last released version (for example

[PATCH] cli: change argument parsing convention for subcommands

2011-10-21 Thread david
From: David Bremner brem...@debian.org previously we deleted the subcommand name from argv before passing to the subcommand. In this version, the deletion is done in the actual subcommands. Although this causes some duplication of code, it allows us to be more flexible about how we parse command

[PATCH 1/2] contrib/nmbug: make nmbug a subdirectory

2012-07-07 Thread david
From: David Bremner brem...@debian.org I want to ship the status tool here as well, along with a sample config file. --- contrib/{ = nmbug}/nmbug |0 1 file changed, 0 insertions(+), 0 deletions(-) rename contrib/{ = nmbug}/nmbug (100%) diff --git a/contrib/nmbug b/contrib/nmbug/nmbug

[PATCH 2/2] contrib/nmbug: add nmbug-status script

2012-07-07 Thread david
From: David Bremner brem...@debian.org This is (almost) the same script as has been used for http://nmbug.tethera.net/status for a while now. The only change is that the configuration is not hardcoded anymore. --- contrib/nmbug/nmbug-status | 132

[PATCH v2] contrib/nmbug: add nmbug-status script

2012-07-08 Thread david
From: David Bremner brem...@debian.org This is (almost) the same script as has been used for http://nmbug.tethera.net/status for a while now. The only change is that the configuration is not hardcoded anymore. By default the config is fetched from a special branch in the nmbug repo that contains

[PATCH v3] contrib/nmbug: add nmbug-status script

2012-07-09 Thread david
From: David Bremner brem...@debian.org This is (almost) the same script as has been used for http://nmbug.tethera.net/status for a while now. The only change is that the configuration is not hardcoded anymore. By default the config is fetched from a special branch in the nmbug repo that contains

Cleaning up cleaning

2012-08-02 Thread david
I ran debuild twice in a row with these patches and it seems OK. I did notice there are still some leftover byte-compiled python (.pyc) files left over after make distclean ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH 3/3] debian: update changelog for cleaning changes

2012-08-02 Thread david
From: David Bremner brem...@debian.org --- debian/changelog |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index 2518988..dfdcf35 100644 --- a/debian/changelog +++ b/debian/changelog @@ -3,7 +3,11 @@ notmuch (0.14-1) unstable

[PATCH 2/3] build system: remove configure output in Make distclean.

2012-08-02 Thread david
From: David Bremner brem...@debian.org Create a variable DISTCLEAN which contains a list of things to clean in the distclean target (in addition to running the clean target). The deleted comment seems to be false these days, since we do create files during configuration. Use rm -rf here as well

[PATCH] debian: alternately depend on emacs24 for notmuch-emacs, build

2012-08-02 Thread david
From: David Bremner brem...@debian.org This should allow users to install notmuch-emacs with only emacs24 installed on their system. For good measure, allow building with emacs24 as a 4th choice. --- debian/changelog |3 ++- debian/control |6 -- 2 files changed, 6 insertions(+), 3

Remove positional arguments to dump and restore

2012-08-03 Thread david
The positional argument to dump was deprecated quite a while ago. For restore, we never formally deprecated it. It seems a bit more consistent this way, but I don't mind leaving restore alone if people feel strongly about it. ___ notmuch mailing

[PATCH 1/2] notmuch-dump: remove deprecated positional argument for output file

2012-08-03 Thread david
From: David Bremner brem...@debian.org The syntax --output=filename is a smaller change than deleting the output argument completely, and conceivably useful e.g. when running notmuch under a debugger. --- man/man1/notmuch-dump.1 |5 ++--- notmuch-dump.c |3 +-- test/dump-restore

[PATCH 2/2] notmuch-restore: replace positional argument for input with option

2012-08-03 Thread david
From: David Bremner brem...@debian.org Since notmuch dump doesn't use positional arguments anymore, it seems better to be consistent. --- man/man1/notmuch-restore.1 |2 +- notmuch-restore.c |2 +- test/dump-restore |8 3 files changed, 6 insertions(+), 6

[PATCH] test: canonicalize content-type in Sending a message via (fake) SMTP

2012-08-29 Thread david
From: David Bremner brem...@debian.org The version of message.el in emacs24 omits the charset=us-ascii, causing the current version of this test to fail. Here we just ask that the content-type start with text/plain --- Alternatively, somebody might want to dig into message.el and understand why

[PATCH] test: canonicalize content-type in Sending a message via (fake) SMTP

2012-08-30 Thread david
From: David Bremner brem...@debian.org The version of message.el in emacs24 omits the charset=us-ascii, causing the current version of this test to fail. With this patch, we accept either option. According to RFC 2046, they are semantically equivalent. --- as discussed on IRC

[PATCH] test: use (format %S) to print nil in emacs test.

2012-08-30 Thread david
From: David Bremner brem...@debian.org The behaviour of emacsclient --eval nil changed from emacs23 to emacs24, and in emacs24 it prints 'nil' rather than an empty string. (format %S foo) produces a sexpr form of foo, and is consistent between the two versions. --- This fixes another test

[PATCH] test: expand regex in test/basic

2012-11-10 Thread david
From: David Bremner brem...@debian.org Over time, maintaining this very long regex has become irritating, especially when resolving conflicts. This patch replaces the call to sed with multiple extra arguments to find. Since each test binary is now on it's own line, this should make resolving

[PATCH v2] test: expand regex in test/basic

2012-11-14 Thread david
From: David Bremner brem...@debian.org Over time, maintaining this very long regex has become irritating, especially when resolving conflicts. This patch replaces the call to sed with multiple extra arguments to find. Since each test binary is now on it's own line, this should make resolving

Uncrustify on notmuch-restore.c, notmuch-dump.c and notmuch-tag.c

2012-11-14 Thread david
Here is the result of running uncrustify on 3 files affected by an upcoming patch series. It makes easier to make sure my new code is reasonable styled if the whole file is uncrustify clean. ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH 1/3] notmuch-tag: tidy formatting

2012-11-14 Thread david
From: David Bremner brem...@debian.org This is just the result of running uncrustify. --- notmuch-tag.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/notmuch-tag.c b/notmuch-tag.c index d15f1ed..88d559b 100644 --- a/notmuch-tag.c +++ b/notmuch-tag.c

[PATCH 2/3] notmuch-restore: tidy formatting

2012-11-14 Thread david
From: David Bremner brem...@debian.org This is again the work of uncrustify. I remember there is some controversy about ! foo versus !foo, but in context I think ! foo looks OK. Also, for functions ! foo (blah) seems better than !foo (blah). --- notmuch-restore.c | 15 +++ 1 file

[PATCH 3/3] notmuch-dump: tidy formatting

2012-11-14 Thread david
From: David Bremner brem...@debian.org More uncrustify at work. --- notmuch-dump.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/notmuch-dump.c b/notmuch-dump.c index d8186fb..88f598a 100644 --- a/notmuch-dump.c +++ b/notmuch-dump.c @@ -30,7 +30,7

[PATCH 1/2] test: add more informative titles to restore --accumulate tests

2012-11-17 Thread david
From: David Bremner brem...@debian.org Thanks to Ethan for the suggestion. --- test/dump-restore |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/dump-restore b/test/dump-restore index f25f7cf..7acf7fe 100755 --- a/test/dump-restore +++ b/test/dump-restore

[PATCH 2/2] test: add nontrivial test for restore --accumulate.

2012-11-17 Thread david
From: David Bremner brem...@debian.org It seems we have never tested the case that restore --accumulate actually adds tags. I noticed this when I started optimizing and no tests failed. The bracketing with restore --input=dump.expected are to make sure we start in a known state, and we leave

initial attempt at performance testing suite for notmuch.

2012-11-17 Thread david
For a long time we have needed some commone set of tests to measure changes to e.g. tagging and dump/restore. A non-trivial corpus of mail messages is a bit unwieldy to be shipped with the source, so there is a seperate tarball. Currently the tarball for this needs to manually uploaded to the

  1   2   3   4   5   6   7   8   9   10   >