[DRAFT] New features in Vim interface

2015-01-20 Thread Bartosz Telenczuk
> Yeah that would be ideal.  Franz and I have been working in a github repo 
> here:
> 
> https://github.com/imain/notmuch-vim

Indeed, that is a lot of commits. It is almost an independent fork. Even more 
so we should work hard to include the changes back into upstream for "the 
benefit of the community".

> Let me know what you think of the code base and if you are willing to help out
> with merging the changes (lots of reviews I think mostly).

I would suggest to start with the patches you already sent to notmuch mailing 
list. I already reviewed three:

VIM: Automatically refresh folder screen, id:54bd89e062df1_a663fec9d49e200a3 at 
bts-MacBook-Pro.local.notmuch
Make an option to save sent mail locally, 
id:1412617904-27252-1-git-send-email-imain at stemwinder.org
Improve moving between messages in a thread, 
id:1412579537-7921-1-git-send-email-imain at stemwinder.org

The last one with only a minor comment. Let me know what you think.

Bartosz


Re: [DRAFT] New features in Vim interface

2015-01-19 Thread Bartosz Telenczuk
 Yeah that would be ideal.  Franz and I have been working in a github repo 
 here:
 
 https://github.com/imain/notmuch-vim

Indeed, that is a lot of commits. It is almost an independent fork. Even more 
so we should work hard to include the changes back into upstream for the 
benefit of the community.

 Let me know what you think of the code base and if you are willing to help out
 with merging the changes (lots of reviews I think mostly).

I would suggest to start with the patches you already sent to notmuch mailing 
list. I already reviewed three:

VIM: Automatically refresh folder screen, 
id:54bd89e062df1_a663fec9d49e200a3@bts-MacBook-Pro.local.notmuch
Make an option to save sent mail locally, 
id:1412617904-27252-1-git-send-email-im...@stemwinder.org
Improve moving between messages in a thread, 
id:1412579537-7921-1-git-send-email-im...@stemwinder.org

The last one with only a minor comment. Let me know what you think.

Bartosz
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[DRAFT] New features in Vim interface

2015-01-18 Thread David Bremner
Ian Main  writes:

> Let me know what you think of the code base and if you are willing to help out
> with merging the changes (lots of reviews I think mostly).

In nmbug commit cb9e7acbb6b I marked the outstanding vim patches from
Ian and Franz as "moreinfo"; we can revisit their status when you guys
decide what you want to do.

Cheers,

d


Re: [DRAFT] New features in Vim interface

2015-01-18 Thread David Bremner
Ian Main im...@stemwinder.org writes:

 Let me know what you think of the code base and if you are willing to help out
 with merging the changes (lots of reviews I think mostly).

In nmbug commit cb9e7acbb6b I marked the outstanding vim patches from
Ian and Franz as moreinfo; we can revisit their status when you guys
decide what you want to do.

Cheers,

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[DRAFT] New features in Vim interface

2015-01-17 Thread Ian Main
Bartosz Telenczuk wrote:
> Dear David, 
> (CC Ian and Franz)
> 
> > Before Christmas we had a flurry of patches from Ian Main (in copy). I
> > think there is some functionality overlap with what you proposed. As far
> > as I know Ian has mainly been working on his private fork of the vim
> > client, but maybe if the two (or three, including Franz) of you can work
> > together to review each other's patches and polish things we can get
> > some of these things upstream.
> 
> Thanks a lot for pointing me to Ian's patches. Indeed, some of the 
> functionality overlaps; this only means that these features are on everyone 
> wishlist. I will be happy to help Ian and Franz get these patches upstream.
> 
> I am not familiar with the review process at NM. If someone could help me to 
> get started, I will be much obliged.
> 
> Yours,
> 
> Bartoz

Yeah that would be ideal.  Franz and I have been working in a github repo here:

https://github.com/imain/notmuch-vim

There are a huge number of changes from what is in the notmuch tree though.
The idea of splitting out the patches and getting them in here is a bit
daunting but we could certainly try.  We also really wanted to refactor the
code but the pace has slowed now; probably because the client is very usable as
it is :).

Let me know what you think of the code base and if you are willing to help out
with merging the changes (lots of reviews I think mostly).

Ian



Re: [DRAFT] New features in Vim interface

2015-01-17 Thread Ian Main
Bartosz Telenczuk wrote:
 Dear David, 
 (CC Ian and Franz)
 
  Before Christmas we had a flurry of patches from Ian Main (in copy). I
  think there is some functionality overlap with what you proposed. As far
  as I know Ian has mainly been working on his private fork of the vim
  client, but maybe if the two (or three, including Franz) of you can work
  together to review each other's patches and polish things we can get
  some of these things upstream.
 
 Thanks a lot for pointing me to Ian's patches. Indeed, some of the 
 functionality overlaps; this only means that these features are on everyone 
 wishlist. I will be happy to help Ian and Franz get these patches upstream.
 
 I am not familiar with the review process at NM. If someone could help me to 
 get started, I will be much obliged.
 
 Yours,
 
 Bartoz

Yeah that would be ideal.  Franz and I have been working in a github repo here:

https://github.com/imain/notmuch-vim

There are a huge number of changes from what is in the notmuch tree though.
The idea of splitting out the patches and getting them in here is a bit
daunting but we could certainly try.  We also really wanted to refactor the
code but the pace has slowed now; probably because the client is very usable as
it is :).

Let me know what you think of the code base and if you are willing to help out
with merging the changes (lots of reviews I think mostly).

Ian

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[DRAFT] New features in Vim interface

2015-01-12 Thread David Bremner
Bartosz Telenczuk  writes:

>
> I am not familiar with the review process at NM. If someone could help me to 
> get started, I will be much obliged.
>

Sure.  We have tried to document the process at

   http://notmuchmail.org/contributing/

In particular  steps 14, 15

An example (hopefully not too daunting) of a recently review process is
at

id:1415147159-19946-1-git-send-email-sojkam1 at fel.cvut.cz

Tagging things in nmbug is really not the main issue; the main issue is
that we see on the list that a kind of "pair programming" happens and
people work through the patches together.

d


Re: [DRAFT] New features in Vim interface

2015-01-12 Thread Bartosz Telenczuk
Dear David, 
(CC Ian and Franz)

 Before Christmas we had a flurry of patches from Ian Main (in copy). I
 think there is some functionality overlap with what you proposed. As far
 as I know Ian has mainly been working on his private fork of the vim
 client, but maybe if the two (or three, including Franz) of you can work
 together to review each other's patches and polish things we can get
 some of these things upstream.

Thanks a lot for pointing me to Ian's patches. Indeed, some of the 
functionality overlaps; this only means that these features are on everyone 
wishlist. I will be happy to help Ian and Franz get these patches upstream.

I am not familiar with the review process at NM. If someone could help me to 
get started, I will be much obliged.

Yours,

Bartoz
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[DRAFT] New features in Vim interface

2015-01-11 Thread Bartosz Telenczuk
Dear David, 
(CC Ian and Franz)

> Before Christmas we had a flurry of patches from Ian Main (in copy). I
> think there is some functionality overlap with what you proposed. As far
> as I know Ian has mainly been working on his private fork of the vim
> client, but maybe if the two (or three, including Franz) of you can work
> together to review each other's patches and polish things we can get
> some of these things upstream.

Thanks a lot for pointing me to Ian's patches. Indeed, some of the 
functionality overlaps; this only means that these features are on everyone 
wishlist. I will be happy to help Ian and Franz get these patches upstream.

I am not familiar with the review process at NM. If someone could help me to 
get started, I will be much obliged.

Yours,

Bartoz


Re: [DRAFT] New features in Vim interface

2015-01-11 Thread David Bremner
Bartosz Telenczuk telenc...@unic.cnrs-gif.fr writes:


 I am not familiar with the review process at NM. If someone could help me to 
 get started, I will be much obliged.


Sure.  We have tried to document the process at

   http://notmuchmail.org/contributing/

In particular  steps 14, 15

An example (hopefully not too daunting) of a recently review process is
at

id:1415147159-19946-1-git-send-email-sojk...@fel.cvut.cz

Tagging things in nmbug is really not the main issue; the main issue is
that we see on the list that a kind of pair programming happens and
people work through the patches together.

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[DRAFT] New features in Vim interface

2015-01-10 Thread David Bremner
Bartosz  writes:

> Hi,
>
> I really like to use notmuch for organising my emails. However, I noticed 
> that vim interface is slightly lagging behind emacs. Some of the most 
> important features still missing are:
>
> - adding attachments (PATCH 4)
> - saving sent emails to "Sent" box in maildir (PATCH 3)
> - forwarding messages (not implemented yet)
> - folding read messages in thread view (PATCH 1 and 2)
>
> This patch series attempts to implement some of the features. It is
> not a finished product, but rather a prototype of the interface. If
> you consider it worthwhile I will try to polish the patches.

Before Christmas we had a flurry of patches from Ian Main (in copy). I
think there is some functionality overlap with what you proposed. As far
as I know Ian has mainly been working on his private fork of the vim
client, but maybe if the two (or three, including Franz) of you can work
together to review each other's patches and polish things we can get
some of these things upstream.

You have look at some of the existing vim patches under review at

http://nmbug.tethera.net/status/#Review



[DRAFT] New features in Vim interface

2015-01-10 Thread Bartosz
Hi,

I really like to use notmuch for organising my emails. However, I noticed that 
vim interface is slightly lagging behind emacs. Some of the most important 
features still missing are:

- adding attachments (PATCH 4)
- saving sent emails to "Sent" box in maildir (PATCH 3)
- forwarding messages (not implemented yet)
- folding read messages in thread view (PATCH 1 and 2)

This patch series attempts to implement some of the features. It is not a 
finished product, but rather a prototype of the interface. If you consider it 
worthwhile I will try to polish the patches.

[PATCH 1/4] VIM: implemented message folding in thread view

This patch automatically folds all read messages in thread view and jumps to 
the first unread message (if present). It uses vim folding mechanisms (based on 
syntax definition), so folds can be easily opened/closed.

[PATCH 2/4] VIM: move backward trough messages in thread mode

Currently, vim frontend allows to jump forward through messages in a thread 
using Tab key. This patch introduces Shift-Tab shortcut to move backwards. In 
addition, jumping to a new message automatically unfolds it.

[PATCH 3/4] VIM: save sent message to maildir

This patch uses "notmuch insert" for adding a message to a sent folder in mail 
archives after it is sent. The path to "sent" folder is configurable through 
.notmuch-config, by defining a section called [vim]. So far there is a single 
parameter in the section "sent_dirs" that should define a mapping between email 
addresses and folders. For example:

  [vim]
  sent_dirs=telenczb at hu-berlin.de=>HU/Sent;telenczuk at 
unic.cnrs-gif.fr=>CNRS/Sent

Email address is parsed from the "From" header of the sent email.

[PATCH 4/4] VIM: adding attachments

Paths to files to be attached should be listed as the final lines of the 
composed message and prefixed by "Attachment:" (one line per file). For example:

   

   

   Attachment: /home/bartosz/test.pdf
   Attachment: /home/bartosz/test.txt

I will be glad to hear your opinion about the design and implementation.

Yours,

Bartosz



[DRAFT] New features in Vim interface

2015-01-10 Thread Bartosz
Hi,

I really like to use notmuch for organising my emails. However, I noticed that 
vim interface is slightly lagging behind emacs. Some of the most important 
features still missing are:

- adding attachments (PATCH 4)
- saving sent emails to Sent box in maildir (PATCH 3)
- forwarding messages (not implemented yet)
- folding read messages in thread view (PATCH 1 and 2)

This patch series attempts to implement some of the features. It is not a 
finished product, but rather a prototype of the interface. If you consider it 
worthwhile I will try to polish the patches.

[PATCH 1/4] VIM: implemented message folding in thread view

This patch automatically folds all read messages in thread view and jumps to 
the first unread message (if present). It uses vim folding mechanisms (based on 
syntax definition), so folds can be easily opened/closed.

[PATCH 2/4] VIM: move backward trough messages in thread mode

Currently, vim frontend allows to jump forward through messages in a thread 
using Tab key. This patch introduces Shift-Tab shortcut to move backwards. In 
addition, jumping to a new message automatically unfolds it.

[PATCH 3/4] VIM: save sent message to maildir

This patch uses notmuch insert for adding a message to a sent folder in mail 
archives after it is sent. The path to sent folder is configurable through 
.notmuch-config, by defining a section called [vim]. So far there is a single 
parameter in the section sent_dirs that should define a mapping between email 
addresses and folders. For example:

  [vim]
  sent_dirs=telen...@hu-berlin.de=HU/Sent;telenc...@unic.cnrs-gif.fr=CNRS/Sent

Email address is parsed from the From header of the sent email.

[PATCH 4/4] VIM: adding attachments

Paths to files to be attached should be listed as the final lines of the 
composed message and prefixed by Attachment: (one line per file). For example:
   
   HEADER

   MESSAGE BODY

   Attachment: /home/bartosz/test.pdf
   Attachment: /home/bartosz/test.txt

I will be glad to hear your opinion about the design and implementation.

Yours,

Bartosz

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


Re: [DRAFT] New features in Vim interface

2015-01-10 Thread David Bremner
Bartosz telenc...@unic.cnrs-gif.fr writes:

 Hi,

 I really like to use notmuch for organising my emails. However, I noticed 
 that vim interface is slightly lagging behind emacs. Some of the most 
 important features still missing are:

 - adding attachments (PATCH 4)
 - saving sent emails to Sent box in maildir (PATCH 3)
 - forwarding messages (not implemented yet)
 - folding read messages in thread view (PATCH 1 and 2)

 This patch series attempts to implement some of the features. It is
 not a finished product, but rather a prototype of the interface. If
 you consider it worthwhile I will try to polish the patches.

Before Christmas we had a flurry of patches from Ian Main (in copy). I
think there is some functionality overlap with what you proposed. As far
as I know Ian has mainly been working on his private fork of the vim
client, but maybe if the two (or three, including Franz) of you can work
together to review each other's patches and polish things we can get
some of these things upstream.

You have look at some of the existing vim patches under review at

http://nmbug.tethera.net/status/#Review

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch