[LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx
David Bremner writes: > David Bremner writes: > >> Tomi Ollila writes: >> >>> In case we had doxygen but not sphinx notmuch.3 was created but >>> notmuch.3.gz not -- which means install fails! >>> This patch (with late night unpolished commit message will fix that) >> >> By install fails, you mean the man page is simply not installed? I agree >> that's a bug, but I had visions of the install failing half way through. > > A related issue I noticed is that some tests fail, rather than being > skipped, if the man pages are not built. Both my not understanding Tomi's report and my problem with failing tests where related to not running "make clean" after removing sphinx. So I think we can ignore this. Perhaps we should suggest people run "make clean" whenever they re-run configure, or something along those lines. d
Re: [LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx
David Bremner writes: > David Bremner writes: > >> Tomi Ollila writes: >> >>> In case we had doxygen but not sphinx notmuch.3 was created but >>> notmuch.3.gz not -- which means install fails! >>> This patch (with late night unpolished commit message will fix that) >> >> By install fails, you mean the man page is simply not installed? I agree >> that's a bug, but I had visions of the install failing half way through. > > A related issue I noticed is that some tests fail, rather than being > skipped, if the man pages are not built. Both my not understanding Tomi's report and my problem with failing tests where related to not running "make clean" after removing sphinx. So I think we can ignore this. Perhaps we should suggest people run "make clean" whenever they re-run configure, or something along those lines. d ___ notmuch mailing list [email protected] http://notmuchmail.org/mailman/listinfo/notmuch
[LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx
David Bremner writes: > Tomi Ollila writes: > >> In case we had doxygen but not sphinx notmuch.3 was created but >> notmuch.3.gz not -- which means install fails! >> This patch (with late night unpolished commit message will fix that) > > By install fails, you mean the man page is simply not installed? I agree > that's a bug, but I had visions of the install failing half way through. A related issue I noticed is that some tests fail, rather than being skipped, if the man pages are not built. d
[LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx
Tomi Ollila writes: > In case we had doxygen but not sphinx notmuch.3 was created but > notmuch.3.gz not -- which means install fails! > This patch (with late night unpolished commit message will fix that) By install fails, you mean the man page is simply not installed? I agree that's a bug, but I had visions of the install failing half way through. d
Re: [LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx
David Bremner writes: > Tomi Ollila writes: > >> In case we had doxygen but not sphinx notmuch.3 was created but >> notmuch.3.gz not -- which means install fails! >> This patch (with late night unpolished commit message will fix that) > > By install fails, you mean the man page is simply not installed? I agree > that's a bug, but I had visions of the install failing half way through. A related issue I noticed is that some tests fail, rather than being skipped, if the man pages are not built. d ___ notmuch mailing list [email protected] http://notmuchmail.org/mailman/listinfo/notmuch
Re: [LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx
Tomi Ollila writes: > In case we had doxygen but not sphinx notmuch.3 was created but > notmuch.3.gz not -- which means install fails! > This patch (with late night unpolished commit message will fix that) By install fails, you mean the man page is simply not installed? I agree that's a bug, but I had visions of the install failing half way through. d ___ notmuch mailing list [email protected] http://notmuchmail.org/mailman/listinfo/notmuch
[LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx
In case we had doxygen but not sphinx notmuch.3 was created but
notmuch.3.gz not -- which means install fails!
This patch (with late night unpolished commit message will fix that)
---
I'll do better one... hmm, next week (unless someone gets there first \o/)
doc/Makefile.local | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/doc/Makefile.local b/doc/Makefile.local
index 0bdf2e12fc0f..41cba607947d 100644
--- a/doc/Makefile.local
+++ b/doc/Makefile.local
@@ -32,7 +32,9 @@ sphinx-info: sphinx-texinfo
-include $(dir)/docdeps.mk
+ifeq ($(HAVE_SPHINX),1)
MAN_GZIP_FILES := $(addsuffix .gz,${MAN_ROFF_FILES})
+endif
# Use the man page converter that is available. We should never depend
# on MAN_ROFF_FILES if a converter is not available.
@@ -74,15 +76,14 @@ apidocs:
install-apidocs:
endif
-# Do not try to build or install man pages if a man page converter is
-# not available.
+build-man: ${MAN_GZIP_FILES}
+install-man: ${MAN_GZIP_FILES}
+
ifeq ($(HAVE_SPHINX),0)
-build-man:
install-man:
@echo "No sphinx, will not install man pages."
else
-build-man: ${MAN_GZIP_FILES}
-install-man: ${MAN_GZIP_FILES}
+install-man:
mkdir -p "$(DESTDIR)$(mandir)/man1"
mkdir -p "$(DESTDIR)$(mandir)/man5"
mkdir -p "$(DESTDIR)$(mandir)/man7"
--
2.0.0
[LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx
In case we had doxygen but not sphinx notmuch.3 was created but
notmuch.3.gz not -- which means install fails!
This patch (with late night unpolished commit message will fix that)
---
I'll do better one... hmm, next week (unless someone gets there first \o/)
doc/Makefile.local | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/doc/Makefile.local b/doc/Makefile.local
index 0bdf2e12fc0f..41cba607947d 100644
--- a/doc/Makefile.local
+++ b/doc/Makefile.local
@@ -32,7 +32,9 @@ sphinx-info: sphinx-texinfo
-include $(dir)/docdeps.mk
+ifeq ($(HAVE_SPHINX),1)
MAN_GZIP_FILES := $(addsuffix .gz,${MAN_ROFF_FILES})
+endif
# Use the man page converter that is available. We should never depend
# on MAN_ROFF_FILES if a converter is not available.
@@ -74,15 +76,14 @@ apidocs:
install-apidocs:
endif
-# Do not try to build or install man pages if a man page converter is
-# not available.
+build-man: ${MAN_GZIP_FILES}
+install-man: ${MAN_GZIP_FILES}
+
ifeq ($(HAVE_SPHINX),0)
-build-man:
install-man:
@echo "No sphinx, will not install man pages."
else
-build-man: ${MAN_GZIP_FILES}
-install-man: ${MAN_GZIP_FILES}
+install-man:
mkdir -p "$(DESTDIR)$(mandir)/man1"
mkdir -p "$(DESTDIR)$(mandir)/man5"
mkdir -p "$(DESTDIR)$(mandir)/man7"
--
2.0.0
___
notmuch mailing list
[email protected]
http://notmuchmail.org/mailman/listinfo/notmuch
