[PATCH] Fallback check for zlib.

2014-05-10 Thread David Bremner
X?c? writes: > --- > compat/have_zlib.c | 6 ++ > configure | 21 - > 2 files changed, 22 insertions(+), 5 deletions(-) > create mode 100644 compat/have_zlib.c If you're doing a second version for Tomi's comments, please put roughly the comments from the

[PATCH] Fallback check for zlib.

2014-05-10 Thread Tomi Ollila
On Sat, May 10 2014, David Bremner wrote: > X?c? writes: > >> --- >> compat/have_zlib.c | 6 ++ >> configure | 21 - >> 2 files changed, 22 insertions(+), 5 deletions(-) >> create mode 100644 compat/have_zlib.c > > If you're doing a second version for Tomi's

[PATCH] Fallback check for zlib.

2014-05-10 Thread Tomi Ollila
On Sat, May 10 2014, X?c? wrote: > --- I must say I like the patch. One thing I would change: +return (ZLIB_VERNUM) < (MINVER) || zlibVersion()[0] != (ZLIB_VERSION)[0]; i.e. short-circuiting potential failure before executing zlibVersion()... (parenthesising macros is just extra

Re: [PATCH] Fallback check for zlib.

2014-05-10 Thread Tomi Ollila
On Sat, May 10 2014, Xīcò x...@atelo.org wrote: --- I must say I like the patch. One thing I would change: +return (ZLIB_VERNUM) (MINVER) || zlibVersion()[0] != (ZLIB_VERSION)[0]; i.e. short-circuiting potential failure before executing zlibVersion()... (parenthesising macros is just

Re: [PATCH] Fallback check for zlib.

2014-05-10 Thread David Bremner
Xīcò x...@atelo.org writes: --- compat/have_zlib.c | 6 ++ configure | 21 - 2 files changed, 22 insertions(+), 5 deletions(-) create mode 100644 compat/have_zlib.c If you're doing a second version for Tomi's comments, please put roughly the comments from

Re: [PATCH] Fallback check for zlib.

2014-05-10 Thread Tomi Ollila
On Sat, May 10 2014, David Bremner da...@tethera.net wrote: Xīcò x...@atelo.org writes: --- compat/have_zlib.c | 6 ++ configure | 21 - 2 files changed, 22 insertions(+), 5 deletions(-) create mode 100644 compat/have_zlib.c If you're doing a second

[PATCH] Fallback check for zlib.

2014-05-09 Thread Xīcò
--- compat/have_zlib.c | 6 ++ configure | 21 - 2 files changed, 22 insertions(+), 5 deletions(-) create mode 100644 compat/have_zlib.c diff --git a/compat/have_zlib.c b/compat/have_zlib.c new file mode 100644 index 000..998c697 --- /dev/null +++

[PATCH] Fallback check for zlib

2014-05-09 Thread Xīcò
Added the fallback check for zlib. Tested on FreeBSD stable/10. C test checks for major zlib compatibility (see zlib doc/examples). X?c? (1): Fallback check for zlib. compat/have_zlib.c | 6 ++ configure | 21 - 2 files changed, 22 insertions(+), 5

[PATCH] Fallback check for zlib

2014-05-09 Thread Xīcò
Added the fallback check for zlib. Tested on FreeBSD stable/10. C test checks for major zlib compatibility (see zlib doc/examples). Xīcò (1): Fallback check for zlib. compat/have_zlib.c | 6 ++ configure | 21 - 2 files changed, 22 insertions(+), 5

[PATCH] Fallback check for zlib.

2014-05-09 Thread Xīcò
--- compat/have_zlib.c | 6 ++ configure | 21 - 2 files changed, 22 insertions(+), 5 deletions(-) create mode 100644 compat/have_zlib.c diff --git a/compat/have_zlib.c b/compat/have_zlib.c new file mode 100644 index 000..998c697 --- /dev/null +++