Re: [PATCH] Makefile.local: Fix LDFLAGS for notmuch-shared

[Carl Worth]

On Thu, 22 Apr 2010 23:04:30 -0400, Adrien Bustany  wrote:
> This commit adds GMIME_LDFLAGS and TALLOC_LDFLAGS to the linker flags
> when linking notmuch-shared. Without these flags, linking fails because
> of undefined symbols.

Hi Adrien,

What system are you using that has this problem? For Linux, at least,
those addition flags are not needed, (nor actually wanted). For other
systems, we know that these flags are needed, so we have a configure
check that tries to set LINKER_RESOLVES_LIBRARY_DEPENDENCIES=0 for these
systems.

So perhaps the correct fix here is to fix our configure script to set
that variable for your system.

Can you test if changing that variable to 0 in Makefile.config fixes
your build?

Thanks,

-Carl

-- 
carl.d.wo...@intel.com


pgpFzG1sJW93w.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] Makefile.local: Fix LDFLAGS for notmuch-shared

[Carl Worth]

On Thu, 22 Apr 2010 23:04:30 -0400, Adrien Bustany  
wrote:
> This commit adds GMIME_LDFLAGS and TALLOC_LDFLAGS to the linker flags
> when linking notmuch-shared. Without these flags, linking fails because
> of undefined symbols.

Hi Adrien,

What system are you using that has this problem? For Linux, at least,
those addition flags are not needed, (nor actually wanted). For other
systems, we know that these flags are needed, so we have a configure
check that tries to set LINKER_RESOLVES_LIBRARY_DEPENDENCIES=0 for these
systems.

So perhaps the correct fix here is to fix our configure script to set
that variable for your system.

Can you test if changing that variable to 0 in Makefile.config fixes
your build?

Thanks,

-Carl

-- 
carl.d.worth at intel.com
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 

[PATCH] Makefile.local: Fix LDFLAGS for notmuch-shared

[Adrien Bustany]

This commit adds GMIME_LDFLAGS and TALLOC_LDFLAGS to the linker flags
when linking notmuch-shared. Without these flags, linking fails because
of undefined symbols.
---
 Makefile.local |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.local b/Makefile.local
index 5bb570b..37dd745 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -31,7 +31,7 @@ GPG_FILE=$(SHA1_FILE).asc
 # Smash together user's values with our extra values
 FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CFLAGS) $(WARN_CFLAGS) 
$(CONFIGURE_CFLAGS) $(extra_cflags)
 FINAL_CXXFLAGS = $(CXXFLAGS) $(WARN_CXXFLAGS) $(CONFIGURE_CXXFLAGS) 
$(extra_cflags) $(extra_cxxflags)
-FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch
+FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) $(GMIME_LDFLAGS) $(TALLOC_LDFLAGS) -Llib 
-lnotmuch
 FINAL_NOTMUCH_LINKER = CC
 ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1)
 FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS)
-- 
1.7.0.1

[PATCH] Makefile.local: Fix LDFLAGS for notmuch-shared

[Adrien Bustany]

This commit adds GMIME_LDFLAGS and TALLOC_LDFLAGS to the linker flags
when linking notmuch-shared. Without these flags, linking fails because
of undefined symbols.
---
 Makefile.local |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.local b/Makefile.local
index 5bb570b..37dd745 100644
--- a/Makefile.local
+++ b/Makefile.local
@@ -31,7 +31,7 @@ GPG_FILE=$(SHA1_FILE).asc
 # Smash together user's values with our extra values
 FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CFLAGS) $(WARN_CFLAGS) 
$(CONFIGURE_CFLAGS) $(extra_cflags)
 FINAL_CXXFLAGS = $(CXXFLAGS) $(WARN_CXXFLAGS) $(CONFIGURE_CXXFLAGS) 
$(extra_cflags) $(extra_cxxflags)
-FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch
+FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) $(GMIME_LDFLAGS) $(TALLOC_LDFLAGS) -Llib 
-lnotmuch
 FINAL_NOTMUCH_LINKER = CC
 ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1)
 FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS)
-- 
1.7.0.1

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch