Re: [PATCH] devel: two scripts for checking proposed changes

2021-07-23 Thread Tomi Ollila
On Tue, Jun 29 2021, David Bremner wrote: > Tomi Ollila writes: > >>> + >>> +set -e >>> +make test >> >> This may fail miserably (or is painfully slow (doing configure and make...) >> > > At least for my use case, running the tests for each commit is the main > point. The formatting stuff is nice

Re: [PATCH] devel: two scripts for checking proposed changes

2021-06-29 Thread David Bremner
Tomi Ollila writes: >> + >> +set -e >> +make test > > This may fail miserably (or is painfully slow (doing configure and make...) > At least for my use case, running the tests for each commit is the main point. The formatting stuff is nice to have, but only if the tests run. I could invoke the n

Re: [PATCH] devel: two scripts for checking proposed changes

2021-06-28 Thread Tomi Ollila
On Mon, Jun 28 2021, David Bremner wrote: > It took me a bit of effort to get the correct oneliner to reindent > elisp from the command line, so I saved the results as > 'reindent-elisp'. > > 'check-notmuch-commit' is an updated version of a script I have been > using (although not always as consi

[PATCH] devel: two scripts for checking proposed changes

2021-06-28 Thread David Bremner
It took me a bit of effort to get the correct oneliner to reindent elisp from the command line, so I saved the results as 'reindent-elisp'. 'check-notmuch-commit' is an updated version of a script I have been using (although not always as consistently as I should) before sending patches to the lis