David Bremner writes:
> To apply patch series, you may want to try mailscripts [1]. The
> description makes it sound debian-centric, but I guess the elisp
> functions like notmuch-extract-thread-patches are portable.
That function is one reason why it's nice to start a new thread with
each
Mohsin Kaleem writes:
>
> I'm not sure what you mean by the first two patches occur twice, could
> you clarify so I can fix the issue? I've dropped the reverted patch and
> rebased on top of master so you shouldn't have any issues applying the
> patch series now.
>
For reference, just look at
David Bremner writes:
Hi, thanks for all the advice :-). I'm still quite unfamiliar with
mailing-list based workflows so I keep developing like I'm on GitHub.
> I think the patch series needs a bit of cleanup still. The first two
> patches occur twice and then a later patch is reverted (so
Mohsin Kaleem writes:
> David Bremner writes:
>
> Hi, firstly sorry for taking so long to come back to this. I honestly
> have tried to fix this multiple times since my last message but kept
> getting confused or misdirected by how the tests are setup so I gave up
> and decided to come back to
David Bremner writes:
Hi, firstly sorry for taking so long to come back to this. I honestly
have tried to fix this multiple times since my last message but kept
getting confused or misdirected by how the tests are setup so I gave up
and decided to come back to it later. Today I finally just sped
Mohsin Kaleem writes:
> David Bremner writes:
>
>> Try adding a line
>> "unset XDG_DATA_HOME"
>>
>> after
>>
>> unset XDG_CONFIG_HOME
>>
>> on line 108 of test/test-lib.sh
>
> Doesn't seem to be such a line in test/test-lib.sh, but I added it to
> test/test-vars.sh and we're down from 42
David Bremner writes:
> Try adding a line
> "unset XDG_DATA_HOME"
>
> after
>
> unset XDG_CONFIG_HOME
>
> on line 108 of test/test-lib.sh
Doesn't seem to be such a line in test/test-lib.sh, but I added it to
test/test-vars.sh and we're down from 42 failing tests to 4 :-).
Missing sphinx or
Mohsin Kaleem writes:
> David Bremner writes:
>
>> It's just a guess, but do you by chance override XDG_DATA_HOME? I can
>> imagine that causing problems for the test suite.
>
> I do export an environment variable $XDG_DATA_HOME, but it points to the
> default location
David Bremner writes:
> It's just a guess, but do you by chance override XDG_DATA_HOME? I can
> imagine that causing problems for the test suite.
I do export an environment variable $XDG_DATA_HOME, but it points to the
default location "/home/mohkale/.local/share" so I'm not sure why that
would
Mohsin Kaleem writes:
> David Bremner writes:
>
>> Can you be more specific about what tests are failing?
>
> Pretty much all of them, although I'm beginning to suspect it may be an
> environment issue on my part.
>
> I've attached the output of running `make test` in the root of the
> project
David Bremner writes:
> Can you be more specific about what tests are failing?
Pretty much all of them, although I'm beginning to suspect it may be an
environment issue on my part.
I've attached the output of running `make test` in the root of the
project from master, do you have any idea why
Mohsin Kaleem writes:
>
> I'm more than happy to add some new tests but at least for me the test
> suite appears to be failing on the master branch. I think it'd be easier
> to wait until the existing tests are fixed before adding or changing new
> ones.
>
Can you be more specific about what
David Bremner writes:
> Can you update the file devel/emacs-keybindings.org so we don't lose
> track of the bindings. Also, per the contributing guide [1], please
> add some brief documentation to the emacs docs in
> doc/notmuch-emacs.rst
Done.
> Also, we need at least one new test (ideally
Mohsin Kaleem writes:
> The new notmuch-search-exclude option allows users to configure whether
> to show or hide excluded messages (as determined by search.exclude_tags
> in the local config file). It defaults to true for now to maintain
> backwards-compatibility with how notmuch-{search,tree}
The new notmuch-search-exclude option allows users to configure whether
to show or hide excluded messages (as determined by search.exclude_tags
in the local config file). It defaults to true for now to maintain
backwards-compatibility with how notmuch-{search,tree} already worked.
New commands
15 matches
Mail list logo
