Re: [PATCH] index: explicitly follow GObject conventions

2018-10-21 Thread David Bremner
Daniel Kahn Gillmor writes: > Use explicit labels for GTypeInfo member initializers, rather than > relying on comments and ordering. This is both easier to read, and > harder to screw up. This also makes it clear that we're mis-casting > GObject class initializers for gcc. > > Without this patc

[PATCH] index: explicitly follow GObject conventions

2018-10-06 Thread Daniel Kahn Gillmor
Use explicit labels for GTypeInfo member initializers, rather than relying on comments and ordering. This is both easier to read, and harder to screw up. This also makes it clear that we're mis-casting GObject class initializers for gcc. Without this patch, g++ 8.2.0-7 produces this warning: CX