[PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

2012-01-12 Thread Austin Clements
Quoth Tomi Ollila on Jan 12 at 10:51 am: > On Wed, 11 Jan 2012 23:13:44 -0500, Austin Clements > wrote: > > This is important to fix, but this solution seems needlessly > > roundabout. What about using an after-advice and simply delq'ing > > whatever the offending hook is? That wouldn't even

[PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

2012-01-12 Thread Tomi Ollila
On Wed, 11 Jan 2012 23:13:44 -0500, Austin Clements wrote: > This is important to fix, but this solution seems needlessly > roundabout. What about using an after-advice and simply delq'ing > whatever the offending hook is? That wouldn't even need a version > check. delq could work -- thanks

Re: [PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

2012-01-12 Thread Tomi Ollila
On Wed, 11 Jan 2012 23:13:44 -0500, Austin Clements amdra...@mit.edu wrote: This is important to fix, but this solution seems needlessly roundabout. What about using an after-advice and simply delq'ing whatever the offending hook is? That wouldn't even need a version check. delq could work

Re: [PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

2012-01-12 Thread Austin Clements
Quoth Tomi Ollila on Jan 12 at 10:51 am: On Wed, 11 Jan 2012 23:13:44 -0500, Austin Clements amdra...@mit.edu wrote: This is important to fix, but this solution seems needlessly roundabout. What about using an after-advice and simply delq'ing whatever the offending hook is? That wouldn't

[PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

2012-01-11 Thread Austin Clements
This is important to fix, but this solution seems needlessly roundabout. What about using an after-advice and simply delq'ing whatever the offending hook is? That wouldn't even need a version check. Quoth Tomi Ollila on Jan 11 at 4:49 pm: > emacsclient --eval '(kill-emacs)' doesn't work

[PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

2012-01-11 Thread Tomi Ollila
emacsclient --eval '(kill-emacs)' doesn't work without interactive user input. By removing the hook which asks user input makes things work well enough in our test cases. --- test/test-lib.el | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/test/test-lib.el

[PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

2012-01-11 Thread Tomi Ollila
emacsclient --eval '(kill-emacs)' doesn't work without interactive user input. By removing the hook which asks user input makes things work well enough in our test cases. --- test/test-lib.el | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/test/test-lib.el

Re: [PATCH] make (kill-emacs) from emacsclient work with emacs 23.(1|2)

2012-01-11 Thread Austin Clements
This is important to fix, but this solution seems needlessly roundabout. What about using an after-advice and simply delq'ing whatever the offending hook is? That wouldn't even need a version check. Quoth Tomi Ollila on Jan 11 at 4:49 pm: emacsclient --eval '(kill-emacs)' doesn't work without