On Mon, 09 May 2011 09:20:41 -0300, David Bremner wrote:
> On Mon, 9 May 2011 09:06:34 +0200, Anton Khirnov
> wrote:
> > Now None is returned when those don't exist, which is inconvenient to
> > deal with.
>
> I'm not using the python bindings, but from a philosophical point of
> view, this ch
On 05/09/2011 09:00 PM, Sebastian Spaeth wrote:
> On Mon, 09 May 2011 09:20:41 -0300, David Bremner
> wrote:
>> On Mon, 9 May 2011 09:06:34 +0200, Anton Khirnov
>> wrote:
>>> Now None is returned when those don't exist, which is inconvenient to
>>> deal with.
>>
>> I'm not using the python bin
On 05/09/2011 09:00 PM, Sebastian Spaeth wrote:
> On Mon, 09 May 2011 09:20:41 -0300, David Bremner wrote:
>> On Mon, 9 May 2011 09:06:34 +0200, Anton Khirnov wrote:
>>> Now None is returned when those don't exist, which is inconvenient to
>>> deal with.
>>
>> I'm not using the python bindings,
On Mon, 09 May 2011 09:20:41 -0300, David Bremner wrote:
> On Mon, 9 May 2011 09:06:34 +0200, Anton Khirnov wrote:
> > Now None is returned when those don't exist, which is inconvenient to
> > deal with.
>
> I'm not using the python bindings, but from a philosophical point of
> view, this chang
On Mon, 09 May 2011 09:20:41 -0300, David Bremner wrote:
> On Mon, 9 May 2011 09:06:34 +0200, Anton Khirnov
> wrote:
> > Now None is returned when those don't exist, which is inconvenient to
> > deal with.
>
> I'm not using the python bindings, but from a philosophical point of
> view, this ch
On Mon, 09 May 2011 11:23:16 -0400, Jesse Rosenthal
wrote:
> The RFC says yes on the author, no on the subject. The only things
> guaranteed are "From:" and originating timestamp. So I'm not sure why
> subject should be guaranteed a string result and not, say, "Cc."
Apologies -- I realize now
On Mon, 09 May 2011 17:13:10 +0200, Anton Khirnov wrote:
> But those aren't message headers, those are thread properties. And I'd
> argue that a thread always has authors and a subject (possibly empty).
The RFC says yes on the author, no on the subject. The only things
guaranteed are "From:" and
On Mon, 9 May 2011 09:06:34 +0200, Anton Khirnov wrote:
> Now None is returned when those don't exist, which is inconvenient to
> deal with.
I'm not using the python bindings, but from a philosophical point of
view, this change makes me a bit uncomfortable since it apparently
merges two cases to
Now None is returned when those don't exist, which is inconvenient to
deal with.
---
bindings/python/notmuch/thread.py |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/bindings/python/notmuch/thread.py
b/bindings/python/notmuch/thread.py
index eebd6cb..cf26957 100644
On 9 May 2011 08:20, David Bremner wrote:
> On Mon, ?9 May 2011 09:06:34 +0200, Anton Khirnov
> wrote:
>> Now None is returned when those don't exist, which is inconvenient to
>> deal with.
>
> I'm not using the python bindings, but from a philosophical point of
> view, this change makes me a bi
On Mon, 09 May 2011 11:23:16 -0400, Jesse Rosenthal wrote:
> The RFC says yes on the author, no on the subject. The only things
> guaranteed are "From:" and originating timestamp. So I'm not sure why
> subject should be guaranteed a string result and not, say, "Cc."
Apologies -- I realize now y
On Mon, 09 May 2011 17:13:10 +0200, Anton Khirnov wrote:
> But those aren't message headers, those are thread properties. And I'd
> argue that a thread always has authors and a subject (possibly empty).
The RFC says yes on the author, no on the subject. The only things
guaranteed are "From:" and
On Mon, 09 May 2011 09:20:41 -0300, David Bremner wrote:
> On Mon, 9 May 2011 09:06:34 +0200, Anton Khirnov wrote:
> > Now None is returned when those don't exist, which is inconvenient to
> > deal with.
>
> I'm not using the python bindings, but from a philosophical point of
> view, this chang
Your commit message is inconsistent with your change; is your intent to
return None or the empty string? Also, could you modify your commit message
to say what "those" are?
On May 9, 2011 3:06 AM, "Anton Khirnov" wrote:
-- next part --
An HTML attachment was scrubbed...
UR
On 9 May 2011 08:20, David Bremner wrote:
> On Mon, 9 May 2011 09:06:34 +0200, Anton Khirnov wrote:
>> Now None is returned when those don't exist, which is inconvenient to
>> deal with.
>
> I'm not using the python bindings, but from a philosophical point of
> view, this change makes me a bit u
On Mon, 9 May 2011 09:06:34 +0200, Anton Khirnov wrote:
> Now None is returned when those don't exist, which is inconvenient to
> deal with.
I'm not using the python bindings, but from a philosophical point of
view, this change makes me a bit uncomfortable since it apparently
merges two cases to
Your commit message is inconsistent with your change; is your intent to
return None or the empty string? Also, could you modify your commit message
to say what "those" are?
On May 9, 2011 3:06 AM, "Anton Khirnov" wrote:
___
notmuch mailing list
notmuch@
Now None is returned when those don't exist, which is inconvenient to
deal with.
---
bindings/python/notmuch/thread.py |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/bindings/python/notmuch/thread.py
b/bindings/python/notmuch/thread.py
index eebd6cb..cf26957 100644
18 matches
Mail list logo