[PATCH] test: Simplify CLEAN list construction
On Tue, Feb 25 2014, Austin Clements wrote: > Construct as much of the CLEAN list from TEST_BINARIES as possible, > rather than duplicating this information by hand. > --- LGTM. database-test.c is a "library" Tomi > test/Makefile.local | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/test/Makefile.local b/test/Makefile.local > index 8870ca3..99324ba 100644 > --- a/test/Makefile.local > +++ b/test/Makefile.local > @@ -50,11 +50,6 @@ test: all test-binaries > check: test > > SRCS := $(SRCS) $(smtp_dummy_srcs) > -CLEAN := $(CLEAN) $(dir)/smtp-dummy $(dir)/smtp-dummy.o \ > - $(dir)/symbol-test $(dir)/symbol-test.o \ > - $(dir)/arg-test $(dir)/arg-test.o \ > - $(dir)/hex-xcode $(dir)/hex-xcode.o \ > +CLEAN += $(TEST_BINARIES) $(addsuffix .o,$(TEST_BINARIES)) \ >$(dir)/database-test.o \ > - $(dir)/random-corpus $(dir)/random-corpus.o \ > - $(dir)/parse-time $(dir)/parse-time.o \ >$(dir)/corpus.mail $(dir)/test-results $(dir)/tmp.* > -- > 1.8.4.rc3 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] test: Simplify CLEAN list construction
Austin Clements writes: > Construct as much of the CLEAN list from TEST_BINARIES as possible, > rather than duplicating this information by hand. pushed, d
[PATCH] test: Simplify CLEAN list construction
Construct as much of the CLEAN list from TEST_BINARIES as possible, rather than duplicating this information by hand. --- test/Makefile.local | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test/Makefile.local b/test/Makefile.local index 8870ca3..99324ba 100644 --- a/test/Makefile.local +++ b/test/Makefile.local @@ -50,11 +50,6 @@ test:all test-binaries check: test SRCS := $(SRCS) $(smtp_dummy_srcs) -CLEAN := $(CLEAN) $(dir)/smtp-dummy $(dir)/smtp-dummy.o \ -$(dir)/symbol-test $(dir)/symbol-test.o \ -$(dir)/arg-test $(dir)/arg-test.o \ -$(dir)/hex-xcode $(dir)/hex-xcode.o \ +CLEAN += $(TEST_BINARIES) $(addsuffix .o,$(TEST_BINARIES)) \ $(dir)/database-test.o \ -$(dir)/random-corpus $(dir)/random-corpus.o \ -$(dir)/parse-time $(dir)/parse-time.o \ $(dir)/corpus.mail $(dir)/test-results $(dir)/tmp.* -- 1.8.4.rc3
[PATCH] test: Simplify CLEAN list construction
Construct as much of the CLEAN list from TEST_BINARIES as possible, rather than duplicating this information by hand. --- test/Makefile.local | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test/Makefile.local b/test/Makefile.local index 8870ca3..99324ba 100644 --- a/test/Makefile.local +++ b/test/Makefile.local @@ -50,11 +50,6 @@ test:all test-binaries check: test SRCS := $(SRCS) $(smtp_dummy_srcs) -CLEAN := $(CLEAN) $(dir)/smtp-dummy $(dir)/smtp-dummy.o \ -$(dir)/symbol-test $(dir)/symbol-test.o \ -$(dir)/arg-test $(dir)/arg-test.o \ -$(dir)/hex-xcode $(dir)/hex-xcode.o \ +CLEAN += $(TEST_BINARIES) $(addsuffix .o,$(TEST_BINARIES)) \ $(dir)/database-test.o \ -$(dir)/random-corpus $(dir)/random-corpus.o \ -$(dir)/parse-time $(dir)/parse-time.o \ $(dir)/corpus.mail $(dir)/test-results $(dir)/tmp.* -- 1.8.4.rc3 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] test: Simplify CLEAN list construction
On Tue, Feb 25 2014, Austin Clements amdra...@mit.edu wrote: Construct as much of the CLEAN list from TEST_BINARIES as possible, rather than duplicating this information by hand. --- LGTM. database-test.c is a library Tomi test/Makefile.local | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test/Makefile.local b/test/Makefile.local index 8870ca3..99324ba 100644 --- a/test/Makefile.local +++ b/test/Makefile.local @@ -50,11 +50,6 @@ test: all test-binaries check: test SRCS := $(SRCS) $(smtp_dummy_srcs) -CLEAN := $(CLEAN) $(dir)/smtp-dummy $(dir)/smtp-dummy.o \ - $(dir)/symbol-test $(dir)/symbol-test.o \ - $(dir)/arg-test $(dir)/arg-test.o \ - $(dir)/hex-xcode $(dir)/hex-xcode.o \ +CLEAN += $(TEST_BINARIES) $(addsuffix .o,$(TEST_BINARIES)) \ $(dir)/database-test.o \ - $(dir)/random-corpus $(dir)/random-corpus.o \ - $(dir)/parse-time $(dir)/parse-time.o \ $(dir)/corpus.mail $(dir)/test-results $(dir)/tmp.* -- 1.8.4.rc3 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] test: Simplify CLEAN list construction
Austin Clements amdra...@mit.edu writes: Construct as much of the CLEAN list from TEST_BINARIES as possible, rather than duplicating this information by hand. pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
