Re: [PATCH] test: aggregate-results.sh: count test files where all tests skipped

2019-07-10 Thread David Bremner
Tomi Ollila  writes:

> Previously, when all tests were skipped on a test file, there were
> no indication of this in the final results aggregate-results.sh
> printed.
> Now count of the files where all tests were skipped is printed.

pushed

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH] test: aggregate-results.sh: count test files where all tests skipped

2019-07-02 Thread Daniel Kahn Gillmor
On Sat 2019-06-15 17:28:44 +0300, Tomi Ollila wrote:
> Previously, when all tests were skipped on a test file, there were
> no indication of this in the final results aggregate-results.sh
> printed.
> Now count of the files where all tests were skipped is printed.

LGTM.  thanks for proposing this, Tomi.

   --dkg


signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


[PATCH] test: aggregate-results.sh: count test files where all tests skipped

2019-06-15 Thread Tomi Ollila
Previously, when all tests were skipped on a test file, there were
no indication of this in the final results aggregate-results.sh
printed.
Now count of the files where all tests were skipped is printed.
---
 test/aggregate-results.sh | 10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/test/aggregate-results.sh b/test/aggregate-results.sh
index 05fb0a92..75400e6e 100755
--- a/test/aggregate-results.sh
+++ b/test/aggregate-results.sh
@@ -7,6 +7,7 @@ success=0
 failed=0
 broken=0
 total=0
+all_skipped=0
 
 for file
 do
@@ -22,7 +23,10 @@ do
broken)
broken=$((broken + value)) ;;
total)
-   total=$((total + value)) ;;
+   total=$((total + value))
+   if [ "$value" -eq 0 ]; then
+   all_skipped=$((all_skipped + 1))
+   fi
esac
done <"$file"
 done
@@ -61,6 +65,10 @@ if [ "$skipped" -ne 0 ]; then
pluralize_s "$skipped"
echo "$skipped test$s skipped."
 fi
+if [ "$all_skipped" -ne 0 ]; then
+   pluralize_s "$all_skipped"
+   echo "All tests in $all_skipped file$s skipped."
+fi
 
 # Note that we currently do not consider skipped tests as failing the
 # build.
-- 
2.21.0

___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch