Re: [PATCH] zlib-related bugs

2020-04-13 Thread Tomi Ollila
On Fri, Apr 10 2020, Olivier Taïbi wrote: > the following diff addresses 3 zlib-related bugs in notmuch. > 3) in gz_getline(), if gz_error sets its second argument to Z_STREAM_END >then there was no error (only EOF). Unfortunately the zlib manual is >not very clear on the meaning of

Re: [PATCH] zlib-related bugs

2020-04-13 Thread David Bremner
Olivier Taïbi writes: Thanks for the mail. In general we need each change in a separate patch for review. Being zlib related is not really close enough for us. > the following diff addresses 3 zlib-related bugs in notmuch. > 1) the second argument of gzerror() cannot be NULL, so replace it by a

[PATCH] zlib-related bugs

2020-04-12 Thread Olivier Taïbi
the following diff addresses 3 zlib-related bugs in notmuch. 1) the second argument of gzerror() cannot be NULL, so replace it by a dummy 2) gzerror() cannot be closed after gzclosed(), so just print the error value instead. 3) in gz_getline(), if gz_error sets its second argument to