[PATCH 0/2] emacs: show: use interactive instead of current-prefix-arg

2013-10-10 Thread Tomi Ollila
On Wed, Oct 09 2013, Mark Walters  wrote:

> This is a tidied up version of the patch at
> id:1380729013-3942-1-git-send-email-markwalters1009 at gmail.com
> (incorporating suggestions from Tomi in
> id:m2siwjhapc.fsf at guru.guru-group.fi)
>
> This helps fix a problem in pick but there was reasonable agreement on
> irc that show should not be looking at current-prefix-arg directly.
>
> One test needs to be changed to the new behaviour.

LGTM. Having elide-toggle &optional looks like a very good idea!

Tomi

>
> Best wishes
>
> Mark
>
>
> Mark Walters (2):
>   emacs: show: use interactive instead of current-prefix-arg
>   test: emacs-show: fix use of prefix-arg
>
>  emacs/notmuch-show.el |   12 +++-
>  emacs/notmuch.el  |5 +++--
>  test/emacs-show   |3 +--
>  3 files changed, 11 insertions(+), 9 deletions(-)
>
> -- 
> 1.7.9.1
>
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH 0/2] emacs: show: use interactive instead of current-prefix-arg

2013-10-10 Thread Tomi Ollila
On Wed, Oct 09 2013, Mark Walters  wrote:

> This is a tidied up version of the patch at
> id:1380729013-3942-1-git-send-email-markwalters1...@gmail.com
> (incorporating suggestions from Tomi in
> id:m2siwjhapc@guru.guru-group.fi)
>
> This helps fix a problem in pick but there was reasonable agreement on
> irc that show should not be looking at current-prefix-arg directly.
>
> One test needs to be changed to the new behaviour.

LGTM. Having elide-toggle &optional looks like a very good idea!

Tomi

>
> Best wishes
>
> Mark
>
>
> Mark Walters (2):
>   emacs: show: use interactive instead of current-prefix-arg
>   test: emacs-show: fix use of prefix-arg
>
>  emacs/notmuch-show.el |   12 +++-
>  emacs/notmuch.el  |5 +++--
>  test/emacs-show   |3 +--
>  3 files changed, 11 insertions(+), 9 deletions(-)
>
> -- 
> 1.7.9.1
>
> ___
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[PATCH 0/2] emacs: show: use interactive instead of current-prefix-arg

2013-10-09 Thread Mark Walters
This is a tidied up version of the patch at
id:1380729013-3942-1-git-send-email-markwalters1009 at gmail.com
(incorporating suggestions from Tomi in
id:m2siwjhapc.fsf at guru.guru-group.fi)

This helps fix a problem in pick but there was reasonable agreement on
irc that show should not be looking at current-prefix-arg directly.

One test needs to be changed to the new behaviour.

Best wishes

Mark


Mark Walters (2):
  emacs: show: use interactive instead of current-prefix-arg
  test: emacs-show: fix use of prefix-arg

 emacs/notmuch-show.el |   12 +++-
 emacs/notmuch.el  |5 +++--
 test/emacs-show   |3 +--
 3 files changed, 11 insertions(+), 9 deletions(-)

-- 
1.7.9.1



[PATCH 0/2] emacs: show: use interactive instead of current-prefix-arg

2013-10-09 Thread Mark Walters
This is a tidied up version of the patch at
id:1380729013-3942-1-git-send-email-markwalters1...@gmail.com
(incorporating suggestions from Tomi in
id:m2siwjhapc@guru.guru-group.fi)

This helps fix a problem in pick but there was reasonable agreement on
irc that show should not be looking at current-prefix-arg directly.

One test needs to be changed to the new behaviour.

Best wishes

Mark


Mark Walters (2):
  emacs: show: use interactive instead of current-prefix-arg
  test: emacs-show: fix use of prefix-arg

 emacs/notmuch-show.el |   12 +++-
 emacs/notmuch.el  |5 +++--
 test/emacs-show   |3 +--
 3 files changed, 11 insertions(+), 9 deletions(-)

-- 
1.7.9.1

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch