Re: [PATCH 1/2] make _alloc_notmuch static

[David Bremner]

Tomi Ollila  writes:

>
> could also add static to _maybe_load_config_from_database()
> in the same file (open.cc) and to
> _notmuch_message_remove_indexed_terms() in message.cc

applied to master, with all 3 made static

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH 1/2] make _alloc_notmuch static

[Tomi Ollila]

On Sun, May 23 2021, David Bremner wrote:

> It is not used outside this file, so being extern seems like an oversight
> ---
>  lib/open.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/open.cc b/lib/open.cc
> index 1ca69665..bf166e15 100644
> --- a/lib/open.cc
> +++ b/lib/open.cc
> @@ -242,7 +242,7 @@ _choose_database_path (void *ctx,
>  return NOTMUCH_STATUS_SUCCESS;
>  }
>  
> -notmuch_database_t *
> +static notmuch_database_t *
>  _alloc_notmuch ()
>  {
>  notmuch_database_t *notmuch;

could also add static to _maybe_load_config_from_database()
in the same file (open.cc) and to
_notmuch_message_remove_indexed_terms() in message.cc
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org

[PATCH 1/2] make _alloc_notmuch static

[David Bremner]

It is not used outside this file, so being extern seems like an oversight
---
 lib/open.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/open.cc b/lib/open.cc
index 1ca69665..bf166e15 100644
--- a/lib/open.cc
+++ b/lib/open.cc
@@ -242,7 +242,7 @@ _choose_database_path (void *ctx,
 return NOTMUCH_STATUS_SUCCESS;
 }
 
-notmuch_database_t *
+static notmuch_database_t *
 _alloc_notmuch ()
 {
 notmuch_database_t *notmuch;
-- 
2.30.2
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org