Re: [PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts

2021-08-30 Thread David Bremner
David Bremner writes: > Tomi Ollila writes: > >> In this case one could just do >> >> test_expect_code 1 "fgrep -q '!!!' OUTPUT" >> >> (these file comparisons w/ /dev/null (currently 5) annoys me ;/ >> so if I am biased the current suggestion is fine) > > Sure, I've adopted your suggestion in

Re: [PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts

2021-07-04 Thread David Bremner
Tomi Ollila writes: > In this case one could just do > > test_expect_code 1 "fgrep -q '!!!' OUTPUT" > > (these file comparisons w/ /dev/null (currently 5) annoys me ;/ > so if I am biased the current suggestion is fine) Sure, I've adopted your suggestion in git d _

Re: [PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts

2021-07-04 Thread Tomi Ollila
On Sat, Jul 03 2021, David Bremner wrote: > There are at least 3 bugs present. > > 1) notmuch-show-insert-part-message/rfc822 assumes that message/rfc822 > parts will have a ":content" property, but that turns out not to be > the case. > > 2) something deep in gnus wants gnus-newsgroup-charset, bu

[PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts

2021-07-03 Thread David Bremner
There are at least 3 bugs present. 1) notmuch-show-insert-part-message/rfc822 assumes that message/rfc822 parts will have a ":content" property, but that turns out not to be the case. 2) something deep in gnus wants gnus-newsgroup-charset, but that is defined in gnus-sum, which is not loaded by d