Re: [PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts
David Bremner writes: > Tomi Ollila writes: > >> In this case one could just do >> >> test_expect_code 1 "fgrep -q '!!!' OUTPUT" >> >> (these file comparisons w/ /dev/null (currently 5) annoys me ;/ >> so if I am biased the current suggestion is fine) > > Sure, I've adopted your suggestion in git > > d and applied that version to master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts
Tomi Ollila writes: > In this case one could just do > > test_expect_code 1 "fgrep -q '!!!' OUTPUT" > > (these file comparisons w/ /dev/null (currently 5) annoys me ;/ > so if I am biased the current suggestion is fine) Sure, I've adopted your suggestion in git d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts
On Sat, Jul 03 2021, David Bremner wrote: > There are at least 3 bugs present. > > 1) notmuch-show-insert-part-message/rfc822 assumes that message/rfc822 > parts will have a ":content" property, but that turns out not to be > the case. > > 2) something deep in gnus wants gnus-newsgroup-charset, but that is > defined in gnus-sum, which is not loaded by default. > > 3) If gnus-sum is loaded, then the display of the message/rfc822 part > succeeds, but the buffer gets put into gnus-article-mode, which means > that, inter alia, notmuch text properties and keybindings get wiped. > --- > test/T450-emacs-show.sh | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh > index 9d08d2cc..bf7c1fe0 100755 > --- a/test/T450-emacs-show.sh > +++ b/test/T450-emacs-show.sh > @@ -219,6 +219,13 @@ test_emacs '(notmuch-show > "id:basic-encryp...@crypto.notmuchmail.org") > (test-visible-output)' > test_expect_equal_file $EXPECTED/notmuch-show-decrypted-message OUTPUT > > +test_begin_subtest "show encrypted rfc822 message" > +test_subtest_known_broken > +test_emacs '(notmuch-show > "id:encrypted-rfc822-attachm...@crypto.notmuchmail.org") > +(test-visible-output)' > +fgrep '!!!' OUTPUT > OUTPUT.err > +test_expect_equal_file /dev/null OUTPUT.err In this case one could just do test_expect_code 1 "fgrep -q '!!!' OUTPUT" (these file comparisons w/ /dev/null (currently 5) annoys me ;/ so if I am biased the current suggestion is fine) Tomi > + > test_begin_subtest "show undecryptable message" > test_emacs '(notmuch-show "id:simple-encryp...@crypto.notmuchmail.org") > (test-visible-output)' > -- > 2.30.2 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH 2/2] test: known broken test for emacs display of message/rfc822 parts
There are at least 3 bugs present. 1) notmuch-show-insert-part-message/rfc822 assumes that message/rfc822 parts will have a ":content" property, but that turns out not to be the case. 2) something deep in gnus wants gnus-newsgroup-charset, but that is defined in gnus-sum, which is not loaded by default. 3) If gnus-sum is loaded, then the display of the message/rfc822 part succeeds, but the buffer gets put into gnus-article-mode, which means that, inter alia, notmuch text properties and keybindings get wiped. --- test/T450-emacs-show.sh | 7 +++ 1 file changed, 7 insertions(+) diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh index 9d08d2cc..bf7c1fe0 100755 --- a/test/T450-emacs-show.sh +++ b/test/T450-emacs-show.sh @@ -219,6 +219,13 @@ test_emacs '(notmuch-show "id:basic-encryp...@crypto.notmuchmail.org") (test-visible-output)' test_expect_equal_file $EXPECTED/notmuch-show-decrypted-message OUTPUT +test_begin_subtest "show encrypted rfc822 message" +test_subtest_known_broken +test_emacs '(notmuch-show "id:encrypted-rfc822-attachm...@crypto.notmuchmail.org") +(test-visible-output)' +fgrep '!!!' OUTPUT > OUTPUT.err +test_expect_equal_file /dev/null OUTPUT.err + test_begin_subtest "show undecryptable message" test_emacs '(notmuch-show "id:simple-encryp...@crypto.notmuchmail.org") (test-visible-output)' -- 2.30.2 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
