[PATCH 2/3] new: Add all initial tags at once

2011-01-27 Thread Carl Worth
On Thu, 27 Jan 2011 15:03:49 +1000, Carl Worth wrote: > Just a few hours ago I attended an interesting talk by Rusty Russell in > which he talks about a CCAN module he has written called failtest which > provides an implementation of this kind of testing. I meant to include some links with the

[PATCH 2/3] new: Add all initial tags at once

2011-01-27 Thread Carl Worth
On Wed, 26 Jan 2011 17:52:53 +0100, Thomas Schwinge wrote: > I do support the patch's idea (which was recently committed; and what > follows in this message is not at all directed towards Michal, who wrote > this patch) -- but what about return values checking? This is one aspect > of the

[PATCH 2/3] new: Add all initial tags at once

2011-01-27 Thread Michal Sojka
On Thu, 27 Jan 2011, Carl Worth wrote: > On Thu, 27 Jan 2011 15:03:49 +1000, Carl Worth wrote: > > Just a few hours ago I attended an interesting talk by Rusty Russell in > > which he talks about a CCAN module he has written called failtest which > > provides an implementation of this kind of

Re: [PATCH 2/3] new: Add all initial tags at once

2011-01-27 Thread Michal Sojka
On Thu, 27 Jan 2011, Carl Worth wrote: On Thu, 27 Jan 2011 15:03:49 +1000, Carl Worth cwo...@cworth.org wrote: Just a few hours ago I attended an interesting talk by Rusty Russell in which he talks about a CCAN module he has written called failtest which provides an implementation of this

[PATCH 2/3] new: Add all initial tags at once

2011-01-26 Thread Thomas Schwinge
Hallo! On Fri, 21 Jan 2011 10:59:36 +0100, Michal Sojka wrote: > --- a/notmuch-new.c > +++ b/notmuch-new.c > @@ -418,6 +418,7 @@ add_files_recursive (notmuch_database_t *notmuch, > /* success */ > case NOTMUCH_STATUS_SUCCESS: > state->added_messages++; > +

Re: [PATCH 2/3] new: Add all initial tags at once

2011-01-26 Thread Carl Worth
On Thu, 27 Jan 2011 15:03:49 +1000, Carl Worth cwo...@cworth.org wrote: Just a few hours ago I attended an interesting talk by Rusty Russell in which he talks about a CCAN module he has written called failtest which provides an implementation of this kind of testing. I meant to include some

[PATCH 2/3] new: Add all initial tags at once

2011-01-21 Thread Michal Sojka
If there are several tags applied to the new messages, it is beneficial to store them to the database at one, because it saves some time, especially when the notmuch new is run for the first time. This patch decreased the time for initial import from 1h 35m to 1h 14m. --- notmuch-new.c |2 ++

[PATCH 2/3] new: Add all initial tags at once

2011-01-21 Thread Michal Sojka
If there are several tags applied to the new messages, it is beneficial to store them to the database at one, because it saves some time, especially when the notmuch new is run for the first time. This patch decreased the time for initial import from 1h 35m to 1h 14m. --- notmuch-new.c |2 ++