Re: [PATCH 3/5] cli/dump: define GZPRINTF macro and use it in place of gzprintf

2020-04-13 Thread David Bremner
David Bremner writes: > Tomi Ollila writes: > >> __location__ ?? never seen such a (preprocessor?) definition. could not >> find any reference by search... > > I have to admit, it's just cargo culted from util/error_util.h > OIC, it's defined in talloc.h. Probably that deserves a comment. __

Re: [PATCH 3/5] cli/dump: define GZPRINTF macro and use it in place of gzprintf

2020-04-13 Thread David Bremner
Tomi Ollila writes: > __location__ ?? never seen such a (preprocessor?) definition. could not > find any reference by search... I have to admit, it's just cargo culted from util/error_util.h > > there are also some suspiciously looking like inconsistent spaces in that > macro above OK, I'll ha

Re: [PATCH 3/5] cli/dump: define GZPRINTF macro and use it in place of gzprintf

2020-04-13 Thread Tomi Ollila
On Sun, Apr 12 2020, David Bremner wrote: > This will at least catch errors, and can be replaced with more > sophisticated error handling where appropriate. > --- > notmuch-client.h | 3 +++ > notmuch-dump.c | 24 > 2 files changed, 15 insertions(+), 12 deletions(-) >

[PATCH 3/5] cli/dump: define GZPRINTF macro and use it in place of gzprintf

2020-04-12 Thread David Bremner
This will at least catch errors, and can be replaced with more sophisticated error handling where appropriate. --- notmuch-client.h | 3 +++ notmuch-dump.c | 24 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/notmuch-client.h b/notmuch-client.h index 4