Re: [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages

2019-05-30 Thread Rollins, Jameson
On Thu, May 30 2019, Daniel Kahn Gillmor wrote: > Yes, it does fix notmuch reply as well. Do you think that we should > augment the test suite to include 'notmuch reply' too? I mean, more tests don't hurt, but I don't see it as critical. I think it could be as simple as (please verify): test_b

Re: [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages

2019-05-30 Thread Daniel Kahn Gillmor
On Thu 2019-05-30 02:09:47 +, Rollins, Jameson wrote: > On Wed, May 29 2019, Jameson Graef Rollins wrote: >> On Tue, May 28 2019, Daniel Kahn Gillmor wrote: >>> When showing a message that has been mangled in transit by an MTA in >>> the "Mixed up" way, "notmuch show" should instead show the

Re: [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages

2019-05-29 Thread Rollins, Jameson
On Wed, May 29 2019, Jameson Graef Rollins wrote: > On Tue, May 28 2019, Daniel Kahn Gillmor wrote: >> When showing a message that has been mangled in transit by an MTA in >> the "Mixed up" way, "notmuch show" should instead show the repaired >> form of the message. > > Given that this fix is in

Re: [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages

2019-05-29 Thread Rollins, Jameson
On Tue, May 28 2019, Daniel Kahn Gillmor wrote: > When showing a message that has been mangled in transit by an MTA in > the "Mixed up" way, "notmuch show" should instead show the repaired > form of the message. Given that this fix is in mime-node.c it will apply to reply as well, not just show,

[PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages

2019-05-28 Thread Daniel Kahn Gillmor
When showing a message that has been mangled in transit by an MTA in the "Mixed up" way, "notmuch show" should instead show the repaired form of the message. Tracking the repaired GMimeObject for the lifetime of the mime_node so that it is cleaned up properly is probably the trickiest part of this