Re: [PATCH v2] test: Unset ALTERNATE_EDITOR before running emacsclient
Michal Sojka writes: > ALTERNATE_EDITOR causes emacsclient to run an alternate editor if the > emacs server is not ready. This can collide with intended > functionality in test-lib.sh. > pushed, d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v2] test: Unset ALTERNATE_EDITOR before running emacsclient
On Tue, Dec 29 2015, Michal Sojka wrote: > ALTERNATE_EDITOR causes emacsclient to run an alternate editor if the > emacs server is not ready. This can collide with intended > functionality in test-lib.sh. > > If the ALTERNATE_EDITOR is set but empty, emacsclient runs emacs > daemon and tries to connect to it. When this happens the emacs run by > test-lib.sh fails to start the server and the subsequent attempts to > use the server fail because the daemon started by emacsclient does not > know about notmuch-test-progn. This leads to test suite failure due to > time out on any emacs test. > --- LGTM. Tomi > test/test-lib.sh | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index 126911f..270c718 100644 > --- a/test/test-lib.sh > +++ b/test/test-lib.sh > @@ -82,6 +82,9 @@ unset CDPATH > > unset GREP_OPTIONS > > +# For emacsclient > +unset ALTERNATE_EDITOR > + > # Convenience > # > # A regexp to match 5 and 40 hexdigits > -- > 2.6.4 > > ___ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH v2] test: Unset ALTERNATE_EDITOR before running emacsclient
ALTERNATE_EDITOR causes emacsclient to run an alternate editor if the emacs server is not ready. This can collide with intended functionality in test-lib.sh. If the ALTERNATE_EDITOR is set but empty, emacsclient runs emacs daemon and tries to connect to it. When this happens the emacs run by test-lib.sh fails to start the server and the subsequent attempts to use the server fail because the daemon started by emacsclient does not know about notmuch-test-progn. This leads to test suite failure due to time out on any emacs test. --- test/test-lib.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/test-lib.sh b/test/test-lib.sh index 126911f..270c718 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -82,6 +82,9 @@ unset CDPATH unset GREP_OPTIONS +# For emacsclient +unset ALTERNATE_EDITOR + # Convenience # # A regexp to match 5 and 40 hexdigits -- 2.6.4 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch