Re: [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread
Tomi Ollila writes: > To me it looks like this change "breaks" indentation -- the original > where all function (notmuch-show) arguments are aligned vertically, > starting from same column in each line...??? > Argh, it was me that was stupid. I had nameless-mode activated which affects indentation. Please ignore that commit then (I'll retract it with the next re-roll) and apologies for the inconvenience. >> >> base-commit: e3ad0087f3453c89871acac8b11da8bab1ac54df > > btw: what is this 'base commit:' line ? > It's included in the patch by git-format-patch. I think it helps git to know on which commit to apply these patches to. Other projects mandated that option so I have it on by default. /Leo ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread
On Mon, May 02 2022, Leo Okawa Ericson wrote: > --- > emacs/notmuch.el | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index c9cf80dc..c1ddb06b 100644 > --- a/emacs/notmuch.el > +++ b/emacs/notmuch.el > @@ -525,13 +525,13 @@ (defun notmuch-search-show-thread ( > elide-toggle) >(let ((thread-id (notmuch-search-find-thread-id))) > (if thread-id > (notmuch-show thread-id > - elide-toggle > - (current-buffer) > - notmuch-search-query-string > - ;; Name the buffer based on the subject. > - (format "*%s*" (truncate-string-to-width > - (notmuch-search-find-subject) > - 30 nil nil t))) To me it looks like this change "breaks" indentation -- the original where all function (notmuch-show) arguments are aligned vertically, starting from same column in each line...??? > +elide-toggle > +(current-buffer) > +notmuch-search-query-string > +;; Name the buffer based on the subject. > +(format "*%s*" (truncate-string-to-width > +(notmuch-search-find-subject) > +30 nil nil t))) >(message "End of search results." > > (defun notmuch-tree-from-search-current-query () > > base-commit: e3ad0087f3453c89871acac8b11da8bab1ac54df btw: what is this 'base commit:' line ? Tomi > -- > 2.36.0 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread
--- emacs/notmuch.el | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index c9cf80dc..c1ddb06b 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -525,13 +525,13 @@ (defun notmuch-search-show-thread ( elide-toggle) (let ((thread-id (notmuch-search-find-thread-id))) (if thread-id (notmuch-show thread-id - elide-toggle - (current-buffer) - notmuch-search-query-string - ;; Name the buffer based on the subject. - (format "*%s*" (truncate-string-to-width - (notmuch-search-find-subject) - 30 nil nil t))) + elide-toggle + (current-buffer) + notmuch-search-query-string + ;; Name the buffer based on the subject. + (format "*%s*" (truncate-string-to-width + (notmuch-search-find-subject) + 30 nil nil t))) (message "End of search results." (defun notmuch-tree-from-search-current-query () base-commit: e3ad0087f3453c89871acac8b11da8bab1ac54df -- 2.36.0 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
