On Thu, 12 Jan 2012 16:59:05 -0500, Austin Clements wrote:
> LGTM. One thing you could fix below (and a few comments), but not
> enough alone to warrant a new version.
>
> Quoth Jani Nikula on Jan 12 at 11:40 pm:
> > Slightly refactor "notmuch reply" recipient and user from address scanning
> >
Slightly refactor "notmuch reply" recipient and user from address scanning
functions in preparation for reply-to-sender feature.
Add support for not adding messages at all (just scan for user from
address), and returning the number of messages added.
No externally visible functional changes.
This is nice.
Two very minor nits:
In your commit message you say
> Add support for not adding messages at all (just scan for user from
> address), and returning the number of messages added.
and I think both "messages" should "recipients".
> + * If 'user_from' is non-NULL and *user_from is
LGTM. One thing you could fix below (and a few comments), but not
enough alone to warrant a new version.
Quoth Jani Nikula on Jan 12 at 11:40 pm:
> Slightly refactor "notmuch reply" recipient and user from address scanning
> functions in preparation for reply-to-sender feature.
>
> Add support
Slightly refactor notmuch reply recipient and user from address scanning
functions in preparation for reply-to-sender feature.
Add support for not adding messages at all (just scan for user from
address), and returning the number of messages added.
No externally visible functional changes.
This is nice.
Two very minor nits:
In your commit message you say
Add support for not adding messages at all (just scan for user from
address), and returning the number of messages added.
and I think both messages should recipients.
+ * If 'user_from' is non-NULL and *user_from is NULL,
