[notmuch] [PATCH] Makefile: Enable backslash escapes for echo.
On Thu, Nov 26, 2009 at 12:05 PM, Jan Janak wrote: > I sent exactly the same patch a couple of days ago and it was > rejected because it does not work everywhere, see: > > http://notmuchmail.org/pipermail/notmuch/2009/000370.html And as I said in that thread, I believe you should use printf instead. (http://www.in-ulm.de/~mascheck/various/echo+printf/ seems like a good reference in this matter.) -- Karl Wiberg, kha at treskal.com subrabbit.wordpress.com www.treskal.com/kalle
[notmuch] [PATCH] Makefile: Enable backslash escapes for echo.
Hi Stefan, On 26-11 09:17, Stefan Schmidt wrote: > This fixes a visual glitch during a silent compile. > Before: > Use "make V=1" to see the verbose compile lines.\n CC debugger.o > CCgmime-filter-reply.o > > After: > Use "make V=1" to see the verbose compile lines. > CCdebugger.o > CCgmime-filter-reply.o > > Signed-off-by: Stefan Schmidt > --- > Makefile |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index 2cd1b1b..2d19a6e 100644 > --- a/Makefile > +++ b/Makefile > @@ -41,7 +41,7 @@ include Makefile.config > # user how to enable verbose compiles. > ifeq ($(V),) > quiet_DOC := "Use \"$(MAKE) V=1\" to see the verbose compile lines.\n" > -quiet = @echo $(quiet_DOC)$(eval quiet_DOC:=)" $1 $@"; $($1) > +quiet = @echo -e $(quiet_DOC)$(eval quiet_DOC:=)" $1$@"; $($1) > endif > # The user has explicitly enabled quiet compilation. > ifeq ($(V),0) I sent exactly the same patch a couple of days ago and it was rejected because it does not work everywhere, see: http://notmuchmail.org/pipermail/notmuch/2009/000370.html -- Jan
[notmuch] [PATCH] Makefile: Enable backslash escapes for echo.
Excerpts from Stefan Schmidt's message of Thu Nov 26 09:17:15 +0100 2009: > This fixes a visual glitch during a silent compile. > Before: > Use "make V=1" to see the verbose compile lines.\n CC debugger.o > CCgmime-filter-reply.o > > After: > Use "make V=1" to see the verbose compile lines. > CCdebugger.o > CCgmime-filter-reply.o > > Signed-off-by: Stefan Schmidt Looks right, works here with bash, dash & zsh, so: Reviewed-by: Ingmar Vanhassel Thanks! > --- > Makefile |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index 2cd1b1b..2d19a6e 100644 > --- a/Makefile > +++ b/Makefile > @@ -41,7 +41,7 @@ include Makefile.config > # user how to enable verbose compiles. > ifeq ($(V),) > quiet_DOC := "Use \"$(MAKE) V=1\" to see the verbose compile lines.\n" > -quiet = @echo $(quiet_DOC)$(eval quiet_DOC:=)" $1$@"; $($1) > +quiet = @echo -e $(quiet_DOC)$(eval quiet_DOC:=)" $1$@"; $($1) > endif > # The user has explicitly enabled quiet compilation. > ifeq ($(V),0) -- Exherbo KDE, X.org maintainer
[notmuch] [PATCH] Makefile: Enable backslash escapes for echo.
This fixes a visual glitch during a silent compile. Before: Use "make V=1" to see the verbose compile lines.\n CC debugger.o CCgmime-filter-reply.o After: Use "make V=1" to see the verbose compile lines. CCdebugger.o CCgmime-filter-reply.o Signed-off-by: Stefan Schmidt --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 2cd1b1b..2d19a6e 100644 --- a/Makefile +++ b/Makefile @@ -41,7 +41,7 @@ include Makefile.config # user how to enable verbose compiles. ifeq ($(V),) quiet_DOC := "Use \"$(MAKE) V=1\" to see the verbose compile lines.\n" -quiet = @echo $(quiet_DOC)$(eval quiet_DOC:=)" $1 $@"; $($1) +quiet = @echo -e $(quiet_DOC)$(eval quiet_DOC:=)" $1 $@"; $($1) endif # The user has explicitly enabled quiet compilation. ifeq ($(V),0) -- 1.6.5.3
