[notmuch] [PATCH] New function notmuch-show-kill-ring-save-message-id.

2009-11-28 Thread Jed Brown
On Fri, 27 Nov 2009 21:54:11 -0800, Carl Worth wrote: > Ah. So we have our first case of emacs-lisp portability issues. Bummer, my docs say nothing about this changing, let alone in a way that's going to break anything that used it. > I'm using "GNU emacs 23.1.1" currently, for what it's worth.

[notmuch] [PATCH] New function notmuch-show-kill-ring-save-message-id.

2009-11-27 Thread Carl Worth
On Fri, 27 Nov 2009 15:18:31 +0100, Jed Brown wrote: > On Fri, 27 Nov 2009 05:41:44 -0800, Carl Worth wrote: > > Thanks for the patch, Jed, I almost pushed it, but noticed that it's > > calling `called-interactively-p' with an argument even though that > > function does not accept an argument. >

[notmuch] [PATCH] New function notmuch-show-kill-ring-save-message-id.

2009-11-27 Thread Jed Brown
On Fri, 27 Nov 2009 05:41:44 -0800, Carl Worth wrote: > Thanks for the patch, Jed, I almost pushed it, but noticed that it's > calling `called-interactively-p' with an argument even though that > function does not accept an argument. My docs say it does take an argument:

[notmuch] [PATCH] New function notmuch-show-kill-ring-save-message-id.

2009-11-27 Thread Carl Worth
Thanks for the patch, Jed, I almost pushed it, but noticed that it's calling `called-interactively-p' with an argument even though that function does not accept an argument. Meanwhile, the documentation of called-interactively-p suggests that using (interactive "p") is an easier way to check

Re: [notmuch] [PATCH] New function notmuch-show-kill-ring-save-message-id.

2009-11-27 Thread Jed Brown
On Fri, 27 Nov 2009 05:41:44 -0800, Carl Worth cwo...@cworth.org wrote: Thanks for the patch, Jed, I almost pushed it, but noticed that it's calling `called-interactively-p' with an argument even though that function does not accept an argument. My docs say it does take an argument:

[notmuch] [PATCH] New function notmuch-show-kill-ring-save-message-id.

2009-11-24 Thread Jed Brown
It turns out that this ID has id: prefixed (which I thought was fine because I'm frequently doing another query with it). But git send-email doesn't strip that, so this was not threaded correctly. Would this be better with the id: prefix stripped? Jed

[notmuch] [PATCH] New function notmuch-show-kill-ring-save-message-id.

2009-11-24 Thread Jed Brown
Puts current message ID in the kill ring. This is useful any time you want to explicitly refer to the message, such as in the body of another message, through git format-patch, or on IRC. It is bound to "C-c i". Corrected spelling of function name in commit message, and updated to apply against