Re: [PATCH] Makefile: specify libnotmuch.so location with -rpath
On Sun, 25 Apr 2010 17:59:35 +0200, Adrien Bustany mad...@mymadcat.com wrote: On Sun, 25 Apr 2010 16:38:40 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: In order to handle installation into user directories, it is convenient to encode the library location into the search path for the notmuch executable. This is achieved for the GNU linker with the -rpath argument. I know that many distros (among them Fedora, see https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath ) discourage the use of rpath. Do you think it could be an option set at configure time (set rpath or not) ? Right. Debian doesn't want this either. Some of what I've wanted to do in make install to help with this: * Figure out the right way to run ldconfig from make install * Test if the runtime linker will be able to find the library, and if not print a message about setting LD_LIBRARY_PATH (or DYLD_LIBRARY_PATH). Setting rpath with the option to prevent this might be possible too. But we can't do this unconditionally. -Carl -- carl.d.wo...@intel.com pgpUWNa6O4ifM.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Makefile: specify libnotmuch.so location with -rpath
On Sun, 25 Apr 2010 16:38:40 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: In order to handle installation into user directories, it is convenient to encode the library location into the search path for the notmuch executable. This is achieved for the GNU linker with the -rpath argument. --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index 5bb570b..77d2c45 100644 --- a/Makefile.local +++ b/Makefile.local @@ -31,7 +31,7 @@ GPG_FILE=$(SHA1_FILE).asc # Smash together user's values with our extra values FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CFLAGS) $(WARN_CFLAGS) $(CONFIGURE_CFLAGS) $(extra_cflags) FINAL_CXXFLAGS = $(CXXFLAGS) $(WARN_CXXFLAGS) $(CONFIGURE_CXXFLAGS) $(extra_cflags) $(extra_cxxflags) -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Wl,-rpath=$(prefix)/lib -Llib -lnotmuch FINAL_NOTMUCH_LINKER = CC ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1) FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS) Hello Chris, I know that many distros (among them Fedora, see https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath ) discourage the use of rpath. Do you think it could be an option set at configure time (set rpath or not) ? Cheers Adrien ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Makefile: specify libnotmuch.so location with -rpath
On Sun, 25 Apr 2010 16:38:40 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: In order to handle installation into user directories, it is convenient to encode the library location into the search path for the notmuch executable. This is achieved for the GNU linker with the -rpath argument. --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index 5bb570b..77d2c45 100644 --- a/Makefile.local +++ b/Makefile.local @@ -31,7 +31,7 @@ GPG_FILE=$(SHA1_FILE).asc # Smash together user's values with our extra values FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CFLAGS) $(WARN_CFLAGS) $(CONFIGURE_CFLAGS) $(extra_cflags) FINAL_CXXFLAGS = $(CXXFLAGS) $(WARN_CXXFLAGS) $(CONFIGURE_CXXFLAGS) $(extra_cflags) $(extra_cxxflags) -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Wl,-rpath=$(prefix)/lib -Llib -lnotmuch FINAL_NOTMUCH_LINKER = CC ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1) FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS) Hello Chris, I know that many distros (among them Fedora, see https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath ) discourage the use of rpath. Do you think it could be an option set at configure time (set rpath or not) ? Cheers Adrien ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
