Re: [PATCH] NEWS/emacs: document changes in 0.32 that affect keybindings.
Daniel Kahn Gillmor writes: > See list discussion in thread starting with > id:87h7ip2baq@fifthhorseman.net for more details. > > Signed-off-by: Daniel Kahn Gillmor applied to release and master (with generic "Emacs configuration" in place of .emacs) ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] NEWS/emacs: document changes in 0.32 that affect keybindings.
On Thu, May 27 2021, Daniel Kahn Gillmor wrote: > On Thu 2021-05-27 20:11:13 +0300, Tomi Ollila wrote: >> On Thu, May 27 2021, Daniel Kahn Gillmor wrote: >>> +Keymaps are no longer fset, which means they need to be referred to in >>> +define-key directly (without quotes). If your ~/.emacs has a >> >> In our docs it would be better to refer ~/.emacs.d/notmuch-config.el (?) :D > > Interesting, that's not where my notmuch-emacs config is located but i > certainly have no objection to the proposed revision. loading of .emacs.d/notmuch-config.el (notmuch-init-file) was added to notmuch.el in this commit: 31fc76b78 emacs/notmuch.el (Tomi Ollila 2014-03-29 10:07:59 +0200) When it is mentioned in our dox users have better change to know it, and choose the most appropriate places for their notmuch configurations. (I personally have (autoload 'notmuch "notmuch" "Notmuch mail" t) in git repo which contains emacs configuration. There is also 'user-notmuch.el' which has "common" notmuch configurations cloned everywhere. ~/emacs.d/notmuch-config.el starts with (load "user-notmuch"), and then continues with site-specific configuration). > > --dkg Tomi ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] NEWS/emacs: document changes in 0.32 that affect keybindings.
On Thu 2021-05-27 20:11:13 +0300, Tomi Ollila wrote: > On Thu, May 27 2021, Daniel Kahn Gillmor wrote: >> +Keymaps are no longer fset, which means they need to be referred to in >> +define-key directly (without quotes). If your ~/.emacs has a > > In our docs it would be better to refer ~/.emacs.d/notmuch-config.el (?) :D Interesting, that's not where my notmuch-emacs config is located but i certainly have no objection to the proposed revision. --dkg signature.asc Description: PGP signature ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] NEWS/emacs: document changes in 0.32 that affect keybindings.
On Thu, May 27 2021, Daniel Kahn Gillmor wrote: > See list discussion in thread starting with > id:87h7ip2baq@fifthhorseman.net for more details. > > Signed-off-by: Daniel Kahn Gillmor > --- > NEWS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/NEWS b/NEWS > index c0ae6afe..c3ca1085 100644 > --- a/NEWS > +++ b/NEWS > @@ -101,6 +101,13 @@ Removed, inlined or renamed functions and variables: > `notmuch-sexp-eof`, `notmuch-split-content-type`, and > `notmuch-tree-button-activate`. > > +Keymaps are no longer fset, which means they need to be referred to in > +define-key directly (without quotes). If your ~/.emacs has a In our docs it would be better to refer ~/.emacs.d/notmuch-config.el (?) :D Tomi > +keybinding like: > + (define-key 'notmuch-show-mode-map "7" 'foo) > +you should change it to: > + (define-key notmuch-show-mode-map "7" 'foo) > + > Notmuch 0.31.4 (2021-02-18) > === > > -- > 2.30.2 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
