Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-23 Thread Đoàn Trần Công Danh
On 2021-04-23 14:31:43-0300, David Bremner wrote: > Đoàn Trần Công Danh writes: > > > > > Yes, inline function are always better than macro. > > I feel embarassed that I couldn't think about that earlier. > > > > Here is a revised patch: > > This version still has some issues on a glibc

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-23 Thread David Bremner
Đoàn Trần Công Danh writes: > > Yes, inline function are always better than macro. > I feel embarassed that I couldn't think about that earlier. > > Here is a revised patch: This version still has some issues on a glibc system. , | In file included from notmuch-client.h:31, |

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-18 Thread Tomi Ollila
On Sun, Apr 18 2021, Tomi Ollila wrote: > > not perl, but python3 -c 'import socket; print(socket.getfqdn())' notmuch_passwd_sanitize() { python3 -c ' import os, sys, pwd, socket pw = pwd.getpwuid(os.getuid()) user = pw.pw_name name = pw.pw_gecos.partition(",")[0] fqdn = socket.getfqdn()

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-18 Thread Tomi Ollila
On Sun, Apr 18 2021, David Bremner wrote: > Đoàn Trần Công Danh writes: > >> >> Anyway, I see some failure in the testsuite due to: >> - *My* hostname(1) (from coreutils) doesn't understand "-f" Interesting (neither of these use coreutils hostname) $ rpm -q -f =hostname

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-18 Thread David Bremner
Đoàn Trần Công Danh writes: > > Anyway, I see some failure in the testsuite due to: > - *My* hostname(1) (from coreutils) doesn't understand "-f" ah, any suggestions for a portable replacement? I guess some perl one liner might work. > - All emacs tests depend on dtach(1) but the >

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-18 Thread Đoàn Trần Công Danh
On 2021-04-18 10:08:31+0300, Tomi Ollila wrote: > On Sun, Apr 18 2021, Đoàn Trần Công Danh wrote: > > > On 2021-04-17 11:39:59-0300, David Bremner wrote: > >> Đoàn Trần Công Danh writes: > >> > >> > > >> > However, I see that lib/open.cc uses g_key_file_get_value from GLib > >> > already, we

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-18 Thread Tomi Ollila
On Sun, Apr 18 2021, Đoàn Trần Công Danh wrote: > On 2021-04-17 11:39:59-0300, David Bremner wrote: >> Đoàn Trần Công Danh writes: >> >> > >> > However, I see that lib/open.cc uses g_key_file_get_value from GLib >> > already, we may switch to g_canonicalize_file_name then? >> > >> >> Yes that

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-17 Thread Đoàn Trần Công Danh
On 2021-04-17 11:39:59-0300, David Bremner wrote: > Đoàn Trần Công Danh writes: > > > > > However, I see that lib/open.cc uses g_key_file_get_value from GLib > > already, we may switch to g_canonicalize_file_name then? > > > > Yes that could work. I think the treatment of NULL input might need

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-17 Thread David Bremner
Đoàn Trần Công Danh writes: > > However, I see that lib/open.cc uses g_key_file_get_value from GLib > already, we may switch to g_canonicalize_file_name then? > Yes that could work. I think the treatment of NULL input might need some extra care with g_canonicalize_file_name; at least my 5

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-17 Thread Đoàn Trần Công Danh
On 2021-04-17 09:13:19-0300, David Bremner wrote: > Đoàn Trần Công Danh writes: > > > When compat canonicalize_file_name was introduced, it was limited to > > C code only because it was used by C code only during that time. > > > > From 5ec6fd4d, (lib/open: check for split configuration when

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-17 Thread David Bremner
Đoàn Trần Công Danh writes: > When compat canonicalize_file_name was introduced, it was limited to > C code only because it was used by C code only during that time. > > From 5ec6fd4d, (lib/open: check for split configuration when creating > database., 2021-02-16), lib/open.cc, which is C++,