Re: [PATCH] configure: fix mktemp call for macOS

2019-06-16 Thread David Bremner
Ralph Seichter writes: > Add missing template to mktemp, as required by macOS / OS X. > > Signed-off-by: Ralph Seichter > --- I've merged this to master and release. In the case that we do another point release before 0.30, it will be in that. d ___

Re: [PATCH] configure: fix mktemp call for macOS

2019-06-16 Thread Daniel Kahn Gillmor
On Fri 2019-06-14 20:57:07 +0300, Tomi Ollila wrote: > Yes. $TMPDIR could be problematic if it makes the full (unix domain > socket?) path be too long. Modern, maintained version of GnuPG will only place sockets directly in the $GNUPGHOME if /run/user/$(id -u) (i.e., $XDG_RUNTIME_DIR) is not

Re: [PATCH] configure: fix mktemp call for macOS

2019-06-16 Thread Tomi Ollila
On Sat, Jun 15 2019, Ralph Seichter wrote: > * Tomi Ollila: > >> First, it would be better if >> >> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XX") >> >> worked, then the behaviour on Linux would not change. > > I'm trying to figure out if I can override $TMPDIR during the MacPorts >

Re: [PATCH] configure: fix mktemp call for macOS

2019-06-15 Thread Ralph Seichter
* Tomi Ollila: > First, it would be better if > > TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XX") > > worked, then the behaviour on Linux would not change. I'm trying to figure out if I can override $TMPDIR during the MacPorts configure phase. According to the documentation, modifying

Re: [PATCH] configure: fix mktemp call for macOS

2019-06-14 Thread Tomi Ollila
On Fri, Jun 14 2019, Tomi Ollila wrote: > On Fri, Jun 14 2019, Ralph Seichter wrote: > >> * David Bremner: >> >>> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XX") >>> >>> (borrowed from test/test-lib.sh). This avoids hardcoding the temporary >>> directory. >> >> I had the same thought at

Re: [PATCH] configure: fix mktemp call for macOS

2019-06-14 Thread Tomi Ollila
On Fri, Jun 14 2019, Ralph Seichter wrote: > * David Bremner: > >> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XX") >> >> (borrowed from test/test-lib.sh). This avoids hardcoding the temporary >> directory. > > I had the same thought at first, but I want to ensure that the path > length

Re: [PATCH] configure: fix mktemp call for macOS

2019-06-14 Thread Ralph Seichter
* David Bremner: > TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XX") > > (borrowed from test/test-lib.sh). This avoids hardcoding the temporary > directory. I had the same thought at first, but I want to ensure that the path length does not cause trouble anymore. > uname -v Darwin

Re: [PATCH] configure: fix mktemp call for macOS

2019-06-14 Thread David Bremner
Ralph Seichter writes: > The mktemp call in configure is incompatible with /usr/bin/mktemp as > shipped with macOS, where it fails due to a missing parameter. I added > the missing template, and the call is now working with both Apple's > and GNU coreutils' mktemp. > I'm hoping Tomi will