Re: [PATCH] doc: add dep. on stamp file for rebuilding gzipped man pages.

2021-12-25 Thread David Bremner
David Bremner  writes:

> In [1] Daniel observed that the gzipped man pages were only being
> rebuild every second time when building with `make -j4'. This may be
> caused by a race condition between sphinx-build rebuilding the roff
> files and the recipe to gzip them. This commit sequentializes these
> two steps by making the stamp file a prerequisite for (all of) the
> gzip files.
>
> [1]: id:87tveotn1g@fifthhorseman.net

Applied to master, wimpy commit message intact :P

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH] doc: add dep. on stamp file for rebuilding gzipped man pages.

2021-12-25 Thread Tomi Ollila
On Fri, Dec 24 2021, David Bremner wrote:

> In [1] Daniel observed that the gzipped man pages were only being
> rebuild every second time when building with `make -j4'. This may be
> caused by a race condition between sphinx-build rebuilding the roff
> files and the recipe to gzip them. This commit sequentializes these
> two steps by making the stamp file a prerequisite for (all of) the
> gzip files.
>
> [1]: id:87tveotn1g@fifthhorseman.net
> ---
>  doc/Makefile.local | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/doc/Makefile.local b/doc/Makefile.local
> index c2ae1743..d43ef269 100644
> --- a/doc/Makefile.local
> +++ b/doc/Makefile.local
> @@ -117,6 +117,11 @@ build-man:
>  install-man:
>   @echo "No sphinx, will not install man pages."
>  else
> +
> +# it should be safe to depend on the stamp file, because it is created
> +# after all roff files are moved into place.
> +${MAN_GZIP_FILES}: ${DOCBUILDDIR}/.roff.stamp
> +

This thread becomes hard to follow...

... but the change looks sensible... the comment *should* be more
"assuritive" though ... :D


>  build-man: ${MAN_GZIP_FILES}
>  install-man: ${MAN_GZIP_FILES}
>   mkdir -m0755 -p "$(DESTDIR)$(mandir)/man1"
> -- 
> 2.34.1
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org