Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-11-02 Thread David Bremner
On Tue, 9 Aug 2011 19:32:49 +0200, Daniel Schoepe daniel.scho...@googlemail.com wrote: This patch adds completion with tab in the minibuffer for notmuch-search and notmuch-search-filter. Finally pushed. d ___ notmuch mailing list

Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-08-09 Thread Daniel Schoepe
On Fri, 05 Aug 2011 23:09:23 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Hey, Daniel. I actually just ran into a little bug with this patch. After applying this patch, if I try to scroll/search through my mini-buffer history after a search I get the following error:

Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-08-09 Thread Jameson Graef Rollins
On Tue, 09 Aug 2011 19:31:44 +0200, Daniel Schoepe daniel.scho...@googlemail.com wrote: Turns out, I just used `read-from-minibuffer' incorrectly, here's an updated version. Hey, Daniel. Thanks so much for the quick fix! This new patch seems to work great. Signed-off-by: Jameson Graef

Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-08-06 Thread Jameson Graef Rollins
Hey, Daniel. I actually just ran into a little bug with this patch. After applying this patch, if I try to scroll/search through my mini-buffer history after a search I get the following error: previous-history-element: Wrong type argument: symbolp, tag:signed I get this error no matter what my

Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-08-05 Thread Daniel Schoepe
On Mon, 06 Jun 2011 18:32:41 +0200, Daniel Schoepe daniel.scho...@googlemail.com wrote: [..] I've been using this patch for the past two months now and it has been working fine. Are there any more suggestions or criticisms about this? Cheers, Daniel pgpoxgMn2II98.pgp Description: PGP

Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-08-05 Thread Jameson Graef Rollins
On Fri, 05 Aug 2011 17:17:56 +0200, Daniel Schoepe daniel.scho...@googlemail.com wrote: On Mon, 06 Jun 2011 18:32:41 +0200, Daniel Schoepe daniel.scho...@googlemail.com wrote: I've been using this patch for the past two months now and it has been working fine. Are there any more suggestions

Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-06-06 Thread Daniel Schoepe
I accidentally left a, now unnecessary, defvar in the patch from one of the previous attempts, here is the updated version (thanks Austin for noticing). From f3bc7376edc66e947d8fdf5931a9aa697b9be5cf Mon Sep 17 00:00:00 2001 From: Daniel Schoepe daniel.scho...@googlemail.com Date: Sat, 4 Jun 2011

Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-06-04 Thread Austin Clements
Nifty! On Sat, Jun 4, 2011 at 8:19 AM, Daniel Schoepe daniel.scho...@googlemail.com wrote: +        (minibuffer-completion-table (completion-table-dynamic +                                      `(lambda (s) (notmuch-query-completions +                                               (quote

Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-06-04 Thread Daniel Schoepe
On Sat, 4 Jun 2011 11:32:15 -0400, Austin Clements amdra...@mit.edu wrote: Dynamic scoping is obnoxious, but I think programmed completion is steeped in the assumption that you'll use it. This code would be much simpler if notmuch-query-completions took only `string' and used the

Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-06-04 Thread Daniel Schoepe
Sorry, forgot to actually test notmuch-search entirely with this change and not just the completion. From cb172efc1dea2507566db587f960c073373e0159 Mon Sep 17 00:00:00 2001 From: Daniel Schoepe daniel.scho...@googlemail.com Date: Sat, 4 Jun 2011 14:17:44 +0200 Subject: [PATCH] emacs: Tab completion

Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-06-04 Thread Austin Clements
Quoth Daniel Schoepe on Jun 04 at 9:55 pm: On Sat, 4 Jun 2011 11:32:15 -0400, Austin Clements amdra...@mit.edu wrote: Dynamic scoping is obnoxious, but I think programmed completion is steeped in the assumption that you'll use it. This code would be much simpler if

Re: [PATCH] emacs: Tab completion for notmuch-search and notmuch-search-filter

2011-06-04 Thread Daniel Schoepe
On Sat, 4 Jun 2011 17:55:24 -0400, Austin Clements amdra...@mit.edu wrote: Oh, sorry, I wasn't suggesting setq'ing a global. I agree that that's really ugly. Rather, something like (defun notmuch-query-completions (string) ... as you have it now ...) (defun notmuch-read-query (prompt)