Re: [PATCH] emacs: User-defined sections in notmuch-hello

2011-06-09 Thread Austin Clements
This looks really interesting. I haven't examined the code very closely, but I have some high level comments. It seems that the code is simultaneously trying to do something very general, but also hard-coding a lot of behaviors, and I think the code's complexity suffers for it. What would this

Re: [PATCH] emacs: User-defined sections in notmuch-hello

2011-05-27 Thread Daniel Schoepe
I forgot to run the test suite with the previous patch, which revealed some minor formatting problems, updated patch in the attachment. From bca5a58d7910b6d46a782db787dfe07e2fcf21e1 Mon Sep 17 00:00:00 2001 From: Daniel Schoepe daniel.scho...@googlemail.com Date: Thu, 26 May 2011 23:03:22 +0200

Re: [PATCH] emacs: User-defined sections in notmuch-hello

2011-05-27 Thread Daniel Schoepe
Accidentally attached the old file again, sorry for the noise. From cafc93e3364955cab70885fec740fee87bc3248e Mon Sep 17 00:00:00 2001 From: Daniel Schoepe daniel.scho...@googlemail.com Date: Thu, 26 May 2011 23:03:22 +0200 Subject: [PATCH] emacs: User-defined sections in notmuch-hello This patch