Re: [PATCH] emacs: new crypto customization variable to control stashing of encryption session keys

2018-06-19 Thread Jameson Graef Rollins
On Tue, Jun 19 2018, Daniel Kahn Gillmor wrote: > This is looking good to me, thanks! > > two more bits of nit-pickery below: > > On Tue 2018-06-19 08:20:12 -0700, Jameson Graef Rollins wrote: >> +(defcustom notmuch-show-stash-session-keys nil >> + "Should session keys be stashed when decrypting

Re: [PATCH] emacs: new crypto customization variable to control stashing of encryption session keys

2018-06-19 Thread Daniel Kahn Gillmor
This is looking good to me, thanks! two more bits of nit-pickery below: On Tue 2018-06-19 08:20:12 -0700, Jameson Graef Rollins wrote: > +(defcustom notmuch-show-stash-session-keys nil > + "Should session keys be stashed when decrypting messages for display? > + > +If this variable is non-nil

Re: [PATCH] emacs: new crypto customization variable to control stashing of encryption session keys

2018-06-19 Thread Jameson Graef Rollins
On Tue, Jun 19 2018, Jameson Graef Rollins wrote: > Introduce notmuch-show-store-session-keys customization variable to > control stashing of session keys. If non-nil any session keys > recovered during decryption will be stored in the database. > > This is just a switch to have --decrypt= use

Re: [PATCH] emacs: new crypto customization variable to control stashing of encryption session keys

2018-06-19 Thread Jameson Graef Rollins
On Tue, Jun 19 2018, David Bremner wrote: > I'm fine with whatever you and dkg decide for a name, but note that the > customization group is independent from the name; you just choose > whatever group you want in the defcustom. Oh, I didn't realize that. I thought they were linked. In that

Re: [PATCH] emacs: new crypto customization variable to control stashing of encryption session keys

2018-06-19 Thread David Bremner
Jameson Graef Rollins writes: > On Mon, Jun 18 2018, Daniel Kahn Gillmor wrote: >> This looks like it would work, but calling it >> notmuch-crypto-store-session-keys is a bit confusing, because based on >> the name it looks like it would apply to many places (e.g. during >> message sending,

Re: [PATCH] emacs: new crypto customization variable to control stashing of encryption session keys

2018-06-18 Thread Jameson Graef Rollins
On Mon, Jun 18 2018, Daniel Kahn Gillmor wrote: > how about: > > notmuch-crypto-store-session-keys-on-show Works for me. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: new crypto customization variable to control stashing of encryption session keys

2018-06-18 Thread Daniel Kahn Gillmor
On Mon 2018-06-18 15:49:45 -0700, Jameson Graef Rollins wrote: > On Mon, Jun 18 2018, Daniel Kahn Gillmor wrote: > >> Should its name be notmuch-show-store-session-keys instead? > > I feel like it should be under the notmuch-crypto customization group, > not notmuch-show.

Re: [PATCH] emacs: new crypto customization variable to control stashing of encryption session keys

2018-06-18 Thread Jameson Graef Rollins
On Mon, Jun 18 2018, Daniel Kahn Gillmor wrote: > This looks like it would work, but calling it > notmuch-crypto-store-session-keys is a bit confusing, because based on > the name it looks like it would apply to many places (e.g. during > message sending, should a session key be stored when the

Re: [PATCH] emacs: new crypto customization variable to control stashing of encryption session keys

2018-06-18 Thread Daniel Kahn Gillmor
thanks for working on this, Jamie! On Sun 2018-06-17 17:31:38 -0700, Jameson Graef Rollins wrote: > Introduce notmuch-crypto-store-session-keys customization variable to > control stashing of session keys. If non-nil any session keys > recovered during decryption will be stored in the database.