Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-26 Thread Radu Butoi
Daniel Kahn Gillmor writes: > I find this argument compelling. When i've used split-pane MUAs, i > pretty much always want the tree view smaller than the message pane. Fair enough. I realized after these responses that my own settings were getting in the way -- I make all my windows equally

Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-23 Thread Daniel Kahn Gillmor
On Fri 2020-05-22 19:58:19 +0100, Mark Walters wrote: > As far as I can see the split-window-sensibly version splits the > window into two equal parts, whereas the split-window-vertically > version (deliberately) makes the message pane bigger than the thread > pane. I find this argument

Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-22 Thread Mark Walters
Hi > For some historical context, split-window-sensibly was introduced in 2009 [1] > and the (split-window-vertically (/ (window-height) 4)) code in 2012 [2]. The > two functions seem pretty interchangeable. As far as I can see the split-window-sensibly version splits the window into two

Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-21 Thread Radu Butoi
Daniel Kahn Gillmor writes: > I like this proposal, and the simplification that it gives to the > notmuch-emacs codebase. However, this thread is the first place i've > learned about split-window-sensibly, so i'm probably not eligible to > really judge the merits here. For some historical

Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-21 Thread Daniel Kahn Gillmor
On Sat 2020-05-02 20:11:09 -0400, Radu Butoi wrote: > This uses the standard Emacs function `split-window-sensibly` to split a > window horizontally or vertically depending on space when opening a > message in tree view. By default, split-width-threshold is 160 columns > (and -height- is nil), so

Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-09 Thread Radu Butoi
Hi David, David Bremner writes: > We seem to have got into the habit of updating the NEWS file right > before release. This seems to work OK, and avoids some conflicts between > patch series. Makes sense, probably something like: When opening message pane in tree-mode, split window

Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-03 Thread David Bremner
Radu Butoi writes: > Also, should I update the NEWS file? I see its latest changes are in > November and there's been user-visible changes since. We seem to have got into the habit of updating the NEWS file right before release. This seems to work OK, and avoids some conflicts between patch