Re: [PATCH] fix FTBFS with glib
Tomi Ollila venit, vidit, dixit 2021-02-12 19:48:27: > On Thu, Feb 11 2021, Michael J. Gruber wrote: > > > With newer glib, notmuch FTBFS because of C linkage error. This is due > > If/when the alternative change is send (if it works), then it would be > nice if this FTBFS were opened (i searched it but deliberately leave > it still a mystery for some of us ;) Hi Tomi, I don't fully grok your sentence - do you mean I should spell out FTBFS as "fails to build from source"? It's packager lingo, sorry ;) Michael ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] fix FTBFS with glib
On Thu, Feb 11 2021, Michael J. Gruber wrote: > With newer glib, notmuch FTBFS because of C linkage error. This is due If/when the alternative change is send (if it works), then it would be nice if this FTBFS were opened (i searched it but deliberately leave it still a mystery for some of us ;) Tomi > to a misplaced include (inside an extern "C") which was always there > but exposed only recently through this change in glib: > > https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1715 > > Move to the include to the outside of the extern block. > > Signed-off-by: Michael J Gruber > --- > lib/notmuch-private.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h > index 2fbf7ab9..46845253 100644 > --- a/lib/notmuch-private.h > +++ b/lib/notmuch-private.h > @@ -31,6 +31,8 @@ > > #include "notmuch.h" > > +#include "gmime-extra.h" > + > NOTMUCH_BEGIN_DECLS > > #include > @@ -47,8 +49,6 @@ NOTMUCH_BEGIN_DECLS > > #include > > -#include "gmime-extra.h" > - > #include "xutil.h" > #include "error_util.h" > #include "string-util.h" > -- > 2.30.0.368.g1c478ce6f6 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] fix FTBFS with glib
David Bremner venit, vidit, dixit 2021-02-12 13:57:29:
> Michael J Gruber writes:
>
> > With newer glib, notmuch FTBFS because of C linkage error. This is due
> > to a misplaced include (inside an extern "C") which was always there
> > but exposed only recently through this change in glib:
> >
> > https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1715
> >
> > Move to the include to the outside of the extern block.
>
> Thanks for the patch. I have some questions / comments.
>
> 1) What version of glib are we talking about? Is it released yet?
This showed up due to massive FTBFS on Fedora 34 (not released yet, but
branched for release).
glib 2.67.3 has the pertaining commit 51003d40.
> 2) The reason this works is that gmime-extra.h has its own extern
> "C". If respinning the patch, it might be worth commenting on that.
Yes. If you don't distinguish betwenn h/hpp then that is the way to go.
> 3) I observed that just deleting #include "gmime-extra.h" from
> notmuch-private.h works fine, presumably because it is included where it
> is actually needed. In some sense this seems like a nicer solution. What
> do you think?
Interesting. I assumed it's there for a reason. You introduced it in
cbb2d560 ("lib/cli: replace use of g_mime_message_get_sender", 2017-05-05)
so I guess you're the best person to ask whether it's till needed :)
Removing an unnecessary include would be the best solution, of course.
Cheers
Michael
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] fix FTBFS with glib
Michael J Gruber writes: > With newer glib, notmuch FTBFS because of C linkage error. This is due > to a misplaced include (inside an extern "C") which was always there > but exposed only recently through this change in glib: > > https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1715 > > Move to the include to the outside of the extern block. Thanks for the patch. I have some questions / comments. 1) What version of glib are we talking about? Is it released yet? 2) The reason this works is that gmime-extra.h has its own extern "C". If respinning the patch, it might be worth commenting on that. 3) I observed that just deleting #include "gmime-extra.h" from notmuch-private.h works fine, presumably because it is included where it is actually needed. In some sense this seems like a nicer solution. What do you think? d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
