Re: [PATCH] lib/message-file: plug three memleaks.

2011-05-09 Thread Austin Clements
Cool.  This looks like a pretty nasty leak and I'm pretty sure your
patch is correct (though it took me a while to convince myself!).

My one nit is code style.  There should be a space between the
function name and the paren.  (Oddly, the is_received handling that
you changed is the only place in notmuch where I've seen this style
violated; but there's no sense in spreading this inconsistency.)

On Mon, May 9, 2011 at 2:46 AM, Anton Khirnov an...@khirnov.net wrote:
 On Fri, 15 Apr 2011 16:43:58 +0200, Anton Khirnov an...@khirnov.net wrote:
 ---
  lib/message-file.c |    5 +
  1 files changed, 5 insertions(+), 0 deletions(-)

 diff --git a/lib/message-file.c b/lib/message-file.c
 index 7722832..b7b3286 100644
 --- a/lib/message-file.c
 +++ b/lib/message-file.c
 @@ -341,12 +341,17 @@ notmuch_message_file_get_header 
 (notmuch_message_file_t *message,
               strncpy(combined_header,header_sofar,hdrsofar);
               *(combined_header+hdrsofar) = ' ';
               strncpy(combined_header+hdrsofar+1,decoded_value,newhdr+1);
 +             free(decoded_value);
               g_hash_table_insert (message-headers, header, 
 combined_header);
           }
       } else {
           if (header_sofar == NULL) {
               /* Only insert if we don't have a value for this header, yet. 
 */
               g_hash_table_insert (message-headers, header, decoded_value);
 +         } else {
 +             free(header);
 +             free(decoded_value);
 +             decoded_value = header_sofar;
           }
       }
       /* if we found a match we can bail - unless of course we are
 --
 1.7.4.1

 ___
 notmuch mailing list
 notmuch@notmuchmail.org
 http://notmuchmail.org/mailman/listinfo/notmuch

 ping

 --
 Anton Khirnov
 ___
 notmuch mailing list
 notmuch@notmuchmail.org
 http://notmuchmail.org/mailman/listinfo/notmuch

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH] lib/message-file: plug three memleaks.

2011-05-09 Thread Jameson Graef Rollins
Hey, Anton.  Thanks for identifying and fixing these.  I've pushed this
to the r-c/0.6 branch.

jamie.


pgpAdvniISBRY.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch