Re: [PATCH] use custom-face-edit value-type in notmuch-search-line-faces
On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: This enables the proper face customization UI for notmuch-search-line-faces. Thanks. That's a nice improvement. Applied and pushed. -Carl -- carl.d.wo...@intel.com pgpUY5X1cNy2O.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] use custom-face-edit value-type in notmuch-search-line-faces
On Sat, 26 Mar 2011 22:26:26 -0700, Jameson Rollins jroll...@finestructure.net wrote: On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: This enables the proper face customization UI for notmuch-search-line-faces. Hey, folks. amdragon was the one who figured out that custom-face-edit was the correct value-type to use to get the face customization ui for the notmuch-search-line-faces list. However, he seems to think this might not be the right solution. Austin: care to comment? jamie. Non-text part: application/pgp-signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch No idea why it wouldn't be a good solution, only negative thing I could find was a comment FIXIT: Use a better equivalent to custom-face-edit if there is one in diredful.el:312 [1] FWIW, in Org-mode (org-todo-keyword-faces @ org-faces.el:355-371 [2], exactly the same use case) they do it like this: :type '(repeat (cons (string :tag Keyword) (choice :tag Face (string :tag Color) (sexp :tag Face) [1] http://www.emacswiki.org/emacs-en/diredful.el [2] http://orgmode.org/w/?p=org-mode.git;a=blob;f=lisp/org-faces.el;h=7bb3055c7d707b069ee826dfff54b8e441566e3e;hb=HEAD ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] use custom-face-edit value-type in notmuch-search-line-faces
On Sun, Mar 27, 2011 at 1:26 AM, Jameson Rollins jroll...@finestructure.net wrote: On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: This enables the proper face customization UI for notmuch-search-line-faces. Hey, folks. amdragon was the one who figured out that custom-face-edit was the correct value-type to use to get the face customization ui for the notmuch-search-line-faces list. However, he seems to think this might not be the right solution. Austin: care to comment? My concern is that it's unclear if the custom-face-edit widget is considered a public interface, or if it's internal to customize and thus could change at any time. These things are always a bit murky in Emacs. custom-face-edit has been around for a few major versions, though it only recently (somewhere between Emacs 22 and 23) became embeddable in a customize widget like this. We should just ask on an Emacs mailing list if this is okay, or if it will break catastrophically and without warning at some point (or if there's a more official solution). ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] use custom-face-edit value-type in notmuch-search-line-faces
On Sun, 27 Mar 2011 22:57:46 -0400, Austin Clements amdra...@mit.edu wrote: My concern is that it's unclear if the custom-face-edit widget is considered a public interface, or if it's internal to customize and thus could change at any time. These things are always a bit murky in Emacs. custom-face-edit has been around for a few major versions, though it only recently (somewhere between Emacs 22 and 23) became embeddable in a customize widget like this. We should just ask on an Emacs mailing list if this is okay, or if it will break catastrophically and without warning at some point (or if there's a more official solution). Ok. Thanks so much for the clarification, Austin. I'll ping the emacs list and see what turns up. Maybe there's a better alternative, or maybe we can ask that it be turned public. jamie. pgpdmtqcDj5F7.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] use custom-face-edit value-type in notmuch-search-line-faces
On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: This enables the proper face customization UI for notmuch-search-line-faces. Hey, folks. amdragon was the one who figured out that custom-face-edit was the correct value-type to use to get the face customization ui for the notmuch-search-line-faces list. However, he seems to think this might not be the right solution. Austin: care to comment? jamie. pgpWvD5DAPR1G.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
