Re: [PATCH 01/27] emacs: silence byte-compiler
Jonas Bernoulli writes: > --- > emacs/notmuch-tree.el | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el > index f342f85a..7b1e34ca 100644 > --- a/emacs/notmuch-tree.el > +++ b/emacs/notmuch-tree.el > @@ -42,6 +42,11 @@ (declare-function notmuch-read-query "notmuch" (prompt)) > (declare-function notmuch-search-find-thread-id "notmuch" (&optional bare)) > (declare-function notmuch-search-find-subject "notmuch" ()) > > +;; For `notmuch-tree-next-thread-from-search'. > +(declare-function notmuch-search-next-thread "notmuch" ()) > +(declare-function notmuch-search-previous-thread "notmuch" ()) > +(declare-function notmuch-tree-from-search-thread "notmuch" ()) > + > ;; the following variable is defined in notmuch.el > (defvar notmuch-search-query-string) LGTM, I have a similar patch here: id:20200908171536.20679-1-j...@jb55.com Reviewed-by: William Casarin ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 01/27] emacs: silence byte-compiler
William Casarin writes: > LGTM, I have a similar patch here: id:20200908171536.20679-1-j...@jb55.com So if I understood correctly the problem with that was that you were unable to run the tests and therefore couldn't confirm that you fixed the issue or even that there was an issue in the first place. Well I was able to build and test and I can confirm that there is an issue and that your commit fixes it. So it should be merged (though I would merge my own variant because of the extra comment ;-). Cheers, Jonas ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 01/27] emacs: silence byte-compiler
Jonas Bernoulli writes: > William Casarin writes: >> LGTM, I have a similar patch here: id:20200908171536.20679-1-j...@jb55.com > > So if I understood correctly the problem with that was that you were > unable to run the tests and therefore couldn't confirm that you fixed > the issue or even that there was an issue in the first place. More so I got a bug report from a user that I couldn't replicate. I haven't run the tests. > Well I was able to build and test and I can confirm that there is an > issue and that your commit fixes it. So it should be merged (though > I would merge my own variant because of the extra comment ;-). Sounds good, happy to use this patch instead. Cheers, Will ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
