Re: [PATCH 1/2] Vim: Respect excluded tags when showing a thread

2021-04-28 Thread David Bremner
Felipe Contreras  writes:

> On Tue, Apr 27, 2021 at 3:09 PM David Bremner  wrote:
>>
>> Felipe Contreras  writes:
>>
>> OK, let me know if I should revert the second patch.
>
> Yes please.
>
> -- 
> Felipe Contreras

reverted (on master; it was never on release).
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH 1/2] Vim: Respect excluded tags when showing a thread

2021-04-27 Thread Felipe Contreras
On Tue, Apr 27, 2021 at 3:09 PM David Bremner  wrote:
>
> Felipe Contreras  writes:
>
> > On Mon, Apr 26, 2021 at 6:39 PM David Bremner  wrote:
> >>
> >> Felipe Contreras  writes:
> >> >
> >> > I don't need to test it, the patch is obviously correct.
> >> >
> >> > Reviewed-by: Felipe Contreras 
> >>
> >> Famous last words ;). But OK, applied to master.
> >
> > Er, I acked the first patch, not the second.
> >
> > The second one will likely introduce issues.
>
> OK, let me know if I should revert the second patch.

Yes please.

-- 
Felipe Contreras
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH 1/2] Vim: Respect excluded tags when showing a thread

2021-04-27 Thread David Bremner
Felipe Contreras  writes:

> On Mon, Apr 26, 2021 at 6:39 PM David Bremner  wrote:
>>
>> Felipe Contreras  writes:
>> >
>> > I don't need to test it, the patch is obviously correct.
>> >
>> > Reviewed-by: Felipe Contreras 
>>
>> Famous last words ;). But OK, applied to master.
>
> Er, I acked the first patch, not the second.
>
> The second one will likely introduce issues.

OK, let me know if I should revert the second patch.

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH 1/2] Vim: Respect excluded tags when showing a thread

2021-04-27 Thread Felipe Contreras
On Mon, Apr 26, 2021 at 6:39 PM David Bremner  wrote:
>
> Felipe Contreras  writes:
> >
> > I don't need to test it, the patch is obviously correct.
> >
> > Reviewed-by: Felipe Contreras 
>
> Famous last words ;). But OK, applied to master.

Er, I acked the first patch, not the second.

The second one will likely introduce issues.

-- 
Felipe Contreras
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH 1/2] Vim: Respect excluded tags when showing a thread

2021-04-26 Thread David Bremner
Felipe Contreras  writes:
>
> I don't need to test it, the patch is obviously correct.
>
> Reviewed-by: Felipe Contreras 

Famous last words ;). But OK, applied to master.

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH 1/2] Vim: Respect excluded tags when showing a thread

2021-04-25 Thread Felipe Contreras
On Fri, Apr 23, 2021 at 7:23 AM David Bremner  wrote:
>
> Jules Aguillon  writes:
>
> > Other queries have exclude_tags taken into account but this one.
> > This is annoying when using an excluded tag to ignore past messages from a
> > thread (for example the 'deleted' tag), the entire thread is shown all the
>
> The two of you are the most recent submitters of patches [1] to the vim
> frontend for notmuch. You might want to consider helping test and/or
> review each other's patches.

I don't need to test it, the patch is obviously correct.

Reviewed-by: Felipe Contreras 

-- 
Felipe Contreras
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH 1/2] Vim: Respect excluded tags when showing a thread

2021-04-23 Thread David Bremner
Jules Aguillon  writes:

> Other queries have exclude_tags taken into account but this one.
> This is annoying when using an excluded tag to ignore past messages from a
> thread (for example the 'deleted' tag), the entire thread is shown all the

Hi;

The two of you are the most recent submitters of patches [1] to the vim
frontend for notmuch. You might want to consider helping test and/or
review each other's patches.

d

[1]: https://nmbug.notmuchmail.org/nmweb/search/vim
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org