Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types

2011-12-02 Thread Justus Winter
Quoting James Westby (2011-12-02 00:32:30) On Thu, 01 Dec 2011 22:25:41 +0100, Sebastian Spaeth sebast...@sspaeth.de wrote: This strikes me as a rather good thing, so the patches went in. Hah, I've just seen this, and I'm going to guess that it fixes my problems too. ... I've tested and it

Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types

2011-12-02 Thread James Westby
On Fri, 02 Dec 2011 13:35:11 +0100, Justus Winter 4win...@informatik.uni-hamburg.de wrote: Huh, strange. My patch isn't supposed to change anything, it just enables the ctypes package to check whether the functions from libnotmuch are called with the right parameters, thus preventing mistakes

Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types

2011-12-02 Thread James Westby
On Fri, 02 Dec 2011 09:20:35 -0500, James Westby jw+deb...@jameswestby.net wrote: I'll test again to make sure that I have this correct, but my tests yesterday certainly suggested that your patches fixed this. Yep, segfaults a plenty dropping your second patch that go away again when it is

Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types

2011-12-02 Thread Justus Winter
Quoting James Westby (2011-12-03 00:24:18) On Fri, 02 Dec 2011 09:20:35 -0500, James Westby jw+deb...@jameswestby.net wrote: I'll test again to make sure that I have this correct, but my tests yesterday certainly suggested that your patches fixed this. Yep, segfaults a plenty dropping your

Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types

2011-12-01 Thread Sebastian Spaeth
On Mon, 28 Nov 2011 13:36:44 +0100, Justus Winter wrote: Well, quoting my commit message: Add type information to the ctypes._FuncPtr wrappers and use the wrapper classes instead of c_void_p for pointers to notmuch_*_t. This enables the ctypes library to type check parameters being

Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types

2011-12-01 Thread James Westby
On Thu, 01 Dec 2011 22:25:41 +0100, Sebastian Spaeth sebast...@sspaeth.de wrote: This strikes me as a rather good thing, so the patches went in. Hah, I've just seen this, and I'm going to guess that it fixes my problems too. ... I've tested and it seems to work, so my patch is unneeded witht

Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types

2011-11-28 Thread Justus Winter
Quoting Sebastian Spaeth (2011-11-02 08:25:53) On Mon, 10 Oct 2011 00:12:53 +0200, Justus Winter 4win...@informatik.uni-hamburg.de wrote: Signed-off-by: Justus Winter 4win...@informatik.uni-hamburg.de --- bindings/python/notmuch/globals.py | 38 +++- Hi

Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types

2011-11-02 Thread Sebastian Spaeth
On Mon, 10 Oct 2011 00:12:53 +0200, Justus Winter 4win...@informatik.uni-hamburg.de wrote: Signed-off-by: Justus Winter 4win...@informatik.uni-hamburg.de --- bindings/python/notmuch/globals.py | 38 +++- Hi there, catching up on email, sorry for the delay.