Re: [PATCH 1/2 v2] test-lib: mark function variables as local

2020-05-12 Thread Daniel Kahn Gillmor
On Sat 2020-05-09 08:47:10 -0300, David Bremner wrote: > I'm confused about where to apply 2/2. If I apply it on top of (updated) > master, it causes test failures. If I apply after the rest of the > patches in this thread then presumably there is some interval where the > build is broken (if only

Re: [PATCH 1/2 v2] test-lib: mark function variables as local

2020-05-10 Thread David Bremner
Daniel Kahn Gillmor writes: > > yes, that's right. For certain GMime versions, there's an intermediate > breakage. I think you're saying you want me to rerun the series, with > these things split out so that even on systems with older GMime, tests > pass at every commit. I'll try to get that

Re: [PATCH 1/2 v2] test-lib: mark function variables as local

2020-05-10 Thread Daniel Kahn Gillmor
On Sat 2020-05-09 08:47:10 -0300, David Bremner wrote: > I'm confused about where to apply 2/2. If I apply it on top of (updated) > master, it causes test failures. If I apply after the rest of the > patches in this thread then presumably there is some interval where the > build is broken (if only

Re: [PATCH 1/2 v2] test-lib: mark function variables as local

2020-05-09 Thread David Bremner
Daniel Kahn Gillmor writes: > Several functions in test/test-lib.sh used variable names that are > also used outside of those functions (e.g. $output and $expected are > used in many of the test scripts), but they are not expected to > communicate via those variables. > > We mark those variables

Re: [PATCH 1/2 v2] test-lib: mark function variables as local

2020-05-09 Thread Tomi Ollila
On Fri, May 08 2020, Daniel Kahn Gillmor wrote: > Several functions in test/test-lib.sh used variable names that are > also used outside of those functions (e.g. $output and $expected are > used in many of the test scripts), but they are not expected to > communicate via those variables. > > We