On Fri, Dec 24 2021, David Bremner wrote:
> In [1] Ryan Schmidt reported a problem on macports [2] with notmuch
> finding an existing installed version of libnotmuch during the build
> when the user specified LDFLAGS including the libnotmuch install
> directory.
>
> This change should prevent that.
>
> LDFLAGS also occurs in FINAL_LIBNOTMUCH_LDFLAGS. The only built
> library linked to that is util/libtnotmuch_util.a, and that passed as
> explicit (relative) path, and is thus not affected by -L.
>
> [1]: id:7851cab5-4556-4931-a0a2-37003e56c...@ryandesign.com
>
> [2]: The problem does not arise when libnotmuch is installed into a
> "system" library path that the compiler/linker searches by default.
This series looks good to me, and id:87lf0thhft@tethera.net
should still work.
Tomi
> ---
> Makefile.global | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.global b/Makefile.global
> index fe79121d..e6b00815 100644
> --- a/Makefile.global
> +++ b/Makefile.global
> @@ -52,7 +52,7 @@ PV_FILE=bindings/python/notmuch/version.py
> # Smash together user's values with our extra values
> FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CPPFLAGS) $(CFLAGS)
> $(WARN_CFLAGS) $(extra_cflags) $(CONFIGURE_CFLAGS)
> FINAL_CXXFLAGS = $(CPPFLAGS) $(CXXFLAGS) $(WARN_CXXFLAGS) $(extra_cflags)
> $(extra_cxxflags) $(CONFIGURE_CXXFLAGS)
> -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Lutil -lnotmuch_util -Llib -lnotmuch
> +FINAL_NOTMUCH_LDFLAGS = -Lutil -lnotmuch_util -Llib -lnotmuch $(LDFLAGS)
> ifeq ($(LIBDIR_IN_LDCONFIG),0)
> FINAL_NOTMUCH_LDFLAGS += $(RPATH_LDFLAGS)
> endif
> --
> 2.34.1
>
> ___
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-le...@notmuchmail.org
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org