Re: [PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags change

2011-07-12 Thread Louis Rilling
On 11/07/11 20:03 -0400, Austin Clements wrote: The convention in notmuch is to use notmuch_bool_t, TRUE, and FALSE (though, admittedly, I don't know why; avoiding C99-isms?) And bool is already used at another place in message.cc: struct maildir_flag_tag { char flag;

Re: [PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags change

2011-07-11 Thread Austin Clements
I worry that this may compound the confusion caused by mutt's handling of the new flag, but I suppose people aren't likely to manipulate any of the other maildir-synchronized flags without also marking the message as seen. At any rate, the change is certainly correct technically. A few nits

Re: [PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags change

2011-07-11 Thread Austin Clements
Quoth Louis Rilling on Jul 12 at 12:38 am: On 11/07/11 16:07 -0400, Austin Clements wrote: I worry that this may compound the confusion caused by mutt's handling of the new flag, but I suppose people aren't likely to manipulate any of the other maildir-synchronized flags without also