Re: [PATCH v2] configure: fix out of tree build; check unsafe characters in srcdir

2019-08-29 Thread David Bremner
Tomi Ollila writes: > While check for GMime session key extraction support... was made > out of tree build compatible, related (and some unrelated) unsafe > characters are now checked in notmuch source directory path. pushed. Note that while notmuch builds out of tree, the test suite is curren

Re: [PATCH v2] configure: fix out of tree build; check unsafe characters in srcdir

2019-08-29 Thread David Bremner
Tomi Ollila writes: > To my surprise mkdir 'build dir'; cd 'build dir'; ../notmuch/configure > and then `make` just worked. :D > > I did not dare to run tests -- I'm pretty sure that would fail... > 20-ish tests currently fail looking for json_check_nodes.py But yeah, many other tests explode if

Re: [PATCH v2] configure: fix out of tree build; check unsafe characters in srcdir

2019-08-29 Thread Tomi Ollila
On Thu, Aug 29 2019, Daniel Kahn Gillmor wrote: > On Mon 2019-08-26 20:03:46 +0300, Tomi Ollila wrote: >> While check for GMime session key extraction support... was made >> out of tree build compatible, related (and some unrelated) unsafe >> characters are now checked in notmuch source directory

Re: [PATCH v2] configure: fix out of tree build; check unsafe characters in srcdir

2019-08-29 Thread Daniel Kahn Gillmor
On Mon 2019-08-26 20:03:46 +0300, Tomi Ollila wrote: > While check for GMime session key extraction support... was made > out of tree build compatible, related (and some unrelated) unsafe > characters are now checked in notmuch source directory path. LGTM. Thanks, Tomi. > The known unsafe chara