Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-06 Thread Jani Nikula
On Mar 5, 2012 11:11 PM, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Mon, 5 Mar 2012 22:55:54 +0200, Jani Nikula j...@nikula.org wrote: On Mar 5, 2012 5:43 PM, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Daniel Schoepe
On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe dan...@schoepe.org wrote: notmuch-saved-search-sort-function might destructively modify its input (`sort' does that, for instance), so it should not be

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Tomi Ollila
On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe dan...@schoepe.org wrote: On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe dan...@schoepe.org wrote: notmuch-saved-search-sort-function might

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Dmitry Kurochkin
On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe dan...@schoepe.org wrote: On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe dan...@schoepe.org wrote: notmuch-saved-search-sort-function might

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Jani Nikula
On Mar 5, 2012 5:43 PM, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe dan...@schoepe.org wrote: On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Daniel Schoepe
On Mar 5, 2012 5:43 PM, Dmitry Kurochkin dmitry.kuroch...@gmail.com I do not buy the argument that we should help users who implement their own sorting functions but do not read documentation for functions they use. Apparently, those who implemented the `sort' function had similar ideas. And

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-05 Thread Dmitry Kurochkin
On Mon, 5 Mar 2012 22:55:54 +0200, Jani Nikula j...@nikula.org wrote: On Mar 5, 2012 5:43 PM, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Mon, 05 Mar 2012 12:17:43 +0100, Daniel Schoepe dan...@schoepe.org wrote: On Mon, 05 Mar 2012 06:21:52 +0400, Dmitry Kurochkin

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-04 Thread Dmitry Kurochkin
On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe dan...@schoepe.org wrote: notmuch-saved-search-sort-function might destructively modify its input (`sort' does that, for instance), so it should not be given notmuch-saved-searches directly. --- -1 I think we should require

Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

2012-03-03 Thread Jani Nikula
On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe dan...@schoepe.org wrote: notmuch-saved-search-sort-function might destructively modify its input (`sort' does that, for instance), so it should not be given notmuch-saved-searches directly. Hi Daniel, thanks for fixing this. Works for me.